| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
| |
This will cause some pain for now, but now is really the best time
to do this kind of thing.
|
| |
|
|
|
|
|
| |
The most frequent changes are:
- Rewording messages about poisoned locks
- Correcting some error types
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
> Check `unwrap_used` section of Clippy documentation for details;
>
> https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
This adds the following Clippy configuration to crates;
#![deny(clippy::unwrap_used)]
**Warning** while tests and compiler do not show any errors, the submitted
changes are very much a Work In Progress and mistakes may have been made. Check
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/67
Merge Request thread for more details.
|
| |/ |
|
| |
|
|
| |
Issue #74
|
| | |
|
| | |
|
| |
|
|
|
| |
I've tried to remove some of possible panics, and improve the
documentation for when the others might occur.
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
> Check `missing_panics_doc` section of Clippy documentation for details;
>
> https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
This adds the following Clippy configuration to crates;
#![deny(clippy::missing_panics_doc)]
And adds necessary doc-comments to methods that may panic.
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Check `implicit_clone` section of Clippy documentation for details;
>
> https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone
This adds, and addresses, the following Clippy configuration to crates;
#![deny(clippy::implicit_clone)]
And moves related line within `maint/add_warning.py` file. My intent is to
mitigate extra edits after merging, so please let me know if I need to do this
last bit differently.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
> Check `cast_lossless` section of Clippy documentation for details;
>
> https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
This adds the following Clippy configuration to crates;
#![deny(clippy::cast_lossless)]
And applies suggested Clippy and `cargo fmt` fixes.
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously the DirResponse contained a String for the output.
By changing it to a Vec<u8> the caller has to parse the Vec<u8> and deal with potential failures.
With this change `fetch_multiple`'s
`useful_responses` should also contain non-UTF-8 responses.
This will case an Err to be returned in the `download_attempt` function if the
DirResponse does not contain valid UTF-8.
|
| | |
| |
| |
| |
| |
| | |
Closes #160
Signed-off-by: David Goulet <[email protected]>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The latest version of the fslock crate has an optional feature that
allows file-locks to exclude one another even if they are opened
within the same process. On Windows this behavior comes for free;
on Unix it depends on an internal map of (dev,inode) pairs.
Here we upgrade to the latest version of the fslock crate, and use
this feature.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |/ |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
This is not 100% what we'll want long term:
- We might want more kinds of events
- We'll probably want to generate them in a more reliable way
- We might want some of this mechanism to be in a crate other than
DirMgr.
But for now, let's use this as a start and get experience with it.
|
| |
|
|
|
|
|
|
| |
They don't have actual documented security issues but it makes
`cargo audit` complain
https://rustsec.org/advisories/RUSTSEC-2018-0017
https://rustsec.org/advisories/RUSTSEC-2020-0077
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
This would have saved ahf and me a lot of confusion in debugging a
situation where we were cloning a reference of a type that didn't
implement Clone.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
This truly is an i32, not a strings: it is a specified requirement
in parsing consensus documents.
|
| |
|
|
| |
(Squashed from typed-netdir-params)
|
| | |
|
| |
|
|
|
|
| |
This is a somewhat obnoxious change in its scope and requirements,
but it makes it easier to understand what the real public and
private parts of our APIs are.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|