aboutsummaryrefslogtreecommitdiff
path: root/tor-chanmgr/src
Commit message (Collapse)AuthorAgeFilesLines
* Move all crates into a `crates` subdirectory.Nick Mathewson2021-08-276-1133/+0
| | | | | This will cause some pain for now, but now is really the best time to do this kind of thing.
* WIP: Add the "unwrap_used" lint.S0AndS02021-08-241-0/+1
| | | | | | | | | | | | | | | | | > Check `unwrap_used` section of Clippy documentation for details; > > https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used This adds the following Clippy configuration to crates; #![deny(clippy::unwrap_used)] **Warning** while tests and compiler do not show any errors, the submitted changes are very much a Work In Progress and mistakes may have been made. Check https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/67 Merge Request thread for more details.
* Switch all uses of the log crate to the tracing.Jani Monoses2021-08-201-1/+1
| | | | Issue #74
* Merge remote-tracking branch 'origin/mr/60'Nick Mathewson2021-08-181-0/+1
|\
| * Add the "missing_panics_doc" lint.S0AndS02021-08-131-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | > Check `missing_panics_doc` section of Clippy documentation for details; > > https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc This adds the following Clippy configuration to crates; #![deny(clippy::missing_panics_doc)] And adds necessary doc-comments to methods that may panic.
* | Add the "implicit_clone" lint.S0AndS02021-08-171-0/+1
|/ | | | | | | | | | | | | | > Check `implicit_clone` section of Clippy documentation for details; > > https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone This adds, and addresses, the following Clippy configuration to crates; #![deny(clippy::implicit_clone)] And moves related line within `maint/add_warning.py` file. My intent is to mitigate extra edits after merging, so please let me know if I need to do this last bit differently.
* Use add_warnings.py for clippy::cast_losslessNick Mathewson2021-08-131-1/+1
|
* Add the "cast_lossless" lint.S0AndS02021-08-121-0/+1
| | | | | | | | | | | | > Check `cast_lossless` section of Clippy documentation for details; > > https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless This adds the following Clippy configuration to crates; #![deny(clippy::cast_lossless)] And applies suggested Clippy and `cargo fmt` fixes.
* Fix typos in tor-chanmgrLennart Kloock2021-08-121-2/+2
|
* Add unnecessary_wraps to the big warning list.Nick Mathewson2021-08-061-0/+1
|
* Fix typos and other spelling mistakesrls2021-07-314-5/+5
|
* address a bunch of hopefully uncontroversial lintsDaniel Eades2021-07-201-2/+2
|
* Allow tor-rtcompat to build with no runtimes.Nick Mathewson2021-07-012-10/+10
| | | | | | | | | | | | Thanks to cargo's version-2 feature resolver, we can require a runtime for tests only. I'm also making it so that the functions that create or fetch Runtimes only exist when one of the runtime features is enabled. For now that seems like a better solution than having those functions exist but panic. Closes #129.
* Add clippy warn needless pass by valueYUAN LYU2021-06-211-0/+1
|
* Add clippy warn needless borrowYUAN LYU2021-06-211-0/+1
|
* Remove most (all?) panics from tor-chanmgr::mgr::mapNick Mathewson2021-06-191-10/+22
| | | | | Improve testing for cases where change_state() is given a bad function.
* Make a few error types implement CloneNick Mathewson2021-06-141-2/+9
| | | | | | | To make this work we have to wrap std::io::Error in an Arc. The benefit of having these errors implement Clone is that we can provide the same Error in response to multiple requests when they are all waiting on the same operation.
* linkspec: Define owned variants of ChanTarget and CircTarget.Nick Mathewson2021-06-132-65/+6
|
* Add noop_method_call warning.Nick Mathewson2021-05-271-0/+1
| | | | | | This would have saved ahf and me a lot of confusion in debugging a situation where we were cloning a reference of a type that didn't implement Clone.
* Use the "typos" tool to fix some spellingNick Mathewson2021-05-262-2/+2
|
* Enable cargo_common_metadata warning.Nick Mathewson2021-05-251-0/+1
|
* Module docs for remaining cratesNick Mathewson2021-05-251-2/+9
|
* Add the "unreachable_pub" lint.Nick Mathewson2021-05-183-12/+14
| | | | | | This is a somewhat obnoxious change in its scope and requirements, but it makes it easier to understand what the real public and private parts of our APIs are.
* Prefer "relay" to "server" when appropriate.Nick Mathewson2021-05-182-2/+2
|
* Fix documentation warnings.Nick Mathewson2021-05-051-1/+1
|
* Add trait_duplication_in_bounds warning.Nick Mathewson2021-05-031-0/+1
|
* Add unseparated_literal_suffix lint, and fix it.Nick Mathewson2021-05-031-0/+1
|
* Add a few more clippy warningsNick Mathewson2021-05-031-0/+5
|
* Make the MockNetProvider builder non-consuming.Nick Mathewson2021-05-031-14/+11
|
* Split mocking parts of rtcompat into new rtmock crate.Nick Mathewson2021-05-031-4/+2
| | | | | Since these parts are testing-only, let's take steps to make sure we don't ship them in production by accident.
* Much-improved tests for tor_chanmgr::builderNick Mathewson2021-04-303-1/+146
| | | | | | Now that we have MockNetRuntime and MockSleepRuntime, we can use them to test a channel-builder by replaying the contents of a TLS stream that it will accept.
* Add some more clippy warnings to our list.Nick Mathewson2021-04-271-1/+6
|
* Enforce (and obey) clippy lints about exhaustive enums, structs.Nick Mathewson2021-04-272-0/+4
| | | | | | | | These lints force us to declare our exported enums and exhaustive-looking structs as non-exhaustive (so that we can add to them in the future without breaking our API) or to explicitly disable the warning for a given enum/struct (to say that we _intend_ for additions to be a breaking change).
* cargo fix --edition-idiomsNick Mathewson2021-04-261-1/+1
|
* Another test in ChanMgr, for TargetInfo.Nick Mathewson2021-04-231-0/+19
|
* Refactor and simplify ChanMgr to use AbstractChanMgr.Nick Mathewson2021-04-237-674/+170
|
* Full documentations on the new parts of ChanMgr.Nick Mathewson2021-04-232-24/+157
|
* Start on tests for reactored ChanMsg.Nick Mathewson2021-04-233-50/+350
|
* Begin refactoring ChanMgr to have better separation of concernsNick Mathewson2021-04-224-0/+290
| | | | | Additionally: Use futures::future::Shared instead of event_listener.
* Stop using anyhow in tor_chanmgr.Nick Mathewson2021-04-223-16/+33
| | | | | It seemed like a good idea at first, but we need to be able to tell the difference between these error types more easily.
* Remove the no-longer-needed "global runtime" code.Nick Mathewson2021-04-171-16/+16
|
* Move timer functions into an extension trait.Nick Mathewson2021-04-171-7/+5
|
* Move around the public modules in tor_rtcompat.Nick Mathewson2021-04-174-5/+5
|
* Remove all non-runtime methods in tor_rtcompat.Nick Mathewson2021-04-162-5/+14
|
* Add a "Runtime" parameter to all the manager types.Nick Mathewson2021-04-161-9/+22
| | | | | This is a big change, but it is a step towards our goal of removing tor_rtcompat:: calls directly.
* rtcompat: Make TLS functionality use Runtime traits.Nick Mathewson2021-04-164-23/+7
| | | | | Now there is nothing in principle that you couldn't access from a Runtime implementation.
* Rename Rsa{Identity,Signature} to fix clippy warning.Nick Mathewson2021-03-293-7/+7
|
* Move responsibility for knowing about TLS into tor_rtcompat.Nick Mathewson2021-03-234-48/+27
| | | | Now we don't need runtime-specific stuff in tor-chanmgr.
* Refactor tokio implpementation in tor-rtcompat.Nick Mathewson2021-03-231-26/+1
| | | | | | | | | | | Now other crates don't need any 'ifdef tokio' code, since there are wrappers that implement 'futures' right. Technically, the 'futures' traits are in some ways less good than the tokio ones, but we need a consistent API if we want to support WASM someday and keep support for async_std. I'd rather hold out hope for a future version of futures::io working like tokio than to fix ourselves into the tokioverse forever.
* Missing doc for private memberNick Mathewson2021-03-021-0/+3
|