aboutsummaryrefslogtreecommitdiff
path: root/tor-cell/src
Commit message (Collapse)AuthorAgeFilesLines
* Move all crates into a `crates` subdirectory.Nick Mathewson2021-08-277-2965/+0
| | | | | This will cause some pain for now, but now is really the best time to do this kind of thing.
* WIP: Add the "unwrap_used" lint.S0AndS02021-08-241-0/+1
| | | | | | | | | | | | | | | | | > Check `unwrap_used` section of Clippy documentation for details; > > https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used This adds the following Clippy configuration to crates; #![deny(clippy::unwrap_used)] **Warning** while tests and compiler do not show any errors, the submitted changes are very much a Work In Progress and mistakes may have been made. Check https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/67 Merge Request thread for more details.
* Add a split_from() API for infallible creation of Data messages.Nick Mathewson2021-08-181-0/+11
|
* Remove panicking cases from tor-cell msg constructionNick Mathewson2021-08-183-14/+23
|
* Revisions based on new documented-panics lint.Nick Mathewson2021-08-182-2/+4
| | | | | I've tried to remove some of possible panics, and improve the documentation for when the others might occur.
* Merge remote-tracking branch 'origin/mr/60'Nick Mathewson2021-08-183-0/+9
|\
| * Add the "missing_panics_doc" lint.S0AndS02021-08-133-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | > Check `missing_panics_doc` section of Clippy documentation for details; > > https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc This adds the following Clippy configuration to crates; #![deny(clippy::missing_panics_doc)] And adds necessary doc-comments to methods that may panic.
* | Add the "implicit_clone" lint.S0AndS02021-08-171-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | > Check `implicit_clone` section of Clippy documentation for details; > > https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone This adds, and addresses, the following Clippy configuration to crates; #![deny(clippy::implicit_clone)] And moves related line within `maint/add_warning.py` file. My intent is to mitigate extra edits after merging, so please let me know if I need to do this last bit differently.
* | Remove some notes about SPEC issues that are now resolved.Nick Mathewson2021-08-162-7/+3
| |
* | Make PaddingNegotiate parsing match C tor.Nick Mathewson2021-08-161-3/+0
| |
* | More channel-cell coverage.Nick Mathewson2021-08-161-0/+17
|/ | | | "Every little helps": This gets tor-cell coverage over 90%.
* Use add_warnings.py for clippy::cast_losslessNick Mathewson2021-08-131-1/+1
|
* Merge remote-tracking branch 'origin/mr/59'Nick Mathewson2021-08-131-0/+1
|\
| * Add the "cast_lossless" lint.S0AndS02021-08-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | > Check `cast_lossless` section of Clippy documentation for details; > > https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless This adds the following Clippy configuration to crates; #![deny(clippy::cast_lossless)] And applies suggested Clippy and `cargo fmt` fixes.
* | More test cases for tor_cell::relaycell::msgNick Mathewson2021-08-131-1/+1
| |
* | Comment fixes in tor_cell::errNick Mathewson2021-08-131-3/+3
|/
* Add brackets and remove colon for better consistencyLennart Kloock2021-08-121-1/+1
|
* Add unnecessary_wraps to the big warning list.Nick Mathewson2021-08-061-0/+1
|
* Fix typos and other spelling mistakesrls2021-07-313-5/+5
|
* ResolvedVal: Rename answers() to into_answers().Nick Mathewson2021-07-271-2/+8
|
* Add support for RESOLVE and RESOLVE_PTRYuan Lyu2021-07-221-0/+5
|
* Add clippy warn needless pass by valueYUAN LYU2021-06-211-0/+1
|
* Add clippy warn needless borrowYUAN LYU2021-06-211-0/+1
|
* Fix some warnings about needless & from nightly clippyNick Mathewson2021-06-181-2/+2
|
* Make a few error types implement CloneNick Mathewson2021-06-141-2/+9
| | | | | | | To make this work we have to wrap std::io::Error in an Arc. The benefit of having these errors implement Clone is that we can provide the same Error in response to multiple requests when they are all waiting on the same operation.
* Add noop_method_call warning.Nick Mathewson2021-05-271-0/+1
| | | | | | This would have saved ahf and me a lot of confusion in debugging a situation where we were cloning a reference of a type that didn't implement Clone.
* Use the "typos" tool to fix some spellingNick Mathewson2021-05-262-2/+2
|
* Enable cargo_common_metadata warning.Nick Mathewson2021-05-251-0/+1
|
* Light tweaks to tor-cell docNick Mathewson2021-05-241-0/+6
|
* Add the "unreachable_pub" lint.Nick Mathewson2021-05-181-0/+1
| | | | | | This is a somewhat obnoxious change in its scope and requirements, but it makes it easier to understand what the real public and private parts of our APIs are.
* Check "connection" usage for when stream or channel would be better.Nick Mathewson2021-05-181-2/+2
|
* Prefer "relay" over "node" in most circumstances.Nick Mathewson2021-05-182-5/+5
|
* Fix some warnings from nightly clippyNick Mathewson2021-05-071-2/+2
|
* Resolve clippy warnings from Rust 1.52.Nick Mathewson2021-05-071-1/+2
| | | | | | | | | | Rust 1.52 just came out, and there are new clippy lints to deal with: * It spots more cases when we could use Option::map * It spots more cases when we could use Iterator::flatten * When we build a struct instance, it wants us to list the fields in the same order that the struct declares them.
* Use s.parse(), not u16::from_str_radix(s,10)Nick Mathewson2021-05-071-1/+1
| | | | | | | Clippy started warning on this with Rust 1.52. I'm fairly sure that when I wrote this code I was worried that <u16 as FromStr>::parse() might allow hex or something. But fortunately, it doesn't work that way, so I don't need to be paranoid here.
* Add trait_duplication_in_bounds warning.Nick Mathewson2021-05-031-0/+1
|
* Add unseparated_literal_suffix lint, and fix it.Nick Mathewson2021-05-034-6/+7
|
* Add a few more clippy warningsNick Mathewson2021-05-031-0/+5
|
* Add some more clippy warnings to our list.Nick Mathewson2021-04-271-1/+6
|
* Enforce (and obey) clippy lints about exhaustive enums, structs.Nick Mathewson2021-04-273-0/+7
| | | | | | | | These lints force us to declare our exported enums and exhaustive-looking structs as non-exhaustive (so that we can add to them in the future without breaking our API) or to explicitly disable the warning for a given enum/struct (to say that we _intend_ for additions to be a breaking change).
* Fix Rust-1.51 clippy warnings about acronyms in camel case.Nick Mathewson2021-03-293-22/+22
| | | | This is painful, but we shouldn't have to do it again.
* Rename Rsa{Identity,Signature} to fix clippy warning.Nick Mathewson2021-03-291-3/+3
|
* Better management for END cells in streams.Nick Mathewson2021-03-101-0/+25
|
* clippy warning on msg.rsNick Mathewson2021-03-041-8/+5
|
* Change how we sort link specifiers in extend cellsNick Mathewson2021-03-041-1/+1
| | | | | Instead of implementing a dubious PartialOrd for link spec, add a sorting function and call that explicitly.
* Avoid an is_some()/unwrap() pair in End cell parsingNick Mathewson2021-03-041-6/+8
|
* Basic support for IPv6 and begin flags.Nick Mathewson2020-12-151-0/+30
| | | | | | We now have a way to tell a circuitmgr whether we require ipv4/ipv6 support for a target address in an exit policy, and we use similar logic to set begin flags.
* Use a set of named flags for BeginFlags in tor-cell.Nick Mathewson2020-12-151-6/+32
|
* tor-cell: In netinfo, unspecified addresses are None.Nick Mathewson2020-10-291-5/+8
|
* Add a test for extending a circuit with ntor.Nick Mathewson2020-10-271-0/+10
|