| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
| |
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
|
| |
|
|
|
|
| |
There were two that relied on the the ability to have a lock
in an unlocked state. Instead, we replace those with
Option<LockFileGuard> or its equivalent.
|
| |
|
|
| |
Run maint/add_warning
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
|
| | |
|
| |
|
|
|
|
| |
The `derive_more` crate broke backward compatibility with this version,
so this change involved quite a few manual fixups.
With luck, they'll keep compatibility for some while in the future.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Change Path::display to this new function, in call sites where it's
being used for a diagnostic.
|
| | |
|
| | |
|
| |
|
|
|
| |
We should add more tests for these error representations but we want
to rework these errors so let's not do all that now.
|
| | |
|
| |
|
|
| |
We use `/` to separate, not `+`.
|
| | |
|
| |
|
|
|
|
|
| |
And also instance_peek_storage, which needs to share some code, so
determined the shape of this implementation.
Make StateDirectory have the (one) field we need.
|
| |
|
|
|
| |
state_dir doesn't support a "shared read-only" mode, so it needs an
error.
|
| |
|
|
|
|
|
| |
Introduce a Bug variant.
Then, use it for conversions from BadSlug. See the comment for why I
think this is appropriate.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This code needs fs_mistrust::Error and tor_error::ErrorKind. I think
we probably don't want fs_mistrust to depend on tor_error or vice
versa.
tor_persist is approximately the place where these two threads of
thought come together, and it's currently the lowest place where this
is needed.
Use it in tor-dirmgr too, which is currently the other place that
embodies this knowledge about fs_mistrust::Error.
|
| | |
|
| |
|
|
| |
Closes #555
|
| |
|
|
| |
Without this, some builds get a "variant is never constructed" warning.
|
| |
|
|
|
|
|
|
|
|
|
| |
Every error now has an action (what we were trying to do), a
resource (what we were trying to do it to), and a source (what
problem we encountered).
Initially I tried to add "action" and "resource" fields to error
variants individually, but that led to a combinatorial explosion.
Part of #323.
|
| |
|
