aboutsummaryrefslogtreecommitdiff
path: root/crates/tor-netdir/src
Commit message (Collapse)AuthorAgeFilesLines
* Remove now-unneeded allow(clippy::cognitive_complexity)Jim Newsome2026-07-152-4/+0
|
* add_warning: add reference to arti#2556Jim Newsome2026-07-151-1/+1
|
* Removed unnecessary lintpryty262026-07-151-2/+1
| | | | Removed unnecessary lint
* Merge branch 'microdesc-sha' into 'main'Clara Engler2026-06-252-15/+15
|\ | | | | | | | | tor-netdoc: Remove document hash from Microdesc struct (and add MicrodescAndHash for that) See merge request tpo/core/arti!4138
| * Remove renaming aliases for MicrodescAndHashIan Jackson2026-06-222-15/+15
| |
| * tor-netdoc: Break Microdesc up into Microdesc and MicrodescAndHashIan Jackson2026-06-222-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | The Microdesc type having a copy of the document hash was always weird, and it's weirder now that there's all these parse2 types that don't have it and parse2 derives on Microdesc that don't touch it. Make a new type for the descriptor and its hash. Use deref to arrange that the new type works almost like the old one. Adjust the use lines in the dependencies to temporarily import MicrodescAndHash as Microdesc.
* | tor-netdoc: Wrap port policies in InternClara Engler2026-06-241-4/+4
|/ | | | This commit wraps the port policies in an Intern.
* pick_n_weighted: change variable names for clarityJim Newsome2026-06-171-25/+25
| | | | | | | "iter" wasn't an iterator per se. Changed it to "sampled_items", and renamed other variables to call the items more generically "items" than "relay", since the mixed usage was a little confusing, and the function doesn't really know anything about relays.
* NetDir::pick_n_relays and pick_n_weighted: clarify/fix docs re zero-weight itemsJim Newsome2026-06-171-5/+7
|
* NetDir::pick_n_weighted: fix doc-comment to not refer toJim Newsome2026-06-171-2/+1
|
* Rename NetDir::pick_n_filtered_weighted -> pick_n_weightedJim Newsome2026-06-171-22/+14
|
* pick_n_filtered_weighted: move warnings logs to callerJim Newsome2026-06-171-3/+11
| | | | We have more useful context in the caller, `pick_n_relays`.
* pick_n_filtered_weighted: test and fix for rand 0.10 behaviorJim Newsome2026-06-171-79/+67
| | | | | | | | | | | | | | | | | | This tests our implementation of sampling to ensure the behavior is as-expected. It also updates the implementation so that the tests pass (It was broken when updating to rand 0.10; see https://gitlab.torproject.org/tpo/core/arti/-/work_items/1907#note_3426398). This removes the direct testing of `rand::IndexedRandom::sample_weighted`, since this is now an impplementation detail of `pick_n_filtered_weighted`, which is itself tested. Verified that this fixes the case of sometimes not being able to select a Guard in integration tests. <https://gitlab.torproject.org/tpo/core/chutney/-/work_items/40057#note_3426299> <https://gitlab.torproject.org/tpo/core/arti/-/work_items/1907#note_3408157> <https://gitlab.torproject.org/tpo/core/arti/-/work_items/2209>
* NetDir::pick_n_relays: move implementation to a testable helperJim Newsome2026-06-171-35/+60
|
* cargo fmtJim Newsome2026-06-171-5/+21
|
* Netdir::pick_n_relays: precompute weightsJim Newsome2026-06-171-19/+19
| | | | | This should be a no-op refactor to callers. It's a step towards decoupling the weighting and filtering from the sampling.
* test_zero: fix comment re 0-weight handlingJim Newsome2026-06-171-1/+0
|
* NetDir::pick_relay: update doc-comment re zero-weight handlingJim Newsome2026-06-171-1/+4
|
* maint: Run maint/add_warning to deny string slicesClara Engler2026-06-096-0/+7
| | | | | | | | | | | | This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit.
* NetDir::pick_relay: preemptively handle empty sequenceJim Newsome2026-05-271-9/+17
| | | | | | | | | | | | The `choose_weighted` behavior given an empty sequence isn't well documented and has changed over time. Handle it ourselves for consistency. Currently, the `choose_weighted` behavior appears to be to return WeightError::InvalidInput. This means the corresponding `is_empty` branch when handling WeightError::InsufficientNonZero was never exercised. (Though may have been with previous versions of the rand crate).
* relay: Crypto task now listens for new consensusDavid Goulet2026-05-261-0/+9
| | | | Signed-off-by: David Goulet <[email protected]>
* netdir: Add a debug_assert to ensure the voting interval is non-zeroGabriela Moldovan2026-05-211-0/+44
| | | | | This also adds a test, just make sure creating a `Lifetime` with voting interval = 0 is actually impossible (and stays that way).
* netdir: Add a test for start_of_sr_protocol_run()Gabriela Moldovan2026-05-211-0/+77
|
* netdir: Make start_of_sr_round() fallibleGabriela Moldovan2026-05-211-10/+12
| | | | | It's better to return a `Bug` than to panic if the consensus valid-after is invalid.
* netdir: Remove a no longer needed constantGabriela Moldovan2026-05-211-3/+0
|
* netdir: Remove start_of_day_containing()Gabriela Moldovan2026-05-211-29/+0
| | | | This is no longer used.
* netdir: Fix SRV lifetime calculation for non-standard voting periodsGabriela Moldovan2026-05-211-3/+25
| | | | | | | | | | | | | | Fixes Arti's SRV lifetime calculation for the case where the voting interval != 1h, and the consensus doesn't have explicit timestamps for the SRVs. Credit goes to dgoulet for this fix! See also [this thread], and #2458 for the broader context. Closes #2522 [this thread]: https://gitlab.torproject.org/tpo/core/arti/-/work_items/2458#note_3401343
* Upgrade rand crates to 0.10.Wesley Aptekar-Cassels2026-05-122-12/+12
| | | | | | | | | | | When the circ-padding feature is enabled, we use maybenot, which does not yet support rand 0.10. In the meantime, enabling this feature pulls in rand 0.9. This is not ideal, but should be okay as a temporary situation. This also replaces the use of ReseedingRng (which was removed in 0.10) with the reseeding_rng crate. This is somewhat less performant, but it should be okay.
* geoip: Make asn data conditional.Nick Mathewson2026-04-151-1/+1
| | | | | | | | | | | | This abolishes the NetDefn type, and turns DenseRangeDb into a map to one or (optionally!) two types. For the DBs we ship, which don't have asn information, this saves about 2.5 MiB. (It also probably saves a bit more, since the niche optimization didn't apply to NetDefn as it existed before, since it tried to distinguish Some(None,None) from None.)
* geoip: Migrate code to DenseRangeMap.Nick Mathewson2026-04-151-1/+1
| | | | | This required correcting some errors in our previous ersatz geoip databases.
* NetDir::pick_relay: add a little more info to error reportsJim Newsome2026-04-021-1/+6
| | | | In particular to help debug arti#1907
* NetDir::pick_relay: add some trace loggingJim Newsome2026-04-021-1/+6
|
* hsdir_params: add debug log when we fall back to disaster paramsJim Newsome2026-04-021-2/+4
|
* tor-netdir: port to web-time-compat.Nick Mathewson2026-03-262-3/+4
|
* Fix grammar typosTobias Stoeckmann2026-03-151-1/+1
|
* Fix word duplicate typosTobias Stoeckmann2026-03-152-3/+3
|
* Merge branch 'flags-url' into 'main'Clara Engler2026-03-121-0/+3
|\ | | | | | | | | tor-netdir: Add spec link to flag descriptions See merge request tpo/core/arti!3768
| * tor-netdir: Add spec link to flag descriptionsIan Jackson2026-03-111-0/+3
| |
* | tor-netdir: Simply exit documentationClara Engler2026-03-091-7/+0
| | | | | | | | No need to over-engineer this, let's keep it simple.
* | tor-netdir: Add is_flagged_exit() to RelayDetailsClara Engler2026-03-051-0/+11
|/ | | | | | | | | | | This commit adds a method called `is_flagged_exit` to `RelayDetails` in order to check whether the node is considered to be usable as an exit or not. In the Tor VPN app, we need this feature for generating a list of exit relays (per country). Right now, we do this in an incorrect way by only checking on whether port 443 is in the exit policy, which is not a sufficient criteria.
* Allow clippy::collapsible_if to triggerGabriela Moldovan2026-02-161-0/+1
| | | | | | | | | `clippy::collapsible_if` started triggering after bumping the MSRV to 1.88. Since this triggers from a lot of places, and since there even are a couple of instances where we explicitly allow `clippy::collapsible_ifs`, I've opened #2342 for deciding what to do about it.
* maint/add_warning: Run script to add new warningGabriela Moldovan2026-01-271-0/+1
| | | | This adds the lint to all our crates.
* Merge branch 'ticket1223' into 'main'Nick Mathewson2025-12-042-1/+74
|\ | | | | | | | | | | | | Refactor common code that builds circtargets for HS. Closes #1223 See merge request tpo/core/arti!3530
| * Refactor common code that builds circtargets for HS.Nick Mathewson2025-12-042-1/+74
| | | | | | | | | | | | | | | | | | This code was duplicated across hsclient and hsservice. Logically, it belongs in netdir, since that's where we have the latest required-protocol information, and the ability to look up relays by IDs. Closes #1223
* | Remove unnecessary `doc(cfg(...))` attributesNeel Chauhan2025-12-042-4/+0
|/ | | | | | | | | Fixes part of #2193. (Edits from nickm: I selected the cases here that I could verify were correct from immediate context.) Edited-by: Nick Mathewson <[email protected]>
* RelayFlags: Use RelayFlag enum variant names everywhereIan Jackson2025-11-183-17/+17
| | | | | | | Abolish the constants with the transitional names. This also abolishes the controversial name `H_S_DIR`, which Rust case transformation rules generated from `HSDir`.
* RelayFlags: Use the singular RelayFlag for naming individual flagsIan Jackson2025-11-183-20/+20
| | | | | | | | | | | | | | We're going to separate RelayFlag from RelayFlags. We could continue to provide a bunch of constant values for RelayFlags, for each individual type, but that would involve an ad-hoc derive, and would still be a bit of an unusual API. Instead, we're going to make ``RelayFlag` a normal enum. In this commit, we change everyone to refer to it by its singular name. Hopefully separating out this bulk change makes both this, and the core commit, easier to review.
* tor-netdoc: Remove the RelayFlags type alias in netstatusIan Jackson2025-11-183-4/+5
| | | | I would do `#[deprecated]` but empirically that has no effect...
* tor-netdoc: Rename RelayFlags elements for regularity vs specIan Jackson2025-11-182-4/+4
| | | | | Add underscores so that the spec keywords and the flag constants correspond (according to `paste`'s case-changing rules).
* Fix name of clippy lint to unchecked_time_subtraction (2)Ian Jackson2025-11-066-7/+7
| | | | Run maint/add_warning
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-26 18:12:29 +0000