| Commit message (Collapse) | Author | Age | Files | Lines |
| | |
|
| | |
|
| |
|
|
| |
Removed unnecessary lint
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This new method modifies a builder by replacing any unset values
that have a default with that default. We're using this method
so that we can re-serialize a builder into a `ConfigurationTree`
with all of its default values included.
In all cases, `b.apply_defaults()?; b.build()` should produce
the same output as `b.build()`.
The interesting parts of this commit are in tor_config::load
and tor_config::derive. The rest of this commit just adds
`apply_defaults` to other builders that _aren't_ made with
`derive_deftly(TorConfig)`.
|
| |
|
|
|
|
|
|
|
|
|
| |
When the circ-padding feature is enabled, we use maybenot, which does
not yet support rand 0.10. In the meantime, enabling this feature pulls
in rand 0.9. This is not ideal, but should be okay as a temporary
situation.
This also replaces the use of ReseedingRng (which was removed in 0.10)
with the reseeding_rng crate. This is somewhat less performant, but it
should be okay.
|
| | |
|
| | |
|
| |
|
|
|
| |
Applies the suggestion from
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3829#note_3388033
|
| |
|
|
| |
As suggested by @Diziet
|
| |
|
|
| |
This is now used by `Account::add_parent()` too.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
I am moving this to another function because we'll soon need to run
these same checks in the new `Account::add_parent()` API I'm planning on
adding for #2427.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
`clippy::collapsible_if` started triggering after bumping the MSRV to
1.88.
Since this triggers from a lot of places, and since there even are a
couple of instances where we explicitly allow `clippy::collapsible_ifs`,
I've opened #2342 for deciding what to do about it.
|
| |
|
|
| |
This will help resolve some dependencies in our graph.
|
| |
|
|
| |
This adds the lint to all our crates.
|
| |
|
|
|
| |
Multiplying 8 * GIB overflows the usize limit (4 GIB - 1) on 32-bit
platforms. So handle this properly for 32-bit platforms
|
| |
|
|
| |
Run maint/add_warning
|
| | |
|
| |
|
|
| |
This feature has been removed from nightly, in favor of doc_cfg.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
The two main causes of errors were:
- Since some of the lifetime rules have changed, we no longer need
to do as many "bind a variable and immediately return it"
patterns, and so clippy now warns about them.
- We needed to adjust the explicit captures (`use<...>`)
in a couple of our RPIT instances.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
All other INFO log lines emitted when arti starts begin with an
uppercase character, so this line looks out of place if it begins with a
lowercase character.
|
| |
|
|
|
| |
A `max` of "auto" (the default) now determines a limit based on the
system's total available memory, rather than acting as "disabled".
|
| |
|
|
|
| |
Note that this contains a breaking change to the `ConfigBuilder`. This
should not break any existing toml configuration files.
|
| | |
|
| |\
| |
| |
| |
| | |
tor-memquota: Replaced MSRV TODO with explanation as to why it is done this way
See merge request tpo/core/arti!3067
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
- The TODO regarding replacing usage of qualified names with a generic
NonZero<T> has been replaced with a link to an issue requesting clearer
documentation for NonZero as to how this cannot be done, due to the perma-
unstable type bound on T.
Signed-off-by: hashcatHitman <[email protected]>
|
| | |
| |
| |
| | |
Made with https://crates.io/crates/typos-cli
|
| |/
|
|
| |
See #2060.
|
| | |
|
| |
|
|
|
| |
- Part of a series of commits aimed at replacing all MSRV-related TODOs with a
standardized format, which should be easier to find when the MSRV is bumped.
|
| |
|
|
| |
- The Rng::gen() functions have been renamed to Rng::random().
|
| |
|
|
|
| |
This took a little refactoring, since derive_more::Foo
no longer re-exports std::ops::Foo.
|
| |\
| |
| |
| |
| | |
clippy: deny `mod_module_files`
See merge request tpo/core/arti!2689
|
| | |
| |
| |
| |
| |
| | |
Denies 'mod.rs' files for consistency.
https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
|
| |/ |
|
| |
|
|
|
|
|
|
| |
In 1.83, this warning triggers on many of our crates.
We're thinking of fixing them all, but for now,
we're going to disable the warning.
This is part of #1765.
|
| |\
| |
| |
| |
| | |
memquota: Fix account lifetime bugs, and arrange to test mq in shadow
See merge request tpo/core/arti!2560
|
| | |
| |
| |
| |
| | |
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2560#note_3097189
|
| | |
| |
| |
| |
| | |
These errors aren't necessarily memory pressure. They can occur due
to bugs, and during teardown.
|
| | |
| |
| |
| |
| | |
This detects the bugs I have just fixed - in Shadow tests with the
feature enabled and a (large) limit set.
|
| | | |
|