| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
|
| | |
|
| |
|
|
| |
in event_report!
|
| |
|
|
| |
Run maint/add_warning
|
| |
|
|
|
|
|
|
|
|
| |
This is useful when you create an `internal!` error and then immediately
report it. If the `_report!` macro also requires a message, then you
need to provide two messages for the error, which doesn't always make
sense.
This is already possible anyways with `warn_report!(e,)`.
Now you don't need the comma.
|
| |
|
|
|
|
|
|
|
|
| |
This requires that we put the error in a field. There are two issues
that we'll fix in the next two commits:
1. Errors are no longer formatted with `ErrorReport`.
2. Errors will be in the first field, but long (or multiline) error
messages will cause other fields to be pushed to the end where
they're harder to find.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Tbis will result in "some message ...: the error" which I think is OK.
We don't use a Unicode single-character ellipsis because that
character can be hard to read at font sizes which are otherwise OK for
text, and because use of non-ascii in logfiles and error messages is
unecessary and might cause unnecessary trouble (for example, if the
log messages end up going somewhere which isn't 100% valid UTF-8).
|
| |
|
|
|
| |
Possibly at some point in the past, matching a slice directly wasn't
possible. But it is now.
|
| |
|
|
|
|
|
|
|
| |
Originally they didn't check err.kind(), since err.kind() can never
increase their severity. We lost that behavior with !1386, and we
became dependent on it with arti!1383. Since they both merged at
the same time, CI broke.
This patch restores their original behavior.
|
| |
|
|
|
|
|
|
|
|
| |
This abolishes some quintuplication.
The output is identical except that:
* The syntax display in the rustdoc output for the resulting macros
seems to have somewhat less whitepsace.
* The whimsical error messages in the examples are all identical.
Ah well.
|
| | |
|
| |
|
|
|
| |
(Also, document that this static assertion is the reason why you are
seeing a confusing error message.)
|
|
|
The main contribution here is a set of convenience macros for
logging error `Report`s. Notably, this macros always logs
`Internal` and `BadAspiUsage` errors at `WARN`, unless they
are already at `ERROR` or more.
This is a little tricky because `tracing::event!()` requires
its Level argument to be a constant.
|
