| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
| |
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
|
| |
|
|
|
| |
There's no reason that the next person should have to rediscover
these caveats.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Duration::try_from_secs_f64 has existed since Rust 1.66,
so we can use it now.
It seems wrong to treat "infinity" and "negative infinity" as "one
second", so make them actually saturating.
Additionally, document behavior for infinity and negative infinity,
and document that the NaN behavior isn't documented.
(And secretly NaN behavior return a number on the same order of
magnitude as the input.)
|
| |
|
|
|
| |
This strategy is safe because (outside of our tests) we never look
at the actual values of timeout_scale, but only at their ratios.
|
| | |
|
| |
|
|
| |
Run maint/add_warning
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
This will help create good timeout values for various onion-service
operations.
|
| |
|
|
|
| |
This panics on error, and we're fine with a panic on misbehavior in
tests.
|
| |
|
|
|
| |
This is precisely the result of running the rune in
maint/adhoc-add-lint-blocks.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Previously we used Duration::mul_f64, which panics if its output is
out-of-range. That shouldn't actually be possible for the values
we're giving it, but probably it's better to just multiply in a safe
way.
This resolves a couple of XXXXs and therefore relates to #231.
|
| |
|
|
|
|
|
|
| |
We want to only use TODO in the codebase for non-blockers, and open
tickets for anything that is a bigger blocker than a TODO. These
XXXXs seem like definite non-blockers to me.
Part of arti#231.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
This is a big change, but it does simplify the type of Builder a
little, and isolates locking across different (potential) timeout
estimator types.
|
|
|
This will cause some pain for now, but now is really the best time
to do this kind of thing.
|