| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
Now that these test more than just the help output, we need to gate them
behind the `onion-service-service` feature: the tests involve some C Tor
keystores, and require at least one onion service to be configured,
because onion services (and clients) are the only thing these keystores
are used for.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now have `trycmd` tests that cover most cases, so I am removing this
module. The reason this was introduced in the first place is in the
module level docs
```rust
//! The `assert_cmd` crate is used here instead of the preferred `trycmd` (see
//! [`README`](../README.md)) because the output of `keys list` is not deterministic across
//! different machines. The design choices of some components are workarounds for this limitation.
```
But this is no longer an issue now that the `keys list` output is
sorted.
Ideally, all tests would be written this way (we have a few more modules
in `cli_tests` that we should probably port to `trycmd` sometime).
Note: some of the tests I'm removing here don't have a `trycmd`
counterpart in `arti/tests/testcases/keys`. In my opinion, this is
perfectly fine, because the old tests were unnecessarily testing all the
possible configurations involving 1-2 keystores (one arti, and one C
Tor): it is not the responsibility of the CLI tests to cover all these
permutations (they should be tested in `tor-keymgr`).
|
| |
|
|
|
|
| |
It's better to use "TODO" like we do in the rest of Arti, because
otherwise this has a chance of being forgotten (because nobody really
greps for "IDEA").
|
| | |
|
| |
|
|
|
| |
- Add regression test
- Update README
|
| |
|
|
| |
This changes save us from adding a new entry in .editorconfig
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Typos found with codespell
|
| | |
|
| |
|
|
|
|
| |
- remove build_hsc_key_cmd in favor of KeyCmd
- use KeyCmdBuilder in CTorMigrateCmd::keystore_contains_client_key to remove duplication
- adapt hsc.rs to the changes
|
| | |
|
| | |
|
| |
|
|
| |
For readability.
|
| | |
|
| | |
|
| |
|
|
|
| |
The previous name was misleading (the closure asserts the exact
opposite).
|
| | |
|
| |
|
|
|
| |
C Tor keystore entries now use the same output format as the non-C Tor
entries.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
```text
warning: use of deprecated associated function `assert_cmd::Command::cargo_bin`: incompatible with a custom cargo build-dir, see instead `cargo::cargo_bin_cmd!`
--> crates/arti/tests/cli_tests/hsc.rs:26:28
|
26 | let mut cmd = Command::cargo_bin("arti").unwrap();
| ^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
```
|
| | |
|
| |
|
|
| |
The `keys` integration test now accounts for case-insensitive filesystems
|
| |\
| |
| |
| |
| | |
arti: Simplify the `create_state_dir_entry` test helper
See merge request tpo/core/arti!3178
|
| | | |
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before:
```text
INFO tor_hsservice: Generated a new identity for service bar: ???mad.onion
```
After:
```text
INFO tor_hsservice: Generated a new identity for service foo: […]2qd.onion
```
|
| | |
|
| |
|
|
|
|
|
|
|
| |
- Add `cli_tests/keys/util.rs` and `cli_tests/keys.rs`
- Update `cli_tests/main.rs` and
`testcases/keys/conf/keys.toml`
- Add `ctor-keystore` directory to `keys` `local` directory
- Restructure `keys` `local` directory layout
- .editorconfig: Add exception for `ctor-keystore`s
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* CLI: Add `keys-raw` and subcommand `remove-by-path`
* arti: Add `arti::subcommand::raw` for the CLI `keys-raw`
* tor-keymgr: Add `ArtiNativeKeystoreError::UnexpectedRawEntry`,
`ArtiEphemeralKeystoreError::NotSupported`
* tor-keymgr: Add `tor-keymgr::raw` module
* tor-keymgr: Add `Keystore::remove_unchecked`
* tor-keymgr: Change `Keystore::list` to return `KeystoreEntry`
* tor-keymgr: Add field `KeystoreEntry::raw_id`
* doc: Update keys.md
* doc: Add raw.md
* tor-keymgr: BREAKING: `UnrecognizedEntryError::new` associated
function is now only accessible within the crate `tor-keymgr`
* tor-keymgr: BREAKING: `UnrecognizedEntryId` is renamed to
`UnrecognizedEntry`
* tor-keymgr: BREAKING: `KeyMgr::list()` and `Keystore::list()`
now return `Result<Vec<KeystoreEntryResult<KeystoreEntry>>>`
|
| | |
|
|
|
* arti: test: Restructure tests directory
* arti: dep: Add assert_cmd dev-dependency
* arti: test: Update README
* doc: Fix hsc documentation
|