| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
| |
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
|
| |
|
|
| |
Run maint/add_warning
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
|
| |
|
|
|
|
|
| |
In general, we try to obey the convention that an error's Display
method does not display that error's sources.
Part of #1650.
|
| |
|
|
|
|
|
|
|
|
|
| |
The execute_internal_ok method converts every error response into an
internal error; as such, it's only appropriate when there is no way
for a well-behaved Arti instance to give an error response.
But we had been using it in a few places where errors were possible
under other circumstances.
This commit fixes that behavior, and adds documentation to help
avoid it.
|
| |
|
|
|
|
|
|
| |
Our now convention here in rpclib is that a struct holding a
request's parameters is called `FooParams`, and a struct holding
that request's reply is called `FooReply`.
Closes #1586
|
| |\
| |
| |
| |
| | |
rpclib: Clean up after performing cookie auth
See merge request tpo/core/arti!2716
|
| | |
| |
| |
| |
| |
| | |
Previously we never released the intermediary cookie-auth object,
which would have left it kicking around on the RPC server side
until we finally closed our connection.
|
| |/
|
|
|
|
|
|
| |
This method doesn't actually create a new stream; it creates a
single-use client object that can be used with SOCKS to launch
a new stream, and capture an RPC object for that stream.
Closes #1664.
|
| |
|
|
|
|
|
| |
Now, instead of telling the session or the connection to drop the
object ID, we tell the object ID to go away.
Closes #1663.
|
| | |
|
| |
|
|
|
|
|
| |
Now that the proposal is implemented and merged into the specs,
the proposal itself is only historical.
Closes #1629.
|
| |\
| |
| |
| |
| |
| |
| | |
rpclib: Unify code for internally generated requests
Closes #1587
See merge request tpo/core/arti!2456
|
| | |
| |
| |
| |
| |
| |
| |
| | |
We now have a single type to represent the error
"A request that we made internally didn't get a result we expected."
The functions to generate these requests are now centralized too.
Closes #1587.
|
| | |
| |
| |
| |
| |
| |
| | |
This restores the functionality of
socks users: detect closed sockets.
0c595818f713916d94b7b0e4062f953fad7c9799
which we reverted as part of rebasing this branch onto main.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This deduplicates some docs and eliminates the two wrapper functiosn
for `run_handshake`, which is now just `handshake`.
We're going to make other API breaks too, and this isn't going to be
the primary API, so we might as well do this.
Proper description of the semver breakage will come at the end when
it's all done.
|
| | |
| |
| |
| | |
This reverts commit 0c595818f713916d94b7b0e4062f953fad7c9799.
|
| | |
| |
| |
| | |
This reverts commit 8da8b88481c26d49ac96e79165538e01237ec9ed.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
When doing the client handshake, we need to read data _after_ we
check for stuff to send, since the client speaks first in the socks
protocol.
Without this patch, the socks handshake just stalls.
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
socks users: detect closed sockets. (TROVE-2024-011)
Closes #1635
See merge request tpo/core/arti!2447
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Without this check, our socks code can enter an infinite loop
if a socket is closed at the wrong time.
Resolves TROVE-2024-011.
Fixes #1635.
|
| |\ \ \
| |/ /
|/| /
| |/
| |
| |
| | |
rpc: Rename SingletonId to SingleIdResponse
Closes #1585
See merge request tpo/core/arti!2448
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Calling it "singleton" might have suggested that it was using the
[singleton pattern](https://en.wikipedia.org/wiki/Singleton_pattern),
which it isn't.
(Renaming done with rust-analyzer and double-checked with `git grep`.)
Closes #1585.
|
| |/
|
|
|
|
|
|
|
|
|
| |
Now that prop351 is what Arti speaks, it's what the rpclib
needs to provide.
Note one change in particular: the `isolation` string
is no longer an optional argument when opening a stream.
(With prop351, there is no longer such a thing as an "absent"
isolation string, and we don't want to imply that there is a
difference between None and "".)
|
| |
|
|
|
| |
AFIACT, all of this renaming is done. I've grepped for `[Cc]onn`
and didn't find any more identifiers that needed to be renamed.
|
| | |
|
|
|
(This is about DataStreams, so we should make it less confusing.
This commit is _just_ about the file renaming, with no associated
function renaming.)
|
