| Commit message (Collapse) | Author | Age | Files | Lines |
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Removed unnecessary lint
Closes #2556
See merge request tpo/core/arti!4210
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
Removed unnecessary lint
|
| | | |
|
| |/ |
|
| | |
|
| |\
| |
| |
| |
| | |
Fix string_slice exceptions outside of netdoc
See merge request tpo/core/arti!4092
|
| | | |
|
| |/ |
|
| |
|
|
|
|
|
|
| |
This commit adds #[allow(clippy::string_slice)] to all functions in the
code where string slices are used, alongside a TODO comment.
We do this add the function header to have it consistent, as things like
expression based allow's are still experimental.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
|
| | |
|
| |
|
|
|
| |
If we have made bootstrapping manual, and not launched a bootstrap,
we now reflect this as the reason that bootstrapping is blocked.
|
| | |
|
| |
|
| |
Co-authored-by: gabi-250 <[email protected]>
|
| |
|
|
|
|
| |
Otherwise we either lose the property that you can call
launch_onion_service before bootstrapping has begun,
or we have to make launch_onion_service async.
|
| |
|
|
|
| |
(This is a separate commit in order make the code movement in the
previous commit clearer.)
|
| |
|
|
|
| |
This will ensure that the TorClient takes its file locks immediately
on construction.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
This will let us be more confident in the inertness of a
not-bootstrapping TorClient, _and_ make it easier to reconfigure
things before the client is started.
|
| |
|
|
|
| |
Now that we have a type called "inner", and will soon have a
function to create it, we really don't want to retain this name.
|
| |
|
|
|
| |
We want this look to cover the whole function, to avoid weird
duplicate behavior while creating our bridge desc manager.
|
| |
|
|
|
|
| |
We'll use this to distinguish "not running" from "running",
in order to make it easier to be sure that non-bootstrapping clients
will definitely not try to connect to the network.
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
Previously the [channel] outbound_proxy setting was applied to Arti's
own direct connections but was not forwarded to managed PT processes.
https://spec.torproject.org/pt-spec/configuration-environment.html
|
| |
|
|
|
|
|
|
| |
Discussion on #1960 suggests that this option is not a good idea:
it encourages developers to work around deliberate signals that the
software they're shipping won't work on the network.
Closes #1960.
|
| | |
|
| | |
|
| |
|
|
| |
These were only Arc<> so that TorClient could implement Clone.
|
| |
|
|
|
|
|
|
|
| |
The `set_stream_prefs` method was the only one that took a TorClient
as `&mut self`. But we only expose Arc<TorClient<R>>, that isn't a
reasonable API.
The `clone_with_prefs` method has been renamed, since it no longer
"clones" anything meaningfully.
|
| | |
|
| |
|
|
|
|
| |
This is part of rationalizing the structure of TorClient so we can
refactor startup logic, and so that RPC code can reason about object
identity. See #2469.
|
| | |
|
| | |
|
| |
|
|
| |
As per the release checklist.
|
| | |
|
| |
|
|
|
|
|
|
| |
The replacement (TestingStateMgr) is not correct, but it will
compile until we have a supported state manager.
(This made cargo-sort have me move a section around. Not sure why it
cares.)
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
(There are a few places where we still do things in nonstandard
places to avoid API breakage.)
|
| |\
| |
| |
| |
| |
| |
| | |
Use ErrorSources where appropriate to walk an error stack.
Closes #2338
See merge request tpo/core/arti!3685
|
| | |
| |
| |
| |
| | |
Previously, due to #2338, we would miss any error nested directly
inside an io::Error.
|
| |/
|
|
|
|
|
|
|
| |
`clippy::collapsible_if` started triggering after bumping the MSRV to
1.88.
Since this triggers from a lot of places, and since there even are a
couple of instances where we explicitly allow `clippy::collapsible_ifs`,
I've opened #2342 for deciding what to do about it.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This requires the `TlsKeyAndCert` so be passed on the TLS acceptor
settings. We assume that `RelayIdentities` has this information.
The ChanBuilder::new() was getting a bit too convoluted and feature
gated to instead we introduce new_client() and new_relay() and remove
the need for `with_identities()`.
Because of this, the ChanMgr::new() now returns a `Result<>`.
Related to #1597
Signed-off-by: David Goulet <[email protected]>
|
| | |
|