summaryrefslogtreecommitdiff
path: root/tor-proto/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Use an enum for the return value of StreamMap::terminateNick Mathewson2020-10-222-8/+25
|
* Initial tests for tor_proto::circuit::streammapNick Mathewson2020-10-221-0/+51
|
* Tests for tor_proto::circuit::halfstreamNick Mathewson2020-10-221-1/+79
|
* tor-proto: Add tests for circuit::sendmeNick Mathewson2020-10-221-4/+134
|
* Add tests for tor_proto::circuit::celltypesNick Mathewson2020-10-211-0/+43
|
* Test a trivial succeeding case of link cert validationNick Mathewson2020-10-211-12/+72
|
* Fix a security issue (!) in link handshake validation.Nick Mathewson2020-10-211-1/+1
| | | | | | | | When making sure that the peer had the right RSA identity, we were comparing the RSA identity with itself, not with the RSA identity we expected. Found via unit testing (!).
* Infrastructure for testing handshake cert-validation codeNick Mathewson2020-10-211-1/+61
|
* More tests for handshake connect functionNick Mathewson2020-10-211-26/+136
|
* Start a basic test for the first part of the handshake.Nick Mathewson2020-10-211-0/+45
|
* LogId test: tolerate concurrent tests.Nick Mathewson2020-10-211-11/+8
|
* Start on some tests for pieces of tor-proto::channelNick Mathewson2020-10-213-0/+224
|
* Follow API convention about mutable getters.Nick Mathewson2020-10-212-8/+8
| | | | They're supposed to be called field_mut().
* Rename as_message to into_message.Nick Mathewson2020-10-211-1/+1
| | | | | According to the API guidelines, "as_" is only for borrowed->borrowed conversions.
* Add a close() method for streamsNick Mathewson2020-10-201-0/+8
|
* Add new `terminate()` method to circuits and channels.Nick Mathewson2020-10-202-6/+44
| | | | | | | | These aren't called "close" because they're more destructive than that: they can be called even if other parties are using the circuit or channel. This is for arti#21.
* Missing file and docsNick Mathewson2020-10-203-6/+45
|
* Add a TODO for register_meta_handler APINick Mathewson2020-10-201-0/+3
|
* Work on closing flooding-based side-channelsNick Mathewson2020-10-202-17/+28
| | | | | We need to make sure that we're dropping cells that we don't recognize or want, so that we can't be flooded with bogus junk.
* Add some helpful logs in circuit code.Nick Mathewson2020-10-204-15/+100
|
* Add reasonable logging (I hope!) to channelNick Mathewson2020-10-204-42/+219
|
* Implement From, not Into.Nick Mathewson2020-10-191-6/+6
| | | | | These traits are inverses of one another, but implementing From is always preferred since rust 1.41 relaxed the "orphan rules".
* Add and use remaining CertType values in tor-certNick Mathewson2020-10-191-2/+2
|
* Add an enumeration for destroy reasons.Nick Mathewson2020-10-191-3/+2
|
* Improvements to Relay type in tor-netdir.Nick Mathewson2020-10-191-1/+1
| | | | | | | | | | | Now, a Relay is always valid. This required some changes to the API: all_relays() has to return a new UncheckedRelay type that might or might not be valid, and the functions on Relay and ChanTarget that return ed25519 identities need to return an Ed25519Identity, not an ed25519::PublicKey. This change required some new encoding/decoding/conversion functions on Ed25519Identity.
* Mark must-resolve XXXX issues with "XXXXM3".Nick Mathewson2020-10-188-34/+30
| | | | | | | | | | "M3" is for "milestone 3" -- my target to fix the technical debt that I think will be bad if we ship even a pre-alpha with it. These aren't necessarily _all_ must-resolve, but they're all must-look-at. Closes #15
* tor-proto: Add a ClientCircChanMsg type.Nick Mathewson2020-10-155-22/+43
| | | | | | This wraps exactly the ChanMsg values that are valid on open client circuits, so that we can be sure that only those cells are sent to a ClientCirc's reactor.
* tor-proto: Add a "CreateResponse" type.Nick Mathewson2020-10-155-15/+64
| | | | | | CreateResponse includes exactly those cells that are a correct response to a CREATE2/CREATE_FAST, so we can be sure that only those cells are actually passed to a PendingClientCirc.
* Fix a couple of clippy warningsNick Mathewson2020-10-152-2/+2
|
* Turn the channel's ref to its circmap into a Weak referenceNick Mathewson2020-10-151-6/+11
| | | | | This way, when the channel reactor is dropped, the circuit map can get dropped too, which will cause reading circuits to notice.
* Mark channels as unusable if reactor gets an error.Nick Mathewson2020-10-153-1/+31
| | | | | Similarly as with circuits, we want this code to set a "closed" flag so that attempts to write on the channel will fail.
* Use weak references from circuit reactor to circimpl.Nick Mathewson2020-10-142-15/+30
| | | | This prevents the reactor from keeping the circuit alive forever.
* Use a weak reference from channel reactor to channel.Nick Mathewson2020-10-141-5/+7
|
* Send DESTROY cells when a circuit is dropped.Nick Mathewson2020-10-143-27/+161
| | | | | | | | | This reuses a lot of mechanism from the circuit code that sends END cells when streams are dropped. There is a problem here: Circuits and channels won't actually get dropped, because we should be using a weak reference from the reactor.
* Revise DropMark defense to use a better type and match Tor's behavior.Nick Mathewson2020-10-135-12/+97
|
* Document all private members in tor-protoNick Mathewson2020-10-1314-7/+131
|
* Make sure that protocol errors terminate the circuit responsible.Nick Mathewson2020-10-132-20/+55
|
* Improve handling of circuit closure or failure on reactor shutdown.Nick Mathewson2020-10-132-4/+35
| | | | | | | | | | We already handled the case okay when we were reading on streams, since the reactor's going away would drop the sender side of their mpsc channels. But if the reactor went away, nothing would tell _writing_ streams that they needed to close. Now we handle that case, as well as anybody who is waiting on a meta-cell to get back to them.
* Another tweak to handling closing streamsNick Mathewson2020-10-133-14/+40
| | | | | | When a stream is closed and we haven't adjusted its state in the stream map yet, remember how many cells we've dropped so we can decrement them from the window later on.
* Try giving distinct handling to streams where END has been sentNick Mathewson2020-10-125-51/+114
| | | | | | This is the first step along the line to handling Tor issue tor#27557. We want to remember streams that we've ended and treat them as distinct from streams that have never existed
* Tweak terminate hand handle_close() functions.Nick Mathewson2020-10-112-13/+20
| | | | | These need to become functions about terminating and noticing a termination request.
* Rename StreamMap::Closing to EndReceivedNick Mathewson2020-10-111-4/+4
| | | | This is in preparation for adding a different EndSent stream state.
* Fix a pair of bugs in SENDME handling.Nick Mathewson2020-10-091-13/+10
| | | | | | | | | The problem is that we would count begin and end cells towards towards window totals when we are only supposed to count DATA cells, *and* that we would we send our sendmes one cell too early (or maybe late?). Closes #1.
* Move counts_towards_windows() code into circuit moduleNick Mathewson2020-10-094-4/+19
|
* Split information about circuit hops into inbound and outbound.Nick Mathewson2020-10-092-61/+172
| | | | | | | | | | | | | | | | | | Previously the circuit object owned not only the outbound crypto, but also the inbound crypto and the stream maps. That's not so great, since the reactor needs to use the inbound crypto and the stream maps all the time, whereas the circuit doesn't need them much (or at all). Moving these objects to the reactor-owned structure should let us fix the deadlock case in stream sendme handling, since the circuit reactor no longer needs to lock the circuit in order to do crypto and demultiplexing. It should also speed up the code a bit, since it doesn't need to grab the circuit lock nearly so often as before. This change forced me to add a couple of new reactor CtrlMsg values, since the circuit can no longer add streams and layers directly. I think it will still be a performance win, though.
* Split client relay crypto into separate directionsNick Mathewson2020-10-093-77/+179
| | | | | I think we should have the reactor task own the reverse crypto and the circuit own the forward crypto.
* Use batch verification in client<->relay handshake.Nick Mathewson2020-10-021-7/+19
|
* Enable batch ed25519 verification.Nick Mathewson2020-10-021-0/+1
|
* Move RelayCell into a more reasonable place.Nick Mathewson2020-09-292-4/+4
|
* Remove idmap as needlessly complex.Nick Mathewson2020-09-294-52/+39
|