summaryrefslogtreecommitdiff
path: root/maint
Commit message (Collapse)AuthorAgeFilesLines
* Update `rsa` dependency (and use `x25519-dalek` prerelease)eta2022-07-061-1/+1
| | | | | | | | | | | | | | - arti#448 and arti!607 highlight an issue with upgrading `rsa`: namely, the `x25519-dalek` version previously used has a hard dependency on `zeroize` 1.3, which creates a dependency conflict. - However, `x25519-dalek` version `2.0.0-pre.1` relaxes this dependency. Reviewing the changelogs, it doesn't look like that version is substantially different from the current one at all, so it should be safe to use despite the "prerelease" tag. - The new `x25519-dalek` version also bumps `rand_core`, which means we don't have to use the RNG compat wrapper in `tor-llcrypto` as much. closes arti#448
* maint/add_warning: Fix parsing of --checkIan Jackson2022-06-241-1/+1
| | | | Previously this would eat the first filename!
* clippy: Consolidate many lints in maint/add_warningIan Jackson2022-06-241-0/+3
| | | | | | Found these by disabling the nightly dbg macro special case. Now, we have a mechanism for globally adding suppressions to tests, we can use that instead.
* maint/add_warning: Add two lints via add_warning as a test caseIan Jackson2022-06-241-0/+2
|
* maint/add_warning: Add ability maintain test lint blocksIan Jackson2022-06-241-8/+34
|
* maint/add_warning: Scan all files by default, but insist only in someIan Jackson2022-06-241-9/+16
| | | | | | | This will allow us to have add_warning manage test lint blocks. We have to stop printing all the filenames because there are too many. Filenames still come out on error of course.
* clippy: Supresss clippy::significant_drop_in_scrutineeIan Jackson2022-06-231-0/+1
| | | | As per the linked discussion.
* lints: Scheme for allowing us to name nightly lintsIan Jackson2022-06-231-1/+3
| | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/issues/501
* Avoid matching crate names by prefix.Nick Mathewson2022-06-171-1/+5
|
* Update check_tree to better detect errors in cargo-tree.Nick Mathewson2022-06-161-6/+26
|
* Add script and CI to make sure `ring` doesn't show up in arti/fullNick Mathewson2022-06-161-0/+24
| | | | See arti#493.
* CI: Break out maint/via-cargo-installIan Jackson2022-06-081-0/+10
|
* maint/cargo_sort: Tolerate toplevel Cargo.toml not being sortedIan Jackson2022-06-081-2/+25
|
* maint/toposort: Make shebang be python3, not pythonIan Jackson2022-06-081-1/+1
| | | | | Otherwise it doesn't work on sane systems where /usr/bin/python is never an incompatible version from previously.
* Merge branch 'check-license-fixes' into 'main'Ian Jackson2022-06-021-1/+17
|\ | | | | | | | | | | | | Update check_licenses and add it to CI. Closes #462 See merge request tpo/core/arti!559
| * check_licenses: list new crates with manual license verificationNick Mathewson2022-05-311-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #462. Note that the license on `ring` is slightly problematic for some users, including as it does old the openssl license[^1], with advertising clause and all. That's not a blocker for us now, since `ring` is not a required dependency. But we wouldn't want `ring` to become a mandatory dependency because of this. [^1]: To make the situation even more complicated, modern openssl has relicensed under apache-2.0, but that doesn't necessarily help us, since ring took its code from boringssll, which forked from an older version of openssl.
* | maint/add_warning: Convert remaining assertsIan Jackson2022-05-311-4/+8
| |
* | maint/add_warning: Introduce ImproperFile and convert one assertIan Jackson2022-05-311-2/+18
| |
* | maint/add_warning: Use python3 argparseIan Jackson2022-05-311-11/+9
| |
* | maint/add_warning: Add "how to fix" to error messageIan Jackson2022-05-311-0/+1
| | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/557#note_2808879
* | maint/add_warning: Provide --check modeIan Jackson2022-05-311-2/+22
| |
* | maint/add_warning: Change shebang to python3Ian Jackson2022-05-311-1/+1
| | | | | | | | "python" sometimes means Python 2.
* | maint/add_warning: Use .tmp~ for temp filename, not .bakIan Jackson2022-05-311-3/+3
| | | | | | | | | | "bak" ought to be a backup file, with the old contents, which this most definitely isn't.
* | lints: Add let_unit_value allow to add_warningIan Jackson2022-05-311-0/+1
| | | | | | | | | | add_warning can now add allows. This one was agreed in some other MR for one crate. Allow it everywhere.
* | lints: Add two missing ones to add_warningIan Jackson2022-05-311-0/+2
| | | | | | | | | | These were in some crates, but not all. Put them in add_warning where they will propagate everywhere.
* | lints: maint/add_warning: New marker-based modeIan Jackson2022-05-311-35/+21
| | | | | | | | | | | | | | | | We don't process the in-script lint block, just paste it in, now. This is less complicated. This reverts/replaces "maint/add_warnings: Make it add the markers for its future self"
* | maint/add_warnings: Make it add the markers for its future selfIan Jackson2022-05-311-0/+6
| | | | | | | | We'll run this in a moment. Then we'll revert it.
* | lints: maint/add_warning: Improve orderingIan Jackson2022-05-311-1/+1
| | | | | | | | | | The crates we have aren't consistent. But changing this means the deltas resulting from the script are smaller.
* | maint/add_warnings: Tidy up, and add some commentaryIan Jackson2022-05-311-2/+7
|/ | | | | | This puts the actually-used lint list at the top. No functional change.
* Lexically sort Cargo.toml dependenciesOrhun Parmaksız2022-05-281-0/+7
| | | | | | Utilize cargo-sort: https://github.com/DevinR528/cargo-sort Signed-off-by: Orhun Parmaksız <[email protected]>
* Fix "coverage -h" commandSteven Murdoch2022-05-261-1/+1
| | | | $SCRIPT_NAME is not defined so causes an error. Use $(basename "$0") instead.
* fix docker_reproducible_build not passing its parameters properlytrinity-1686a2022-05-261-1/+1
|
* update comments in coverage_fuzz_corporatrinity-1686a2022-05-251-25/+15
|
* make almost all scripts use bash and set euo pipefailtrinity-1686a2022-05-2514-23/+33
|
* Remove cargo-husky, and replace with manual instructionseta2022-05-103-1/+28
| | | | | | | | A build script reaching into your .git/hooks/ and modifying them nonconsensually was a bit of a horrifying concept, and also made it hard to build arti with the feature disabled. Remove this crate, and replace it with manual instructions on how to install the hooks in CONTRIBUTING.md.
* use true instead of /bin/truetrinity-1686a2022-05-051-2/+2
| | | | see https://gitlab.torproject.org/tpo/core/arti/-/issues/400#note_2800763
* generate aggregated coverage reportstrinity-1686a2022-05-051-13/+19
|
* Merge branch 'explain_downgrade' into 'main'eta2022-05-031-0/+6
|\ | | | | | | | | Add a comment explaining what downgrade_dependencies is for. See merge request tpo/core/arti!480
| * Add a comment explaining what downgrade_dependencies is for.Nick Mathewson2022-04-281-0/+6
| |
* | remove some unecessary crates from downgrade_dependenciestrinity-1686a2022-04-281-3/+1
| | | | | | | | | | nix:0.4.2 is no longer a dependency synstructure:0.12.0 is no longer required to build
* | update tls-api to 0.8.0trinity-1686a2022-04-281-4/+4
| | | | | | | | and remove corresponding RUSTSEC from ignored list
* | downgrade_dependencies: Remove "quote" exception.Nick Mathewson2022-04-261-1/+0
|/ | | | This is no longer necessary. :)
* Use git source for derive_builder for now, for sub_builder featureIan Jackson2022-04-211-1/+0
| | | | | | | | | | | | | | | This commitid is the current head of my MR branch https://github.com/colin-kiegel/rust-derive-builder/pull/253 https://github.com/ijackson/rust-derive-builder/tree/field-builder Using the commitid prevents surprises if that branch is updated. We will require this newer version of derive_builder. The version will need to be bumped again later, assuming the upstream MR is merged and upstream do a release containing the needed changes. We will need the new version of not only `derive_builder_core` (the main macro implementation) but also`derive_builder` for a new error type.
* Fix typosDimitris Apostolou2022-04-111-3/+3
|
* Merge branch 'cargo-audit' into 'main'Nick Mathewson2022-04-081-0/+11
|\ | | | | | | | | fix maint/cargo_audit not propagating error and add temporary exceptions See merge request tpo/core/arti!452
| * fix maint/cargo_audit not propagating error and add temporary exceptionstrinity-1686a2022-04-081-0/+11
| |
* | use default toolchain from rustup instead of stable for coveragetrinity-1686a2022-04-081-1/+2
| | | | | | | | using stable doesn't work for CI because a specific version like 1.60 is installed
* | bring back RUST_COVERAGE_TOOLCHAINtrinity-1686a2022-04-081-2/+8
| |
* | use rustc 1.60 (stable) for coveragetrinity-1686a2022-04-072-12/+5
|/
* fix with_coverage script to exclude pub(crate) mod test from resultstrinity-1686a2022-03-241-1/+1
|