| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| |
|
|
|
|
|
|
|
|
|
|
| |
Rationale: no-one writes these by default without thinkinh. If they
are unnecessary, then either the string must have had " in it
before (in which case it might do again), or it is near other strings
which *do* need it.
And having it does no harm; indeed IMO it can increase clarity.
Alternative to !1388's
Fix new "needless_raw_string_hashes" lint from clippy +nightly
|
| |\
| |
| |
| |
| |
| |
| | |
add_warning: Tolerate clippy::missing_panics_doc
Closes #950
See merge request tpo/core/arti!1380
|
| | |
| |
| |
| |
| |
| |
| | |
As of current nightly, this lint now includes expect()s,
which makes it trigger way more than we'd like.
See discussion on #950.
|
| |/
|
|
|
|
|
| |
Clippy nightly doesn't like `#[cfg(all(...))]` with only a single
expression inside the `all(...)`.
This requires an adjustment in check_doc_features.
|
| |
|
|
|
|
|
|
| |
Now with cargo semver-checks >= 0.22.1, we no longer need to
jump through hoops in order to only look at the `full` features.
This, combined with our work on `fixup-features`, lets us be
confident that we're only looking at semver breakage in experimental
code.
|
| |
|
|
|
|
|
|
| |
These are available in our MSRV now, so we don't need to handle
specially. We can just add them to the standard lint block.
(Lint block in every crate will be updated automatically in the next
commit.)
|
| | |
|
| |
|
|
| |
Signed-off-by: Gabriela Moldovan <[email protected]>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The options are rather complicated; because we do not want to
subject our experimental features to semver, we need to run generate
JSON rustdoc on our own and then pass that JSON to
cargo-semver-checks. This in turn requires us to use the same
options that cargo-semver-checks uses, including "RUSTC_BOOTSTRAP".
I've left some TODOs here in places where we will likely want to
improve our code in the future.
See #711.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we allowed this license unconditionally. But because of its
non-self-enacting nature, we need the actual notice from its "exhibit A"
to appear somewhere that says that it applies to all the relevant code.
Therefore, we shouldn't take new MPL-2.0 dependencies without
hand-checking them. (I am tentatively allowing option-ext, though,
since we already have an indirect dependency on that crate via
`directories`.)
For more info, see https://gitlab.torproject.org/tpo/core/arti/-/issues/845
|
| | |
|
| | |
|
| |
|
|
|
| |
Okay, technically we're removing everything between the first `<` and
the `>` at the end of the line.
|
| |
|
|
|
|
|
|
| |
When building our list of acknowledgments, previously we would only
include author and committer names.
Now we also include anybody listed in the "Reported-by",
"Co-authored-by", and "Thanks" trailers.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
An external edge does not cause its target to be created as a feature.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
I tried to use petgraph, but it was optimized for performance over
usability, and the usability was beyond me.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
The problem with our old rules is that "reachable from __nonadditive"
and "reachable from experimental" were not themselves sensible
definitions of nonadditive and experimental.
See
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1068#note_2887939
|
| | |
|
| |
|
|
|
|
|
|
| |
The generational-arena crate is distributed under MPL-2.0,
so we need to allow it.
I believe that this license is fine and does not interfere with
our code or our users; the reviewer should double-check.
|
| | |
|
| |
|
|
| |
Now that we require 1.65, Rust 1.63 is no longer sufficient.
|
| | |
|
| |
|
|
| |
(We don't include Tor employees in our "thanks" section.)
|
| | |
|
| | |
|
| |
|
|
| |
In each case, use a circumlocution.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
See top-level main.rs comment for an explanation.
Closes #771
|
| |\
| |
| |
| |
| | |
maint: add a full dependency check
See merge request tpo/core/arti!1030
|
| | |
| |
| |
| |
| | |
This commit removes the dependency check introduced by b4b8d040, because
it's task is now done by the recently added `check_env` script.
|
| | |
| |
| |
| |
| |
| |
| | |
This commit adds a script that checks the environment for it's suitable
as an Arti development environment.
It follows an idea pitched by Ian Jackson and me in !1025.
|
| |\ \
| | |
| | |
| | |
| | | |
Approve zlib licence
See merge request tpo/core/arti!1035
|
| | | |
| | |
| | |
| | |
| | | |
There's nothing wrong with the previous idiom since it's a trusted
variable, but whatever.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is a very permissive BSD/MIT-like licence. I have reviewed the
licence text and it is inoffensive.
I want this for slotmap, in !1034
|
| | | |
| | |
| | |
| | | |
Even if it contains spaces.
|
| | | |
| | |
| | |
| | | |
This confused me while I was debugging the interaction with nailing-cargo.
|