| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
| |
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
|
| |
|
|
|
|
|
|
|
| |
`clippy::collapsible_if` started triggering after bumping the MSRV to
1.88.
Since this triggers from a lot of places, and since there even are a
couple of instances where we explicitly allow `clippy::collapsible_ifs`,
I've opened #2342 for deciding what to do about it.
|
| |
|
|
| |
This adds the lint to all our crates.
|
| |
|
|
| |
Run maint/add_warning
|
| |
|
|
|
|
| |
If we can't figure out the modal indentation, use " ".
Closes #1719.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Run cargo fix --edition
2. Selectively revert the "if let"->"match" changes.
These changes are meant to protect us from the lifetime changes
for "if let" bindings in Rust 2024.
But we're not actually relying on the old lifetime rules
anywhere, and the match syntax here is quite ugly.
3. Automatically revert `$pat:expr_2021` to `$pat:expr`.
(We don't actually want to restrict the expression syntax
that our macros accept).
Done with
`git grep -l expr_2021 | xargs perl -i -pe 's/expr_2021/expr/g;'`
4. Run cargo fmt.
|
| |
|
|
| |
See #2060.
|
| |
|
|
| |
Nightly clippy now suggests this.
|
| |
|
|
|
|
| |
Denies 'mod.rs' files for consistency.
https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
|
| |\
| |
| |
| |
| |
| |
| | |
maint: Add exclusion feature to `fixup-features`
Closes #1766
See merge request tpo/core/arti!2652
|
| | |
| |
| |
| |
| |
| |
| |
| | |
This commit adds an `--exclude <PREFIX>` argument to the
`fixup-features` tool in order to ignore crate paths for crates that we
do not publish, mainly those in the `examples/` and `maint/` directory.
Fixes #1766
|
| |/
|
|
|
|
|
|
| |
In 1.83, this warning triggers on many of our crates.
We're thinking of fixing them all, but for now,
we're going to disable the warning.
This is part of #1765.
|
| |
|
|
| |
This commit is automatically generated.
|
| |
|
|
| |
(Also, require a version of `toml_edit` that _has_ `DocumentMut`.)
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
We don't have any of these lints yet but let's do this tidying while
we're here. The test lint block seems appropriate for this
maintenance utility, at least right now while we're not making it a
proper external published thing.
Override the two lints that currently trip.
|
| | |
|
| | |
|
| |
|
|
|
| |
(If a published crate depends on an unpublished crate, crates.io
will refuse it.)
|
| |
|
|
|
| |
None of our crates should use wildcard versions; this will help us
detect them before publishing.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
An external edge does not cause its target to be created as a feature.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
I tried to use petgraph, but it was optimized for performance over
usability, and the usability was beyond me.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
The problem with our old rules is that "reachable from __nonadditive"
and "reachable from experimental" were not themselves sensible
definitions of nonadditive and experimental.
See
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1068#note_2887939
|
| |
|
|
| |
In each case, use a circumlocution.
|
| | |
|
| | |
|
| | |
|
|
|
See top-level main.rs comment for an explanation.
Closes #771
|