summaryrefslogtreecommitdiff
path: root/maint/add_warning
Commit message (Collapse)AuthorAgeFilesLines
* clippy: Suppress needless_pass_by_value in testsIan Jackson2023-08-231-0/+1
| | | | | | | Rationale: same as for useless_vec, as in 01cb7ee0a112. Prompted by reading a commit where someone did makework to get rid of an occurrence of this warning.
* add_warning: Change missing_docs,unreachable_pub to warnNick Mathewson2023-08-041-2/+7
| | | | Part of #951. See comments for explanation of why this is important.
* clippy: in tests, allow clippy::useless_vecIan Jackson2023-07-101-0/+1
| | | | | | | | | This is a perf issue, only. If tests are too slow, we will notice and ca speed them up. We should optimise for clarity and convenience, rather than speed. Forbidding this can result in churn between vec![] and [] as tests are updated and changed.
* clippy: globally allow clippy::needless_raw_string_hashesIan Jackson2023-07-101-0/+1
| | | | | | | | | | | | Rationale: no-one writes these by default without thinkinh. If they are unnecessary, then either the string must have had " in it before (in which case it might do again), or it is near other strings which *do* need it. And having it does no harm; indeed IMO it can increase clarity. Alternative to !1388's Fix new "needless_raw_string_hashes" lint from clippy +nightly
* add_warning: Tolerate clippy::missing_panics_docNick Mathewson2023-07-061-1/+0
| | | | | | | As of current nightly, this lint now includes expect()s, which makes it trigger way more than we'd like. See discussion on #950.
* lints: Promote clippy::print_stderr and clippy::print_stdoutIan Jackson2023-06-211-0/+2
| | | | | | | | These are available in our MSRV now, so we don't need to handle specially. We can just add them to the standard lint block. (Lint block in every crate will be updated automatically in the next commit.)
* Allow clippy::unchecked_duration_subtraction in testsNick Mathewson2023-01-271-0/+1
| | | | | This panics on error, and we're fine with a panic on misbehavior in tests.
* Disable clippy::unlinlined-format-argsNick Mathewson2023-01-271-0/+1
| | | | | | | | This warning kind of snuck up on us! (See #748) For now, let's disable it. (I've cleaned it up in a couple of examples, since those are meant to be more idiomatic and user-facing.) Closes #748.
* shell: use /usr/bin/env instead of absolute pathsEmil Engler2023-01-251-1/+1
| | | | | | | | | | This commit changes the shebang in all shell scripts from absolute paths (such as `/bin/bash` or `/usr/bin/python3`) to the `/usr/bin/env` binary with the accompanying interpreter as it's argument. The reason for this are as follows: - NixOS cannot work with absolute paths - BSD systems install their packages in /usr/local/bin
* add_warnings: ignore clippy::result_large_errNick Mathewson2022-11-031-0/+1
| | | | | This is a temporary workaround for #587 until we get it fixed for real.
* add_warnings: work with more non-GNU finds.Nick Mathewson2022-11-031-1/+1
| | | | | We were doing `find -name '*.rs'`, but `find . -name '*.rs'` (with the .) is more standard.
* Allow "clippy::single_char_pattern" in tests.Ian Jackson2022-10-121-0/+1
| | | | | | | This lint exists for perf reasons, and this is rarely relevant in tests. Using double quoted str is generally cognitively less burdensome.
* format python script in maintFAMASoon2022-08-171-14/+25
|
* maint/add_warning: Fix parsing of --checkIan Jackson2022-06-241-1/+1
| | | | Previously this would eat the first filename!
* clippy: Consolidate many lints in maint/add_warningIan Jackson2022-06-241-0/+3
| | | | | | Found these by disabling the nightly dbg macro special case. Now, we have a mechanism for globally adding suppressions to tests, we can use that instead.
* maint/add_warning: Add two lints via add_warning as a test caseIan Jackson2022-06-241-0/+2
|
* maint/add_warning: Add ability maintain test lint blocksIan Jackson2022-06-241-8/+34
|
* maint/add_warning: Scan all files by default, but insist only in someIan Jackson2022-06-241-9/+16
| | | | | | | This will allow us to have add_warning manage test lint blocks. We have to stop printing all the filenames because there are too many. Filenames still come out on error of course.
* clippy: Supresss clippy::significant_drop_in_scrutineeIan Jackson2022-06-231-0/+1
| | | | As per the linked discussion.
* lints: Scheme for allowing us to name nightly lintsIan Jackson2022-06-231-1/+3
| | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/issues/501
* maint/add_warning: Convert remaining assertsIan Jackson2022-05-311-4/+8
|
* maint/add_warning: Introduce ImproperFile and convert one assertIan Jackson2022-05-311-2/+18
|
* maint/add_warning: Use python3 argparseIan Jackson2022-05-311-11/+9
|
* maint/add_warning: Add "how to fix" to error messageIan Jackson2022-05-311-0/+1
| | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/557#note_2808879
* maint/add_warning: Provide --check modeIan Jackson2022-05-311-2/+22
|
* maint/add_warning: Change shebang to python3Ian Jackson2022-05-311-1/+1
| | | | "python" sometimes means Python 2.
* maint/add_warning: Use .tmp~ for temp filename, not .bakIan Jackson2022-05-311-3/+3
| | | | | "bak" ought to be a backup file, with the old contents, which this most definitely isn't.
* lints: Add let_unit_value allow to add_warningIan Jackson2022-05-311-0/+1
| | | | | add_warning can now add allows. This one was agreed in some other MR for one crate. Allow it everywhere.
* lints: Add two missing ones to add_warningIan Jackson2022-05-311-0/+2
| | | | | These were in some crates, but not all. Put them in add_warning where they will propagate everywhere.
* lints: maint/add_warning: New marker-based modeIan Jackson2022-05-311-35/+21
| | | | | | | | We don't process the in-script lint block, just paste it in, now. This is less complicated. This reverts/replaces "maint/add_warnings: Make it add the markers for its future self"
* maint/add_warnings: Make it add the markers for its future selfIan Jackson2022-05-311-0/+6
| | | | We'll run this in a moment. Then we'll revert it.
* lints: maint/add_warning: Improve orderingIan Jackson2022-05-311-1/+1
| | | | | The crates we have aren't consistent. But changing this means the deltas resulting from the script are smaller.
* maint/add_warnings: Tidy up, and add some commentaryIan Jackson2022-05-311-2/+7
| | | | | | This puts the actually-used lint list at the top. No functional change.
* add_warning: remove clone_on_ref_ptrNick Mathewson2022-03-011-1/+0
| | | | See !352
* maint/add_warning: Remove duplicate argv0 from usage messageIan Jackson2022-02-181-1/+1
|
* rename *.py scripts to bare nameIan Jackson2022-02-181-0/+118
Update all references. There are three remaining hits for git-grep '\.py\b' all of which are scripts in "little-t-tor", not here in arti.
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-26 19:40:39 +0000