| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
This panics on error, and we're fine with a panic on misbehavior in
tests.
|
| |
|
|
|
|
|
|
| |
This warning kind of snuck up on us! (See #748) For now, let's
disable it. (I've cleaned it up in a couple of examples, since
those are meant to be more idiomatic and user-facing.)
Closes #748.
|
| |
|
|
|
|
|
|
|
|
| |
This commit changes the shebang in all shell scripts from absolute
paths (such as `/bin/bash` or `/usr/bin/python3`) to the `/usr/bin/env`
binary with the accompanying interpreter as it's argument.
The reason for this are as follows:
- NixOS cannot work with absolute paths
- BSD systems install their packages in /usr/local/bin
|
| |
|
|
|
| |
This is a temporary workaround for #587 until we get it fixed for
real.
|
| |
|
|
|
| |
We were doing `find -name '*.rs'`, but `find . -name '*.rs'` (with the .)
is more standard.
|
| |
|
|
|
|
|
| |
This lint exists for perf reasons, and this is rarely relevant in
tests.
Using double quoted str is generally cognitively less burdensome.
|
| | |
|
| |
|
|
| |
Previously this would eat the first filename!
|
| |
|
|
|
|
| |
Found these by disabling the nightly dbg macro special case. Now, we
have a mechanism for globally adding suppressions to tests, we can use
that instead.
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
This will allow us to have add_warning manage test lint blocks.
We have to stop printing all the filenames because there are too
many. Filenames still come out on error of course.
|
| |
|
|
| |
As per the linked discussion.
|
| |
|
|
|
| |
As per
https://gitlab.torproject.org/tpo/core/arti/-/issues/501
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/557#note_2808879
|
| | |
|
| |
|
|
| |
"python" sometimes means Python 2.
|
| |
|
|
|
| |
"bak" ought to be a backup file, with the old contents, which this
most definitely isn't.
|
| |
|
|
|
| |
add_warning can now add allows. This one was agreed in some other MR
for one crate. Allow it everywhere.
|
| |
|
|
|
| |
These were in some crates, but not all. Put them in add_warning
where they will propagate everywhere.
|
| |
|
|
|
|
|
|
| |
We don't process the in-script lint block, just paste it in, now.
This is less complicated.
This reverts/replaces
"maint/add_warnings: Make it add the markers for its future self"
|
| |
|
|
| |
We'll run this in a moment. Then we'll revert it.
|
| |
|
|
|
| |
The crates we have aren't consistent. But changing this means the
deltas resulting from the script are smaller.
|
| |
|
|
|
|
| |
This puts the actually-used lint list at the top.
No functional change.
|
| |
|
|
| |
See !352
|
| | |
|
|
|
Update all references. There are three remaining hits for
git-grep '\.py\b'
all of which are scripts in "little-t-tor", not here in arti.
|
