| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We're about to make UnverifiedAuthCert::verify return a
TimerangeBound, not an AuthCert.
For the success cases, declare the expected return type.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
We're going to need to talk about Timebound in the non-test code.
|
| | | | | | | |
|
| | |_|_|/ /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This makes more sense because:
* `start_bound` and `end_bound` return `Bound::Included`
* It doesn't make sense to say that a document isn't valid at
the very start of its validity period. (And we don't want a half-open range.)
* NotYetValid(0ns) and Expired(0ns) are rather nonsensical errors.
In real timeliness tests it will make no difference since the current
time is only equal to the bound for a nanosecond. But tests that like
to test corner cases might be affected, and possibly some synthetic
situations (where the document's own validity time start is used
somehow) might change.
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Lint for clippy::string_slice
See merge request tpo/core/arti!4086
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This commit adds #[allow(clippy::string_slice)] to all functions in the
code where string slices are used, alongside a TODO comment.
We do this add the function header to have it consistent, as things like
expression based allow's are still experimental.
|
| | |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Add 'flowctl-cc' to 'default'
See merge request tpo/core/arti!4042
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | |_|_|_|/
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
All of the pieces are in place for this now.
Some of the pieces are not entirely complete or correct at this point:
that's sorted out by other MRs already open.
Currently there is no encoding, no verification functdion, and no
tests. Encoding depends on another oustanding MR (arti!4058).
Verification depends on the rework in arti!4065.
Tests are still to come.
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
netdoc: Add fuzzing support for parse2 with authcert, mds
See merge request tpo/core/arti!4068
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Bump derive-deftly to 1.11.3 to get $impl
See merge request tpo/core/arti!4083
|
| | | |_|/ / /
| |/| | | |
| | | | | |
| | | | | | |
New beta semver policy means we should pin the patchlevel.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The actual item field isn't in the struct yet, because that would
produce conflicts with other outstanding work in this same struct.
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
This will let us encode consensus signatures sections.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
This defines ordering of routerstatus items.
|
| | | | | | | |
|
| |/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This is a nontrivial type with much weirdness to do with publication
times etc., so let's mark this as incomplete until we have a round
trip test.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
We must reject unknown objects unless noted otherwise.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
No functional change.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Changes ItemPresent to accept but ignore additional arguments and/or an
object.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Adds the actual keyword for a present object to the test.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This commit adds a test for ItemPresent in terms of encoding and
decoding.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This commit adds the ItemPresent type, which is intended for token types
where the mere presence implies a truthful value, such as
`tunnelled-dir-server`.
For now, it lives in `ignored_impls` because it does in fact ignore
(actually rejects) everything around the item except the keyword.
The type implements ItemValueParseable and ItemValueEncodable; both
implementations being very minimal and only parsing/emitting the
keyword.
A test will be added within the next commit.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This commit documents a shortcoming explained on IRC that exists with
the current derive(Transparent) and generic types that are uncovered.
See E0210.
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
tor-netdoc: minor fixes arising from netstatus work
See merge request tpo/core/arti!4055
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
This matches C Tor and the spec.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
We need to use `-`, not `_`. So use concat! stringify!.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Now it round-trips.
|
| | | |_|_|/
| |/| | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
tor-netdoc: ParseInput: improve
See merge request tpo/core/arti!4057
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This makes the code clearer, especially since we're going to add
attributes.
|
| | |/ / / / |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Signed-off-by: David Goulet <[email protected]>
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Signed-off-by: David Goulet <[email protected]>
|
| | | | | |
| | | | |
| | | | |
| | | | | |
The new `Default`s have no panicking code paths.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This hopefully better shows that there's nothing to use here for general
socket types.
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This will allow us in the future to set custom sockopts on the socket
before calling connect().
I tested an arti proxy with tokio and async-std manually. Arti doesn't
yet support smol so I was not able to test it, but it's using the same
code as async-std so I would expect it to work.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This adds the trait type `ConnectOptions` to `NetStreamProvider` and adds
this `ConnectOptions` as an argument to `NetStreamProvider::connect()`.
You probably want to look at the changes in tor-rtcompat first, then the
rest of this commit is updating the various places we use
`NetStreamProvider`.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
For now this just sets up the structure. We'll add options for TCP
later.
|
| | | | | | |
|