mirrors/arti.git - mirror of https://gitlab.torproject.org/tpo/core/arti

	Commit message (Collapse)	Author	Age	Files	Lines
...
* \| \| \| \| \| \| \| \|	tor-netdoc: rustfmt (re-alphabetise and re-wrap imports)	Ian Jackson	2026-05-13	1	-2/+1
\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \|	tor-netdoc: vote authority entry: declare it complete	Ian Jackson	2026-05-13	1	-3/+0
\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \|	tor-netdoc: vote authority entry: parse shared-rand-commit	Ian Jackson	2026-05-13	1	-2/+89
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This is rather ugly, because the protocol is being ad-hoc again.
* \| \| \| \| \| \| \| \|	tor-netdoc: vote authority entry: parse shared-rand-participate	Ian Jackson	2026-05-13	1	-1/+21
\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \|	tor-netdoc: vote authority entry: parse legacy-dir-key	Ian Jackson	2026-05-13	1	-1/+6
\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \|	tor-netdoc: Soften a TODO.	Ian Jackson	2026-05-13	1	-2/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Preamble now doesn't contain anything that's wrong. It is missing a couple of fields that will be wanted when we generate votes.
* \| \| \| \| \| \| \| \|	tor-netdoc: Add a ticket reference for a TODO	Ian Jackson	2026-05-13	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This isn't needed for the arti dirauth consensus method, but it will be needed for arti dirauth vote calculator.
* \| \| \| \| \| \| \| \|	tor-netdoc: Add shared-rand-*-status to VoteAuthorityEntry	Ian Jackson	2026-05-13	2	-5/+4
\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \|	tor-netdoc: Break out SharedRandStatuses, and remove it from votes	Ian Jackson	2026-05-13	6	-14/+40
\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \|	tor-netdoc: impl Ord and PartialOrd for byte wrapper types	Ian Jackson	2026-05-13	2	-2/+15
\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \|	tor-netdoc: derive Ord and PartialOrd for RSA fingerprint types	Ian Jackson	2026-05-13	2	-4/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This will let us use them in types in ordered lists in netdocs, without fuss.
* \| \| \| \| \| \| \| \|	tor-netdoc: impl NetdocEncodableFields for NotPresent	Ian Jackson	2026-05-13	1	-1/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	And document its meaning when parsing and encoding as flattened fields.
* \| \| \| \| \| \| \| \|	tor-netdoc: NetdocEncodableFields: Suppress warnings for empty structs	Ian Jackson	2026-05-13	1	-0/+2
\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \|	tor-netdoc: NetdocEncodableFields: Suppress warnings for empty structs (pre-fmt)	Ian Jackson	2026-05-13	1	-1/+4
\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \|	tor-netdoc: Parsing with `#[netdoc(flatten)]`: cope with non-path types	Ian Jackson	2026-05-13	1	-1/+1
\|/ / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	ns_type! is a non-path type.
* \| \| \| \| \| \| \|	Merge branch 'rd-fingerprint' into 'main'	Clara Engler	2026-05-13	3	-6/+24
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Store fingerprint in Option<SpFingerprint> See merge request tpo/core/arti!3978
\| * \| \| \| \| \| \| \|	tor-netdoc: Change fingerprint to Option<SpFingerprint>	Clara Engler	2026-05-12	2	-2/+3
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: Obtain RSA identity from signing key	Clara Engler	2026-05-12	1	-2/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Will be required and unavoidable as we will change fingerprint to Option<SpFingerprint> in the next commit.
\| * \| \| \| \| \| \| \|	tor-netdoc: Return copy in RouterDesc::rsa_identity()	Clara Engler	2026-05-12	3	-4/+22
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This change might seem pointless for now but it will be required and unavoidable later on, because we will have to change RouterDesc::fingerprint from RsaIdentity to Option<SpFingerprint> which will make it impossible to be used inside the getter anymore. With this change, our only resort is to obtain the RSA identity from the signing key but we can only return a copy then because that RSA identity is created ad-hoc then.
* \| \| \| \| \| \| \| \|	Merge branch 'directory-signature-3' into 'main'	Clara Engler	2026-05-13	9	-584/+620
\|\ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	tor-netdoc: Sort out netstatus signatures See merge request tpo/core/arti!3937
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Replace an IEFE with use of .and_then() (fmt)	Ian Jackson	2026-05-05	1	-6/+5
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Replace an IEFE with use of .and_then()	Ian Jackson	2026-05-05	1	-3/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3937#note_3405033 Suggested-by: Clara Engler <[email protected]>
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Apply deferred rustfmt churn	Ian Jackson	2026-04-29	4	-37/+42
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Turn DirectorySignatureHashAlgo back into a normal struct	Ian Jackson	2026-04-29	2	-31/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Abolish the terrible macro. Review with --color-moved-ws=allow-indentation-change --color-moved.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: re-privatise some methods	Ian Jackson	2026-04-29	1	-6/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	hash_slice_for_verification is still needed by code in poc, that we're not replacing in this MR. So that TODO gets downgraded, instead.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: directory-signature: don't re-hash unnecessarily	Ian Jackson	2026-04-29	1	-3/+4
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Fix handling of explicit vs implicit dir sig SHA1 hash	Ian Jackson	2026-04-29	1	-6/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Now that everything is prepared, we can add the sha1_unnamed field in the hash accumulator.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Fix signature of hash_slice_for_verification	Ian Jackson	2026-04-29	2	-14/+10
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	In order to handle marked vs unmarked SHA1 correctly, it needs the original DigestAlgoInSignature. The only call site is in poc's verification code.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Fix signature of hash_slice_for_verification (pre-fmt)	Ian Jackson	2026-04-29	1	-1/+4
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Abolish poc's netstatus signature type	Ian Jackson	2026-04-29	3	-173/+19
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Use prod's Signature instead. This gets rid of: * The old parsing code. We have a new approach based on ItemValueParseable, KeywordOrString and and DigestAlgoInSignature. * The duplicate DirectorySignaturesHashesAccu and its temporary conversions. poc's verify_timeless function needs a little adjustment for the new struct layout.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Promote hash_slice_for_verification to prod	Ian Jackson	2026-04-29	2	-13/+13
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This function is not right, yet. We're going to fix it later. Review with --color-moved.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: impl SignatureItemParseable for netstatus::Signature	Ian Jackson	2026-04-29	1	-1/+14
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This is now pretty straightforward. The functions it calls need some work - we have blocking TODOs for that.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Introduce DirectorySignaturesHashesAccu::update_from	Ian Jackson	2026-04-29	2	-16/+53
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This now contains the hashing code that was in poc. In poc it was entangled with the signature type, mostly because once upon a time the hash was inside the signature. In the real code we can make it a standalone method. It takes DigestAlgoInSignature so that it will be able to handle the explicit vs implicit sha1 anomaly correctly - but it can't do that yet because the necessary field doesn't exist yet. Also, we are going to want to make it a bit lazier - preserve the MR-blocking todo for that. A handful of lines are being actually moved verbatim, so --color-moved may help a bit.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Promote poc's DirectorySignaturesHashesAccu to prod	Ian Jackson	2026-04-29	2	-29/+41
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	There are definitely some things wrong with this, but they all have MR-blocking TODOs so we can promote this type now. Largely code motion. Review with --color-moved.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Make some items temporarily pub(crate)	Ian Jackson	2026-04-29	1	-2/+4
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Temporary conversions between the two DirectorySignatureHashAlgos	Ian Jackson	2026-04-29	1	-0/+20
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Because we have two DirectorySignatureHashAlgo types because of the macrology problem, we need to introduce temporary conversions, to let us move code from poc to prod.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: netstatus signature hashing: Add TODO re wasted work	Ian Jackson	2026-04-29	1	-0/+1
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: netstatus signature hashing: Add TODO re unnamed sha1	Ian Jackson	2026-04-29	1	-0/+16
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We're going to fix this in this branch, as part of promoting the poc code to prod.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: netstatus signing algorithms: Improve a doc comment	Ian Jackson	2026-04-29	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	There isn't a "this" here; self is DirectorySignaturesHashesAccu.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: derive ItemValue parsing/encoding for Signature	Ian Jackson	2026-04-29	2	-4/+10
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This doesn't let us do any verification or anything.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: impl parsing/encoding for AuthCertKeyIds in directory-signature	Ian Jackson	2026-04-29	1	-1/+68
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This module will be used when we derive ItemValueParseable on Signature.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Introduce DigestAlgoInSignature parsing/encoding type	Ian Jackson	2026-04-29	1	-3/+59
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	And change the type of the field in Signature. We are going to abandon the almost completely manual parsing approach taken in poc's NdiDirectorySignature. That parsing approach was heavily influenced by poc's struct layout, which in turn was influenced by the way that previously, hashes were inside signatures. Instead we'll derive ItemValueParseable from Signature, and semi-manually implement the hash update. This type is the one that embodies the `directory-signature` item's parsing strangeness: the optional initial positional argument.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Unify authcert test modules (fmt)	Ian Jackson	2026-04-29	1	-313/+308
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Unify authcert test modules	Ian Jackson	2026-04-29	1	-32/+18
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Abolish the parse2_test and encode_test modules. These mostly existed because of cfg gates. Now, we can unify the test module namespace, and also remove an indentation level (that will come next, with rustfmt).
\| * \| \| \| \| \| \| \| \|	tor-netdoc: derive Display for DirectorySignatureHashAlgo	Ian Jackson	2026-04-29	1	-1/+1
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: netsatus: glob import from types, not types::misc	Ian Jackson	2026-04-29	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This way we import via the public names, which is more sensible, and we include things that aren't in misc. The whole of types is pretty good as a glob import here.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: types.rs: Add a missing export	Ian Jackson	2026-04-29	1	-0/+1
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: parse2: Improve another error span for missing trait impl	Ian Jackson	2026-04-29	1	-1/+1
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: parse2: Add missing ItemObjectParseable to prelude (fmt)	Ian Jackson	2026-04-29	1	-2/+2
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: parse2: Add missing ItemObjectParseable to prelude	Ian Jackson	2026-04-29	2	-3/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	And remove a then-unneeded import in a using module.