summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
* Merge branch 'warnings_168' into 'main'Alexander Færøy2023-03-105-7/+4
|\ | | | | | | | | Resolve a couple of new lints with Rust 1.68 See merge request tpo/core/arti!1062
| * Fix a bunch of needless-conversion warnings.Nick Mathewson2023-03-104-6/+2
| | | | | | | | | | Apparently 1.68 now warns when you call into_iter() on something that's already an iterator. Fair enough. Let's stop doing that.
| * Suppress a renamed-lint lint.Nick Mathewson2023-03-101-1/+2
| | | | | | | | | | | | | | The derive_hash_xor_eq lint was renamed in 1.68, but we can't use it under its new name, since we still need to support back to 1.60. Instead, we suppress the warning about the lint being renamed.
* | Discuss in comment why we're not using a newtype for the Strings in HostIan Jackson2023-03-091-0/+8
| |
* | Classify OnionAddressResolveRequest as NotImplementedIan Jackson2023-03-091-2/+1
| | | | | | | | | | | | | | | | We have a theory about how this ought to work, so it's noit an API usage error - it's an unimplemented feature. As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1060#note_2884757
* | Reject invalid hostnamesIan Jackson2023-03-091-2/+5
| | | | | | | | | | | | Reject them both for .onion and for "exit" hostnames This prevents a `Host` from having an invalid hostname in it.
* | Fix reference to no-longer-contemplated Host variantIan Jackson2023-03-091-1/+1
| | | | | | | | | | Reported in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1060#note_2884755
* | Dummy HsId::from_str on .onion: Return Bug, rather than panickingIan Jackson2023-03-091-5/+4
| | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1060#note_2884754
* | Improve error from HsId parse of "www.B32.onion"Ian Jackson2023-03-093-2/+14
| | | | | | | | And add some clarity and todos about address errors.
* | Avoid arti_client::ErrorDetail::Address for TorAddrError::InvalidHostnameIan Jackson2023-03-091-1/+19
| | | | | | | | Provide an explicit From impl isntead.
* | Test HsId parse of subdomainIan Jackson2023-03-091-0/+1
| | | | | | | | This error is not great.
* | arti-client: Parse .onion addresses and dispatch to client.rsIan Jackson2023-03-094-26/+163
| | | | | | | | | | | | | | Now, a Host has a separate variant for `.onion` which is always used, even when HS is disabled. Currently it ends in a todo!.
* | arti-client: DoThingInstructions: Make error returns consistentIan Jackson2023-03-092-9/+10
| | | | | | | | This is more comprehensible, and will be more convenient.
* | arti-client: Host: Use Display::fmt rather than write!Ian Jackson2023-03-091-2/+3
|/ | | | | write! is less good because the `{}` overwrites stuff like "did the caller ask for padding".
* Merge branch 'tor-proto-extensions' into 'main'Nick Mathewson2023-03-088-164/+354
|\ | | | | | | | | tor-proto: send an outbound meta/control-message and expect similar messages in return. See merge request tpo/core/arti!1051
| * tor-proto: Document limitation on send_control_messageNick Mathewson2023-03-081-0/+7
| |
| * tor-proto: Say "control message" a little more consistentlyNick Mathewson2023-03-081-1/+2
| | | | | | | | | | | | | | (I found "user request" in one place, and fixed that. I am not currently going to try to unify "control message" and "meta message" since both terms are misleading and we already have TODOs to try to merge them into a third better term.)
| * tor-proto: Make send_control_message wait for the reactor.Nick Mathewson2023-03-082-5/+22
| | | | | | | | | | This way we don't need to worry about race conditions that happen if the caller thinks that the handler is installed before it really is.
| * Serval rustdoc link fixes.Nick Mathewson2023-03-082-3/+3
| |
| * Fix an unrelated missing cfg_attr.Nick Mathewson2023-03-081-0/+1
| |
| * tor-proto: Have send_control_message install a handler, not return a streamNick Mathewson2023-03-083-98/+73
| |
| * tor-proto: Implement functionality to send a message and accept repliesNick Mathewson2023-03-084-54/+165
| | | | | | | | | | | | | | | | | | | | | | This new function combines "sending a message" and "accepting replies in a stream" into a single call, so that there is no gap between when the message is sent and the replies are available. There are a number of compromises here, in order to avoid API proliferation. I've tried to contain them as best I can. See comments for additional design discussion.
| * tor-proto: Change semantics of MetaCellHandlerNick Mathewson2023-03-081-72/+126
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now, the MetaCellHandler is responsible for consuming the messages it gets, and reporting status to whatever task is waiting for a status message. Additionally, the MetaCellHandler can decide to remain installed or shut down the circuit after a successful message. (Previously, it could only uninstall itself on success and kill the circuit on failure.) These changes will enable MetaCellHandlers to be used as the basis for handling more kinds of message. (There is some moved and reformatted code here; you may want to review it with `git {diff or show} --color-moved -b`.)
| * tor-proto: Give Path a method to access final hop num.Nick Mathewson2023-03-082-10/+16
| |
| * tor-proto: Give circ Reactor a constructor, and make its fields private.Nick Mathewson2023-03-082-30/+48
| |
* | Merge branch 'suffix' into 'main'Nick Mathewson2023-03-082-2/+7
|\ \ | |/ |/| | | | | Introduce and use ends_with_ignore_ascii_case See merge request tpo/core/arti!1058
| * Introduce and use ends_with_ignore_ascii_caseIan Jackson2023-03-082-2/+7
| | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1056#note_2884428
* | Merge branch 'introduce2_encrypted_portion' into 'main'Nick Mathewson2023-03-086-0/+235
|\ \ | | | | | | | | | | | | tor-cell: Add code for the payload of an hs-ntor handshake. See merge request tpo/core/arti!1052
| * | intro_payload: various doc fixes and TODOs from review.Nick Mathewson2023-03-081-4/+16
| | |
| * | tor-cell: Be a little more pedantic about INTRODUCE cell types.Nick Mathewson2023-03-081-3/+3
| | |
| * | tor-cell: Better describe the parts of intro payload.Nick Mathewson2023-03-081-3/+23
| | |
| * | tor-cell: Add code for the payload of an hs-ntor handshake.Nick Mathewson2023-03-064-0/+192
| | | | | | | | | | | | | | | | | | (This is the encrypted information inside the INTRODUCE2 cell; it's used by the client to tell the service where to find its rendezvous point.)
| * | tor-linkspec: Add a constructor for UnparsedLinkSpecNick Mathewson2023-03-062-0/+11
| | |
* | | Merge branch 'host2' into 'main'Ian Jackson2023-03-082-47/+140
|\ \ \ | |_|/ |/| | | | | | | | arti-client: Do not send resolve requests for IP addrs to exits See merge request tpo/core/arti!1057
| * | arti-client: Host: Be more explicit about what is allowed in HostnameIan Jackson2023-03-081-1/+11
| | |
| * | RustfmtIan Jackson2023-03-082-4/+16
| | |
| * | Abolish Host::into_string_and_portIan Jackson2023-03-081-23/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | When I was trying to add HS support to these layers, I found I could add a new variant to the `Host` enum but everything would still compile even though I hadn't written the necessary implementation! This method is a liability: when using it, one inevitably writes such latent bugs.
| * | arti-client: Do not send resolve requests for IP addrs to exitsIan Jackson2023-03-082-13/+58
| | | | | | | | | | | | | | | | | | | | | | | | Doing so doesn't seem like a good idea. It might even be some kind of leak? Found because I added a variant to `address::Host` for hidden services, and noticed that the resolve code still compiled.
| * | arti-client addr handling: Introduce StreamInstructionsIan Jackson2023-03-082-22/+71
| | |
* | | arti-client: Reject .onion, when we should, without allocatingIan Jackson2023-03-081-1/+2
| | | | | | | | | | | | Use new strip_suffix_ignore_ascii_case
* | | Use strip_suffix_ignore_ascii_case to quickly reject non-.onion HsId (fmt)Ian Jackson2023-03-081-1/+3
| | |
* | | Use strip_suffix_ignore_ascii_case to quickly reject non-.onion HsIdIan Jackson2023-03-082-3/+4
| | |
* | | tor-basic-utils: Provide str.strip_suffix_ignore_ascii_caseIan Jackson2023-03-081-0/+44
|/ / | | | | | | We're going to want this for cheaply stripping ".onion" from things.
* | Merge branch 'bug779' into 'main'Ian Jackson2023-03-081-4/+6
|\ \ | | | | | | | | | | | | | | | | | | tor-dirmgr: Don't try to mark consensus usable in a read-only store. Closes #779 See merge request tpo/core/arti!1055
| * | tor-dirmgr: Don't try to mark consensus usable in a read-only store.Nick Mathewson2023-03-081-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Doing this means that any attempt to use a read-only store would crash as soon as it found that the consensus was usable. It seems that this bug was introduced at some point doing all the dirmgr refactors we did over the past year. Perhaps there should be a test for running with a read-only store. Fixes #779
* | | Merge branch 'fuzzing_tor_bytes' into 'main'Ian Jackson2023-03-082-1/+39
|\ \ \ | |/ / |/| | | | | | | | tor-bytes: defend against misuse of extract_n(). See merge request tpo/core/arti!1053
| * | tor-bytes: Add take_rest and read_nested_* to fuzzer.Nick Mathewson2023-03-061-0/+25
| | |
| * | tor-bytes: defend against misuse of extract_n().Nick Mathewson2023-03-061-1/+14
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, if somebody wrote this code, an attacker could easily use it to cause an OOM panic: ``` let n = r.take_u64(); let items: Vec<Foo> = r.extract_n(n as usize)?; ``` The first line of defense here is not to write protocols like that: we don't actually _have_ any 32-bit counters in our protocol AFAICT. The second line of defense is to pre-check `n` for reasonableness before calling `extract_n`. Here we add a third line of defense: whereas previously we would do `Vec::with_capacity(n)` in `extract_n`, we now allocate an initial capacity of `min(n, r.remaining())`. This ensures that the size of the allocation can't exceed the remaining length of the message, which (for our cell types at least) should prevent it from overflowing or running OOM.
* | Merge branch 'hsonion' into 'main'Ian Jackson2023-03-072-5/+183
|\ \ | | | | | | | | | | | | Impl FromStr and Display for HsId, etc. See merge request tpo/core/arti!1054
| * | Impl Redactable for HsIdIan Jackson2023-03-072-1/+26
| | |
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 12:09:48 +0000