mirrors/arti.git - mirror of https://gitlab.torproject.org/tpo/core/arti

	Commit message (Collapse)	Author	Age	Files	Lines
...
\| * \| \|	tor-hsclient: Use proper CircParameters	Ian Jackson	2023-06-29	1	-2/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fixes #935
\| * \| \|	tor-circmgr: Expose CircParameters from NetParameters construction	Ian Jackson	2023-06-29	2	-15/+18
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	As per #935. I called this "circparameters_from_netparameters" not "circparameters_from_netparams" because the type is "NetParameters" not "NetParams".
* \| \| \|	keymgr: Fix wrong_key_type test.	Gabriela Moldovan	2023-06-29	1	-1/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The string representation of `SshKeyAlgorithm` on `main` changed between the time the tests were introduced and the time they were merged.
* \| \| \|	Merge branch 'handshake-error' into 'main'	Nick Mathewson	2023-06-29	2	-31/+59
\|\\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	tor-hsclient: Handle handshake completion error correctly See merge request tpo/core/arti!1336
\| * \| \|	tor-hsclient: err: Mention RENDEZVOUS2 in actual messages (fmt)	Ian Jackson	2023-06-29	1	-1/+3
\| \| \| \|
\| * \| \|	tor-hsclient: err: Rename to RendezvousCompletionCircuitError	Ian Jackson	2023-06-29	2	-5/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Thsi is a bit of a mouthful now, but it is comprehensible. As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1336#note_2917235
\| * \| \|	tor-hsclient: err: Mention RENDEZVOUS2 in actual messages	Ian Jackson	2023-06-29	1	-2/+2
\| \| \| \|
\| * \| \|	tor-hsclient: err: Move doc comment to correct impl	Ian Jackson	2023-06-29	1	-17/+17
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	See https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1336#note_2917236
\| * \| \|	tor-hsclient: err: Mention RENDEZVOUS2	Ian Jackson	2023-06-29	1	-2/+2
\| \| \| \|
\| * \| \|	tor-hsclient: err: Reword comments about error	Ian Jackson	2023-06-29	1	-1/+1
\| \| \| \|
\| * \| \|	tor-hsclient: Handle handshake completion error correctly	Ian Jackson	2023-06-28	2	-6/+31
\| \| \| \|
\| * \| \|	tor-hsclient: Rename RendezvousCompletionCircuit from RendezvousCompletion	Ian Jackson	2023-06-28	2	-5/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We need to handle errors during the handshake. That also produces a `tor_proto::Error` but we want to print a different message for that, so let's rename this before adding the new variant.
\| * \| \|	tor-hsclient: Move handling of Bug to new section	Ian Jackson	2023-06-28	1	-1/+2
\| \| \|/ \| \|/\| \| \| \| \| \| \|	It was wrong where ti was.
* \| \|	Merge branch 'keymgr-tests' into 'main'	gabi-250	2023-06-29	6	-0/+308
\|\ \ \ \| \|_\|/ \|/\| \| \| \| \| \| \| \|	keymgr: Add tests for ArtiNativeKeyStore See merge request tpo/core/arti!1337
\| * \|	keymgr: Add a TODO about implementing and testing has_key_bundle.	Gabriela Moldovan	2023-06-29	1	-0/+8
\| \| \|
\| * \|	keymgr: Add some basic insert and remove tests.	Gabriela Moldovan	2023-06-29	1	-0/+52
\| \| \|
\| * \|	keymgr: Add assert_found! test helper.	Gabriela Moldovan	2023-06-29	1	-8/+13
\| \| \|
\| * \|	keymgr: Add some key retrieval tests for ArtiNativeKeyStore.	Gabriela Moldovan	2023-06-29	1	-5/+54
\| \| \|
\| * \|	keymgr: Add a gen_keys param to init_keystore.	Gabriela Moldovan	2023-06-29	1	-2/+16
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This will enable future tests to optionally initialize the test key store with some test keys.
\| * \|	keymgr: Add tests for ArtiNativeKeyStore::key_path.	Gabriela Moldovan	2023-06-29	2	-0/+92
\| \| \|
\| * \|	keymgr: Derive Debug for ArtiNativeKeyStore.	Gabriela Moldovan	2023-06-29	1	-0/+1
\| \| \|
\| * \|	keymgr: Add tests for ssh key handling.	Gabriela Moldovan	2023-06-29	4	-0/+87
\| \| \| \| \| \| \| \| \| \| \| \|	Part of #895
\| * \|	keymgr: Return the key, not Box<()>.	Gabriela Moldovan	2023-06-29	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This fixes a bug which caused the function to always return a type-erased `()` instead of the actual key!
* \| \|	Merge branch 'netdir_todos' into 'main'	Nick Mathewson	2023-06-29	6	-52/+82
\|\ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Resolve or defer most TODO HS items in tor-netdir. See merge request tpo/core/arti!1310
\| * \| \|	netdir: Remove a TODO HS	Nick Mathewson	2023-06-29	1	-4/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The function this comment is asking us to write is `circtarget_from_pieces`.
\| * \| \|	Downgrade TODO HS on HsDirParams::compute().expect()	Nick Mathewson	2023-06-29	2	-4/+21
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	(Adding comments explaining that these errors are really unlikely to occur, unless there is a bug in our code or in Rust's time handling.)
\| * \| \|	netdir: Defer a TODO HS but add a comment	Nick Mathewson	2023-06-29	1	-1/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This issue with walking over the ring is an issue we really must solve on the services timeframe, as is the one about looking only at the rings for which a blinded ID is germane.
\| * \| \|	netdir: take n_replicas and spread_fetch from consensus parameters	Nick Mathewson	2023-06-29	1	-2/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This makes them configurable, since we allow the user to override any consensus parameter.
\| * \| \|	netdir: Downgrade/remove/defer some TODO hs entries.	Nick Mathewson	2023-06-29	2	-7/+5
\| \| \| \|
\| * \| \|	netdir: remove some now-needless warning suppressions.	Nick Mathewson	2023-06-29	2	-3/+0
\| \| \| \|
\| * \| \|	dirmgr: use voting_period.	Nick Mathewson	2023-06-29	1	-4/+1
\| \| \| \|
\| * \| \|	netdir: remove unnecessary wraps from srv_interval, extract_srvs	Nick Mathewson	2023-06-29	1	-13/+12
\| \| \| \|
\| * \| \|	netdir: Move voting_period() to netdoc::Lifetime	Nick Mathewson	2023-06-29	3	-15/+20
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	I was going to add a comment about "doing this if we need the voting period anywhere else" but it turns out that we also use it in dirmgr.
* \| \| \|	Merge branch 'badonion_error_2' into 'main'	Nick Mathewson	2023-06-29	2	-19/+10
\|\ \ \ \ \| \|/ / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	arti_client: Move BadOnion from TorAddrError to ErrorDetail. Closes #932 See merge request tpo/core/arti!1331
\| * \| \|	arti_client: Add a warning comment to TorAddrError.	Nick Mathewson	2023-06-29	1	-0/+3
\| \| \| \|
\| * \| \|	arti_client: Move BadOnion from TorAddrError to ErrorDetail.	Nick Mathewson	2023-06-29	2	-19/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This variant can never be constructed when parsing a TorAddr, so it doesn't make sense to have it in TorAddrError: the use can never see it unless they enable `error_detail`. Not a semver break because the client feature is not yet stable. Closes #932.
* \| \| \|	Merge branch 'keymgr-x25519-keys' into 'main'	gabi-250	2023-06-29	2	-29/+60
\|\ \ \ \ \| \|_\|/ / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	keymgr: Add support for x25519 keys. Closes #900 See merge request tpo/core/arti!1321
\| * \| \|	keymgr: Remove unneeded error variant.	Gabriela Moldovan	2023-06-27	1	-5/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The `Unsupported` variant is no longer needed now that we support `KeyType::X25519StaticSecret`s.
\| * \| \|	keymgr: Add support for x25519 keys.	Gabriela Moldovan	2023-06-27	2	-12/+10
\| \| \| \|
\| * \| \|	keymgr: Return a concrete type from read_ed25519_keypair.	Gabriela Moldovan	2023-06-27	1	-8/+9
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This also fixes a bug which caused the function to always return a type-erased `()` instead of the actual key!
\| * \| \|	keymgr: Move TODO closer to the code it refers to.	Gabriela Moldovan	2023-06-27	1	-10/+9
\| \| \| \|
\| * \| \|	keymgr: Map KeyType::X25519StaticSecret to an SshKeyAlgorithm.	Gabriela Moldovan	2023-06-27	1	-1/+1
\| \| \| \|
\| * \| \|	keymgr: Define an SshKeyAlgorithm enum.	Gabriela Moldovan	2023-06-27	1	-2/+40
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This previously just re-exported `ssh_key::Algorithm`. However, we will need to support x25519 keys (which aren't supported by the `ssh_key` crate), so we define our own enum for the key algorithm. In addition to the `Algorithm` variants from `ssh_key`, our enum also has an `X25519` variant.
* \| \| \|	Merge branch 'config-option' into 'main'	gabi-250	2023-06-29	1	-35/+63
\|\ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	arti cfg tests: exception declaration improvements See merge request tpo/core/arti!1330
\| * \| \| \|	arti cfg tests: Suppress an undesriable clippy lint	Ian Jackson	2023-06-28	1	-0/+1
\| \| \| \| \|
\| * \| \| \|	arti cfg tests: declare_exceptions: Annotate the types for clarity (fmt)	Ian Jackson	2023-06-28	1	-6/+4
\| \| \| \| \|
\| * \| \| \|	arti cfg tests: declare_exceptions: Annotate the types for clarity	Ian Jackson	2023-06-28	1	-1/+6
\| \| \| \| \|
\| * \| \| \|	arti cfg tests: Point the reader to the types used in declarations	Ian Jackson	2023-06-28	1	-0/+12
\| \| \| \| \|
\| * \| \| \|	arti cfg tests: Move InCode into declare_config_example	Ian Jackson	2023-06-28	1	-19/+19
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	It's used for declarations only, and they should all be here.
\| * \| \| \|	arti cfg tests: Make declare_exception take distinguished old/new types	Ian Jackson	2023-06-28	1	-15/+27
\| \| \|/ / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	As per discussion in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1320#note_2916689 and IRC followup.