| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | |
| | |
| | |
| | | |
This is just to make ntor and CREATE_FAST handshakes consistent.
|
| |/ / |
|
| |\ \
| |/
|/|
| |
| | |
Fix some recently-appearing clippy lints
See merge request tpo/core/arti!4240
|
| | |
| |
| |
| | |
Found by rustdoc.
|
| | |
| |
| |
| | |
Placates clippy.
|
| | |
| |
| |
| | |
Placates recent clippy.
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
Placates recent clippy. I find the API of both of these functions
unsatisfactory and would prefer a chunks_exact that promises to panic,
but I didn't find one in std or Itertools.
|
| |\ \
| | |
| | |
| | |
| | | |
Tidy some uses of Intern
See merge request tpo/core/arti!4233
|
| | | |
| | |
| | |
| | | |
We intern these in Microdesc, and should be consistent.
|
| | | | |
|
| | | |
| | |
| | |
| | | |
Rather than converting it to an Arc. This is the new idiom for Intern.
|
| | | |
| | |
| | |
| | | |
We don't need to open-code this any more.
|
| | | |
| | |
| | |
| | | |
This makes the interning more natural.
|
| | |/
| |
| |
| | |
Use educe so that we don't derive T: Clone bound.
|
| |\ \
| | |
| | |
| | |
| | | |
tor-proto: Add `HopSettings::from_handshake_params()` for incoming circuit requests
See merge request tpo/core/arti!4171
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The advantage of this over using a `SubprotocolRequest` is that we can
use the type system to ensure it only has subprotocols that are allowed
during a handshake.
|
| | | |
| | |
| | |
| | |
| | | |
We never used this, it was just needed because we used to convert to a
`CircParameters` which required this.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
... and also remove `CircNetParameters::as_circ_parameters()`.
We used to call `HopSettings::from_params_and_caps()` when handling
incoming circuit requests, but this didn't really make sense because we
already know exactly what settings we want.
The new `HopSettings::from_handshake_params()` takes the exact settings
we want, which means we can also skip constructing a `CircParameters`
and use the raw consensus `CircNetParameters`.
Most of the code in `CircNetParameters::as_circ_parameters()` has been
migrated in some form to `HopSettings::from_handshake_params()`.
|
| | |/ |
|
| |\ \
| | |
| | |
| | |
| | | |
tor-netdoc testdata-live: More shell script, less macrology
See merge request tpo/core/arti!4238
|
| | | |
| | |
| | |
| | |
| | | |
This is no longer used. Get rid of the code which generates it, and
the generated file.
|
| | | |
| | |
| | |
| | |
| | | |
This gits rid of the macrology, apart from the generated macro module
file.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is the code for the new approach. It's kind of ad-hoc but also
much less deep than the previous macrology.
And, run the script to see the output. Currently that file isn't used.
For now we leave the shell script code for generating
selected_relays.rs in testdata-live-download. The new code for
generated_consts.rs is very different, so it's clearer to split the
changes up this way.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I'm going to change the generation, and that means I need input files,
so I need to run a download (as per the comment in
testdata-live-download).
I'm doing this first, so the rest of the MR can see individual
changes.
|
| |\| |
| |/
|/|
| |
| | |
tor-netdoc testdata-live: Two nits
See merge request tpo/core/arti!4237
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
arti-relay: Remove unused_async clippy escape hatch
See merge request tpo/core/arti!4239
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The clippy CI job that uses RECENT_RUST_IMAGE fails without the `allow`
(RECENT_RUST_IMAGE uses Rust 1.96, where the `unused_async`
false-positive still appears to trigger).
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This was needed to work around two `unused_async`
false-positives that would trigger on older Rust versions.
This was fixed in https://github.com/rust-lang/rust-clippy/issues/15305
and released in 1.90, according to the [changelog].
Since these no longer trigger on 1.97.1, they are now causing the
`expect(clippy::unused_async)` to fail. Removing the `expect`s seems
like the most sensible fix.
[changelog]: https://github.com/rust-lang/rust-clippy/issues/15305
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
tor-netdoc: Add a few affordances
See merge request tpo/core/arti!4235
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4235#note_3439437
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4235#note_3439438
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4235#note_3439436
|
| | | | | |
|
| | | | | |
|
| | |/ /
| | |
| | |
| | |
| | | |
I keep finding I want to encode things and then I have to prat about
with a NetdocEncoder. Let's provide potted versions.
|
| |\ \ \
| | |/
| |/|
| | |
| | | |
tor-netdoc testdata-live: Export for the benefit of other crates
See merge request tpo/core/arti!4229
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add a new testdata_live module which is exposed with the testing
features, containing the testdata-live in string constants.
This avoids the need for test cases in other crates to walk the
filesystem to an area outside their own crate path.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We're about to *use* the fix that was in 1.11.4. We already updated
the lockfile in !4228, so this is just Cargo.toml changes (which will
prevent the minimal-versions tests failing when we change the code to
rely on the fix).
git-grep -l '^derive-deftly' |xargs perl -i~ -pe 's{\b\Q1.11.3\E\b}{1.11.4}g'
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This updates everything, but really I'm just running it to create the
new selected_relays.rs file.
The meaning of this file will become clear shortly.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
We could use build.rs for this, but since we have a script already,
this seems better.
The meaning of this file will become clear shortly.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Move supported consensus methods iteration to tor-dirauth from arti-dirauth
See merge request tpo/core/arti!4234
|
| | | |/
| |/|
| | |
| | | |
Now we provide SupportedConsensusMethod::iter_all().
|
| | | |
| | |
| | |
| | | |
Implement log_ratelim! in report_proxy_error
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This can happen if we get an unexpected BEGIN_DIR/RESOLVE too, so we
can't hard-code "BEGIN" in the error message.
Context: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4230#note_3439258,
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This feature-gating has been a source of confusion, and it unnecessarily
complicates the stream message handling flow.
I've previously argued in favour of keeping it, in the spirit of a belt
and braces approach to message validation, but I've been convinced that
in this particular case, the feature-gate is more trouble than it's
worth.
What makes things worse is that the `CircHop::handle_msg()`
function was designed poorly (by yours truly). I plan on refactoring it
at some point, hopefully soon. There is a TODO about this below
its doc comment.
|
| |\ \
| | |
| | |
| | |
| | | |
arti-dirauth: Build an arti consensus method plugin binary, and implement list-methods
See merge request tpo/core/arti!4225
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This will appear when the MR is merged.
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4225#note_3439197
|