summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | assert_not_impl: Fix a mendacious headingIan Jackson2026-06-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This bit of the doc contains both succeeding and failing examples, each marked with an appropriate comment.
* | | | | | assert_not_impl: Promote to tor-basic-utilsIan Jackson2026-06-104-42/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I want this in tor-netdoc (which doesn't use tor-config and probably shouldn't). Almost entirely code motion. Review with --color-moved.
* | | | | | assert_not_impl: Change example to use CellIan Jackson2026-06-101-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I want to mvoe this to tor-basic-utils, so it can't use tor-config in its example. Also, Cell is just a nicer example. (The rule identifier was already wrong.)
* | | | | | assert_not_impl: Introduce some `use`sIan Jackson2026-06-101-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | IMO this makes the example clearer. It will also make moving this macro to tor-basic-utils less noisy.
* | | | | | tor-netdoc: parse2: Add more docs about verificationIan Jackson2026-06-101-3/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4070#note_3422636
* | | | | | tor-netdoc: parse2: use TimeRangebound in exampleIan Jackson2026-06-101-3/+6
| | | | | |
* | | | | | tor-netdoc: parse2: Deprecate check_validity_timeIan Jackson2026-06-104-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4070#note_3422637 We must allow it in poc, but poc is a thing we're trying to abolish/replace, so that's OK.
* | | | | | tor-checkable: TimerangeBound: test edge casesIan Jackson2026-06-101-0/+10
| | | | | |
* | | | | | tor-checkable: TimeRangebound: document inclusivityIan Jackson2026-06-101-1/+2
| | | | | |
* | | | | | tor-netdoc: authcert: use TimerangeBound for UnverifiedAuthCert::verify (fmt)Ian Jackson2026-06-102-102/+52
| | | | | | | | | | | | | | | | | | | | | | | | Precisely the result of rustfmt.
* | | | | | tor-netdoc: authcert: use TimerangeBound for UnverifiedAuthCert::verifyIan Jackson2026-06-103-39/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | TimerangeBound is reasonably nice and this will fit in better when we want to verify votes. Adjust the one non-test call site (in tor-dirserver) using .and_then. In the tests: * Where we expected success, call .check_valid_at and add another .unwrap(). * Where we expected signature verification failure, delete the time parameters. * Where we expected timeliness failure, call .check_valid_at and map the error. * With nontrivial tolerance, add calls to `extend_[pre_]tolerance`.
* | | | | | tor-netdoc: authcert tests: add some parenthesesIan Jackson2026-06-101-4/+4
| | | | | |
* | | | | | tor-netdoc: authcert tests: insist on return value typeIan Jackson2026-06-101-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're about to make UnverifiedAuthCert::verify return a TimerangeBound, not an AuthCert. For the success cases, declare the expected return type.
* | | | | | tor-dirserver: Promote tor-checkable depIan Jackson2026-06-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | We're going to need to talk about Timebound in the non-test code.
* | | | | | tor-checkable: TimerangeBound: is_valid: Treat bounds as inclusive (fmt)Ian Jackson2026-06-101-2/+6
| | | | | |
* | | | | | tor-checkable: TimerangeBound: is_valid: Treat bounds as inclusiveIan Jackson2026-06-101-2/+2
| |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes more sense because: * `start_bound` and `end_bound` return `Bound::Included` * It doesn't make sense to say that a document isn't valid at the very start of its validity period. (And we don't want a half-open range.) * NotYetValid(0ns) and Expired(0ns) are rather nonsensical errors. In real timeliness tests it will make no difference since the current time is only equal to the bound for a nanosecond. But tests that like to test corner cases might be affected, and possibly some synthetic situations (where the document's own validity time start is used somehow) might change.
* | | | | Merge branch 'clippy-string-slice' into 'main'Nick Mathewson2026-06-10384-0/+453
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Lint for clippy::string_slice See merge request tpo/core/arti!4086
| * | | | | everywhere: Add #[allow(clippy::string_slice)]Clara Engler2026-06-0926-0/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds #[allow(clippy::string_slice)] to all functions in the code where string slices are used, alongside a TODO comment. We do this add the function header to have it consistent, as things like expression based allow's are still experimental.
| * | | | | maint: Run maint/add_warning to deny string slicesClara Engler2026-06-09378-0/+411
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit.
* | | | | Merge branch 'cc-default' into 'main'Nick Mathewson2026-06-102-1/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Add 'flowctl-cc' to 'default' See merge request tpo/core/arti!4042
| * | | | | arti: add 'flowctl-cc' to 'default'Steven Engler2026-06-011-0/+1
| | | | | |
| * | | | | arti-client: add 'flowctl-cc' to 'default'Steven Engler2026-06-011-1/+1
| | | | | |
* | | | | | tor-netdoc: Fix a doc comment formatting botchIan Jackson2026-06-091-1/+1
| | | | | |
* | | | | | tor-netdoc: Introduce toplevel NeteworkStatus typeIan Jackson2026-06-095-0/+74
| |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All of the pieces are in place for this now. Some of the pieces are not entirely complete or correct at this point: that's sorted out by other MRs already open. Currently there is no encoding, no verification functdion, and no tests. Encoding depends on another oustanding MR (arti!4058). Verification depends on the rework in arti!4065. Tests are still to come.
* | | | | Merge branch 'fuzz-parse2' into 'main'Nick Mathewson2026-06-092-2/+10
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | netdoc: Add fuzzing support for parse2 with authcert, mds See merge request tpo/core/arti!4068
| * | | | | netdoc: Add fuzzing support for parse2 with authcert, mdsNick Mathewson2026-06-042-2/+10
| | | | | |
* | | | | | Merge branch 'deftly' into 'main'Nick Mathewson2026-06-0932-33/+33
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bump derive-deftly to 1.11.3 to get $impl See merge request tpo/core/arti!4083
| * | | | | | Bump derive-deftly to 1.11.3Ian Jackson2026-06-0932-33/+33
| | |_|/ / / | |/| | | | | | | | | | | | | | | | New beta semver policy means we should pin the patchlevel.
* | | | | | tor-netdoc: F64Finite, initially for votes' stats itemsIan Jackson2026-06-093-0/+135
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The actual item field isn't in the struct yet, because that would produce conflicts with other outstanding work in this same struct.
* | | | | | tor-netdoc: document new encoding implsIan Jackson2026-06-091-0/+2
| | | | | |
* | | | | | tor-netdoc: impl EncodeOrd for SignatureIan Jackson2026-06-091-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | This will let us encode consensus signatures sections.
* | | | | | tor-netdoc: impl EncodeOrd for RouterStatusIan Jackson2026-06-092-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | This defines ordering of routerstatus items.
* | | | | | tor-netdoc: derive encoding for RouterStatusIan Jackson2026-06-092-1/+1
| | | | | |
* | | | | | tor-netdoc: derive encoding for RouterStatusIntroItemIan Jackson2026-06-091-0/+1
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | This is a nontrivial type with much weirdness to do with publication times etc., so let's mark this as incomplete until we have a round trip test.
* | | | | tor-netdoc: Reject Object again in ItemPresentClara Engler2026-06-091-3/+4
| | | | | | | | | | | | | | | | | | | | We must reject unknown objects unless noted otherwise.
* | | | | tor-netdoc: Allow args and object in ItemPresent (fmt)Clara Engler2026-06-091-8/+2
| | | | | | | | | | | | | | | | | | | | No functional change.
* | | | | tor-netdoc: Allow args and object in ItemPresentClara Engler2026-06-091-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | Changes ItemPresent to accept but ignore additional arguments and/or an object.
* | | | | tor-netdoc: Small ItemPresent test fixClara Engler2026-06-091-1/+1
| | | | | | | | | | | | | | | | | | | | Adds the actual keyword for a present object to the test.
* | | | | tor-netdoc: Test for ItemPresentClara Engler2026-06-091-1/+89
| | | | | | | | | | | | | | | | | | | | | | | | | This commit adds a test for ItemPresent in terms of encoding and decoding.
* | | | | tor-netdoc: Add ItemPresent typeClara Engler2026-06-093-2/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds the ItemPresent type, which is intended for token types where the mere presence implies a truthful value, such as `tunnelled-dir-server`. For now, it lives in `ignored_impls` because it does in fact ignore (actually rejects) everything around the item except the keyword. The type implements ItemValueParseable and ItemValueEncodable; both implementations being very minimal and only parsing/emitting the keyword. A test will be added within the next commit.
* | | | | tor-netdoc: Document Transparent shortcomingClara Engler2026-06-091-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit documents a shortcoming explained on IRC that exists with the current derive(Transparent) and generic types that are uncovered. See E0210.
* | | | | Merge branch 'netdoc-small-fixes' into 'main'Clara Engler2026-06-093-4/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | tor-netdoc: minor fixes arising from netstatus work See merge request tpo/core/arti!4055
| * | | | | tor-netdoc: {required,recommended}-*-protocols: change orderingIan Jackson2026-06-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | This matches C Tor and the spec.
| * | | | | tor-netdoc: {required,recommended}-*-protocols: fix encodingIan Jackson2026-06-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | We need to use `-`, not `_`. So use concat! stringify!.
| * | | | | tor-netdoc: SoftwareVersion: fix Display implIan Jackson2026-06-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Now it round-trips.
| * | | | | tor-netdoc: fix a doc formatting typoIan Jackson2026-06-031-1/+1
| | |_|_|/ | |/| | |
* | | | | Merge branch 'parse-input-improve' into 'main'Clara Engler2026-06-092-0/+17
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | tor-netdoc: ParseInput: improve See merge request tpo/core/arti!4057
| * | | | | tor-netdoc: ParseInput: document changesIan Jackson2026-06-031-0/+1
| | | | | |
| * | | | | tor-netdoc: ParseInput: add retain_unknown_values convenience setterIan Jackson2026-06-031-0/+10
| | | | | |
| * | | | | tor-netdoc: ParseInput: add accessorsIan Jackson2026-06-031-1/+4
| | | | | |
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 18:32:30 +0000