| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Soon it won't need be needed here any more. I'm removing it, because
having redundant handles to the CC state makes it difficult to see
exactly where it's being used from.
|
| | | | |
| | | |
| | | |
| | | | |
This is not just for clients!
|
| | | | |
| | | |
| | | |
| | | | |
Currently empty, will be fleshed out in a future commit.
|
| | | | |
| | | |
| | | |
| | | | |
I am about to use this in other places too.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
Relays will need to use it too.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This will be used in a future commit, inside the new generic circuit
reactor.
We need it because RELAY cells are handled very similarly, so we need
some way of finding out if a given generic chancell is actually a RELAY
cell that we can handle in an implementation-agnostic way.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This will be used in the stream reactor too (and the stream reactor will
eventually replace the corresponding client impl).
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: Tor CI Release <[email protected]>
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
maint/add_warning: Deny clippy::unused_async
Closes #2328
See merge request tpo/core/arti!3613
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
See discussion at
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3613#note_3332767
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit 84b31824f317458a2aad6fb021b623935870f5bd.
Reverted, as this is a public API that might actually need to become
`async` at some point.
See discussion at
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3613#note_3332767
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
This resolves a newly-triggered lint.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
The code here is still WIP, no need to apply the lint yet.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
This code is still WIP, no need to address the lint yet.
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Now that `load` is no longer `async`, this triggers a lint about the
unnecessary clone.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
To fix `clippy::unused_async`.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
This lint triggers now that the unnecessary `async` is gone.
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
This code is still WIP, so I propose we ignore the lint for now.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This resolves a warning triggered by the newly-introduced
`#[deny(clippy::unused_async)]`.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
This adds the lint to all our crates.
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
clippy: Fix missing doc for non-Linux builds
See merge request tpo/core/arti!3611
|
| | |/ / / |
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
arti: Downgrade "stream closed without END" warning to debug.
Closes #2304
See merge request tpo/core/arti!3608
|
| | | | |
| | | |
| | | |
| | | | |
We now need it whether or not http-connect is enabled.
|
| | | | |
| | | |
| | | | |
Co-authored-by: carti-it <[email protected]>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This isn't the long-term solution to error reporting and proxies,
but it is a start that we can work from.
Closes #2304.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As near as I can tell, there are only three ways that the sender
corresponding to this rx can be dropped:
- `StreamMap::terminate` because the stream object itself was
dropped. (But see #2323.)
- `StreamMap::close_stream` because an END message or similar
has been received. (But see #2322.)
- The `StreamMap` has been dropped.
The first two cases are already handled, and AFAICT the third can
only happen when the circuit hop closes. That makes
`CircuitClosed` the appropriate error here, not `StreamProto`.
Part of a fix for #2304.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This is needed since we rely on `Slab::new()` being a const fn, which
was only added in 0.4.7.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
tor-dirserver: Make compression failures a bug
See merge request tpo/core/arti!3605
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This commit adds a comment explaining why we treat compression errors as
a bug.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This commit removes `DatabaseError::Compression` because it does not fit
in. Right now, this single variant makes the error to be call-site
oriented which is not nice for error handling. Instead, this error
should indicate that something was truly wrong with the database in
itself, such as an invalid schema, a low-level SQLite bug, etc.
Instead, we now map a compression error to `DatabaseError::Bug` because
there is no good reason on why it should fail, given that we compress
memory data to memory data. Probably because it uses the
`std::io::Writer` interface which itself demands use of
`std::io::Result`.
|