| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We need to be able to parse KeyPaths into KeyCertificateSpecifier,
and we can't do that if the signing key is part of the cert specifier
(because the signing key doesn't get encoded in the key path, unlike the
subject key, which does)
|
| |/ / /
| | |
| | |
| | |
| | | |
These are significantly different from `KeySpecifierPattern`s, so it's
best to have a separate trait.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
tor-netdir: Add spec link to flag descriptions
See merge request tpo/core/arti!3768
|
| | |/ / |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
We'd rather use p256, but unfortunately C tor has a bug when TLS
cert subject keys are not RSA: see tor#41226.
Closes #2403.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
tor-dirclient: Attempt to explain AnonymizedRequest
See merge request tpo/core/arti!3767
|
| | | | | |
|
| | |/ / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
keymgr: Update cert ArtiPath building to use denotator sets
Closes #2377
See merge request tpo/core/arti!3754
|
| | | | |
| | | |
| | | |
| | | | |
Addresses https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3754#note_3361904
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This commit is intentionally misindented to make reviewing the diff a
bit easier.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In a certificate's `ArtiPath`, the `ArtiPath` of the subject key is now
separated from the certificate denotators by `@`. This will enable us to
derive the subject key `ArtiPath` from the `ArtiPath` of its
certificate.
In practice, this change is a no-op for the relay implementation,
because none of our certificates have certificate denotators. For
instance, the `ArtiPath` of the for the `KP_relaysign_ed` certificate
(`KP_relaysign_ed` signed with `KS_relayid_ed`) is of the form
`relay/relaysign_ed+<valid_until>` (the only denotators here are the
denotators of the subject key).
It's important to note that the certifying key is not encoded in the
`ArtiPath` of the certificate. The implication is that if we'll ever
need to have multiple certs for the same subject key, signed with
different with different certifying keys, those certificates will be
distinguished by their certificate denotator group. So if we ever need a
second certificate for `KP_relaysign_ed`, certified with something other
than `KP_relaysign_ed`, it will need to be of the form
`relay/relaysign_ed+<valid_until>@<CERT_DENOS>`, where `<CERT_DENOS>`
is a list of `+`-separated certificate denotators.
Closes #2377
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This will enable us to parse certificate paths that consist of the
`ArtiPath` of the subject key, followed by the denotator group of the
certificate.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This introduces the concept of a "denotator group", and new syntax for
separating denotator groups within an ArtiPath.
The implementation will follow in a separate commit.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`KeyCertificateSpecifiers` have an `ArtiPath`, so it's only natural to
retrieve it via this new `KeySpecifier` implementation.
This replaces the old, ad-hoc `ArtiPath` building from the `KeyMgr`
implementation: IMO, the `KeyMgr` impl is the wrong place to build these
`ArtiPath`s (ideally they should remain opaque to the `KeyMgr`).
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
tor-netdir: Add is_flagged_exit() to RelayDetails
See merge request tpo/core/arti!3752
|
| | | | | |
| | | | |
| | | | |
| | | | | |
No need to over-engineer this, let's keep it simple.
|
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This commit adds a method called `is_flagged_exit` to `RelayDetails` in
order to check whether the node is considered to be usable as an exit or
not.
In the Tor VPN app, we need this feature for generating a list of exit
relays (per country). Right now, we do this in an incorrect way by only
checking on whether port 443 is in the exit policy, which is not a
sufficient criteria.
|
| |\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | | |
rpc: Fix a bug related to stop_writing
See merge request tpo/core/arti!3762
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Without this, the poll() method wouldn't actually perform as
advertised.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
keymgr: Test helper cleanup
See merge request tpo/core/arti!3761
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Resolves a clippy warning.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Resolves a clippy warning.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
As suggested by clippy
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This doesn't really need to be macro-generated, because these impls only
differ in the `KeystoreId`.
The code is intentionally misindented to make reviewing the diff a bit
easier. A future commit will reformat it all.
|
| | | | | | |
|
| | | |/ /
| |/| |
| | | |
| | | |
| | | | |
I am about to remove this macro altogether and simplify the keystore
impls, so I am preemptively moving this into a separate function.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This commit changes the functionality of the AuthCerts state to only
report a success when at least a single certificate was included in the
response.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Adds a small TODO with regard to a potentially broken retry logic in the
proof-of-concept.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This commit documents why and how we use the `unsigned_` fields in the
`consensus_router_descriptor_member` table alongside SQL limitations.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This commit moves dirserver POC code to an own module to semantically
indicate it is not production ready.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This commit documents why we drop the HTTP TCP stream and why this is
fine, namely because this is compliant HTTP/1.0 behavior where there is
no connection reuse.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This commit links the discussion for the TODO for the dirmirror's
handling of forward compatibility with netdocs.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This commit adds a TODO to implement a trait combining the common fields
in a network status documents.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This commit replaces the uses of sha1, sha2, and sha3 with their
respective pedants from tor-llcrypto for better consistency.
Internally, they still use the same logic and underlying crates but
let's use this encapsulation nonetheless.
|