| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | |
| | |
| | |
| | |
| | |
| | | |
This will enable us to parse certificate paths that consist of the
`ArtiPath` of the subject key, followed by the denotator group of the
certificate.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This introduces the concept of a "denotator group", and new syntax for
separating denotator groups within an ArtiPath.
The implementation will follow in a separate commit.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`KeyCertificateSpecifiers` have an `ArtiPath`, so it's only natural to
retrieve it via this new `KeySpecifier` implementation.
This replaces the old, ad-hoc `ArtiPath` building from the `KeyMgr`
implementation: IMO, the `KeyMgr` impl is the wrong place to build these
`ArtiPath`s (ideally they should remain opaque to the `KeyMgr`).
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
tor-netdir: Add is_flagged_exit() to RelayDetails
See merge request tpo/core/arti!3752
|
| | | | |
| | | |
| | | |
| | | | |
No need to over-engineer this, let's keep it simple.
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit adds a method called `is_flagged_exit` to `RelayDetails` in
order to check whether the node is considered to be usable as an exit or
not.
In the Tor VPN app, we need this feature for generating a list of exit
relays (per country). Right now, we do this in an incorrect way by only
checking on whether port 443 is in the exit policy, which is not a
sufficient criteria.
|
| |\ \ \
| |_|/
|/| |
| | |
| | | |
rpc: Fix a bug related to stop_writing
See merge request tpo/core/arti!3762
|
| | | |
| | |
| | |
| | |
| | | |
Without this, the poll() method wouldn't actually perform as
advertised.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
keymgr: Test helper cleanup
See merge request tpo/core/arti!3761
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
Resolves a clippy warning.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
Resolves a clippy warning.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
As suggested by clippy
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This doesn't really need to be macro-generated, because these impls only
differ in the `KeystoreId`.
The code is intentionally misindented to make reviewing the diff a bit
easier. A future commit will reformat it all.
|
| | | | | |
|
| | | |/
| |/|
| | |
| | |
| | | |
I am about to remove this macro altogether and simplify the keystore
impls, so I am preemptively moving this into a separate function.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This commit changes the functionality of the AuthCerts state to only
report a success when at least a single certificate was included in the
response.
|
| | | |
| | |
| | |
| | |
| | | |
Adds a small TODO with regard to a potentially broken retry logic in the
proof-of-concept.
|
| | | |
| | |
| | |
| | |
| | | |
This commit documents why and how we use the `unsigned_` fields in the
`consensus_router_descriptor_member` table alongside SQL limitations.
|
| | | |
| | |
| | |
| | |
| | | |
This commit moves dirserver POC code to an own module to semantically
indicate it is not production ready.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This commit documents why we drop the HTTP TCP stream and why this is
fine, namely because this is compliant HTTP/1.0 behavior where there is
no connection reuse.
|
| | | |
| | |
| | |
| | |
| | | |
This commit links the discussion for the TODO for the dirmirror's
handling of forward compatibility with netdocs.
|
| | | |
| | |
| | |
| | |
| | | |
This commit adds a TODO to implement a trait combining the common fields
in a network status documents.
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit replaces the uses of sha1, sha2, and sha3 with their
respective pedants from tor-llcrypto for better consistency.
Internally, they still use the same logic and underlying crates but
let's use this encapsulation nonetheless.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit moves the database schema into schema_v1.sql and uses
include_str to include it. For now, the schema lives in the `src/`
directory. If this becomes a problem because we get more schemas and
schema upgrades, we can move it into another sub directory, but let's
not overengineer the hierarchy there.
|
| | | |
| | |
| | |
| | |
| | | |
This commit implements a PoC serving as the main loop for the FSM,
demonstrating how invocation and error handling works.
|
| | | |
| | |
| | |
| | | |
Discussed with nickm on IRC, there will be a torspec issue soon.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit implements the logic required for retrieving, validating,
and storing authority certificates.
The implementation determines the missing certificates by looking at the
signatories of the unvalidated consensus and checking them in the db.
Afterwards, they will be queried and individually filtered and verified
before being inserted into the database.
A return of this implementation notably DOES NOT imply all missing
certificates have been downloaded. This was chosen for a simplified
retry logic.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit adds a new method to static engine that serves as a
convenience wrapper around `tor_dirclient::send_request`.
The reason for that is, that fetch_consensus is not the only method that
requires performing download requests, so it makes sense to generalize
it.
Besides, it also adds support for parsing multiple netdocs alongside
storing their raw variant, which is required for inserting them into the
database at one point eventually.
|
| | | |
| | |
| | |
| | |
| | | |
This commit adds the IsFatal trait to the err module for having a
generic signature for the fatality of certain error variants.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit implements the `FetchConsensus` state by adding a method to
`StaticEngine` called `fetch_consensus`, which retrieves the consensus
from an upstream directory authority.
Likewise, it also implements a new error type called
`AuthorityRequestError`.
The retry logic is handled externally which will be done in later
commits.
|
| | | |
| | |
| | |
| | | |
Required to test state transitions properly.
|
| | | |
| | |
| | |
| | | |
This is required for compatibility with other crates in arti.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
This commit removes the download manager module because it does not fit
well into the mental model of our current finite state machine anymore.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit removes the `preferred` member field from the `Unverified`
and `Verified` variant in `ConsensusBoundData` while adding it as a
parameter to `StaticEngine::execute`, with the idea being that the retry
logic is handled by the caller anyways, involving the selection of
authorities.
Right now, I am still a bit unsure how this will play out.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This commit implements the consensus loading mechanism by glueing
together the logic from the database module with regard to querying
missing descriptors.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit implements the logic for querying missing descriptors by
adding three new methods to ConsensusMeta:
* missing_servers
* missing_extras
* missing_micros
All of them essentially work the same, namely by querying the
consensus_router_descriptor_member database table alongside the docid of
the current consensus, left joining the respective router_descriptor and
returning the digests on all rows where the left join resulteed in a
NULL.
A small exception are extra-info descriptors. There, we can only return
the ones where we have an accompanying server descriptor, hence why we
perform an inner join with the server descriptors between the from and
the left join.
|