| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
tor-proto: allow comparison chain
See merge request tpo/core/arti!3342
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It was decided that the comparison chain was actually preferrable for
readability. So instead, we're just `allow`ing it until it stops being
a problem.
Signed-off-by: hashcatHitman <[email protected]>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There was a comparison chain in
`tor_proto::util::poll_all::test::ResolveAfter::poll` which was causing
a clippy warning. The lint in question, `clippy::comparison_chain`, was
a `clippy::style` lint in 1.85.1 and got moved to `clippy::pedantic` in
1.87.0 (see [rust-clippy!14219]).
Since some of us (like me) develop on MSRV, I'm fixing this lint now.
Gabi didn't have any strong opinions on whether I did it like this or
with an `allow` attribute, so I decided this was better since it means
we don't have to come back later just to remove the `allow`.
It should be noted that using a match like this can sometimes be a
performance regression (see [rust-clippy#5354] and [rust-clippy!6390]).
I would expect in this case the effect will be very little, if any, but
if tests in `tor_proto::util::poll_all::test` start taking much longer
and having an impact on CI or something, this could be why.
[rust-clippy!14219]: https://github.com/rust-lang/rust-clippy/pull/14219
[rust-clippy#5354]: https://github.com/rust-lang/rust-clippy/issues/5354
[rust-clippy!6390]: https://github.com/rust-lang/rust-clippy/pull/6390
Signed-off-by: hashcatHitman <[email protected]>
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
tor-netdoc: impl NormalItemArgument for Ipv4Addr and SocketAddr
See merge request tpo/core/arti!3343
|
| | |/ / /
| | | |
| | | |
| | | | |
AFAICT we don't have variant parsings for these things.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
And remove one that we didn't need.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
We'll add a `TorRelay` back in a following commit.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
hashx: Fix compilation on aarch64 with dynasm 4.0
Closes #2208
See merge request tpo/core/arti!3341
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The new conversion mechanisms in dynasm 4.0 make clippy unhappy
under aarch64.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
(Starting with version 4, dynasm wants something
that implements Into<u8>.)
|
| | | | | | |
|
| |\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
arti: keys: Rework the output of `arti keys check-integrity`
Closes #2151
See merge request tpo/core/arti!3286
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
and `keystores`
|
| | | | | |
| | | | |
| | | | |
| | | | | |
The function now returns `Result<Vec<InvalidKeystoreEntry<'a>>>`
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Add a check in `run_check_integrity` to verify that the `expired_entries`
collection is empty after processing all registered keystores. This should
always be true, as all expired entries are expected to be removed during
iteration. If not, it indicates a bug.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Replace raw tuples with named structs to reduce type complexity and improve
code clarity and maintainability.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
`run_check_integrity`
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Fix bug where expired keys from one keystore were incorrectly
associated with all keystores
- Remove unnecessary clone
|
| | | | | |
| | | | |
| | | | |
| | | | | |
`run_check_integrity`
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Add `display_invalid_keystore_entries` helper function
`print_check_integrity_incipit`
- Add `display_invalid_keystore_entries` comment
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Add initial functional implementation of `display_invalid_keystore_entries`,
which processes a list of invalid keystore entries grouped by `KeystoreId`
and displays them with associated error messages.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Create the skeletal version of the new `display_invalid_keystore_entries` function
and adapt `run_check_integrity` to use it.
The function now takes a slice of pairs, each containing a `KeystoreId` and a vector
of invalid keystore entries along with their error messages, and processes all
entries internally by iterating over each keystore, instead of being called
once per keystore.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Previously, the function worked with a flat `Vec<KeystoreEntryResult<KeystoreEntry>>`.
Now, it uses a structured `Vec<(KeystoreId, Vec<KeystoreEntryResult<KeystoreEntry>>)>`,
grouping entries by keystore.
This makes it easier to track which keystore each entry belongs to,
and prepares the code for upcoming improvements.
|
| |\ \ \ \ \
| |_|_|/ /
|/| | | |
| | | | |
| | | | | |
tor-netdoc: Deprecate `build_docs` and tidy feature docs
See merge request tpo/core/arti!3340
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We're going to eventually implement the traits in `src/build.rs` for
the network document types.
But, this feature mainly covers `doc/*build*`. That (a) isn't used
in-tree (b) isn't really needed now that the fields are all pub
(c) is currently marked experimental.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
And mention that there are experimental and undocumented features.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It is FromStr (which is fine). Which emant it was
ItemArgumentParseable but but it can't be Display so it can't be
NormalItemArgument. This illuminates the fact that it shouldn't
really be ItemArgumentParseable since we're going to want all types
that are in netdoc structs to be both parseable and printable.
|