summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
* | | tor-netdoc: parse2: Add whole_line_len to ArgumentStreamIan Jackson2025-10-092-4/+17
| | |
* | | Merge branch 'comparison-chain' into 'main'gabi-2502025-10-091-0/+6
|\ \ \ | | | | | | | | | | | | | | | | tor-proto: allow comparison chain See merge request tpo/core/arti!3342
| * | | tor-proto: bring back comparison chain w/ allowhashcatHitman2025-10-081-9/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was decided that the comparison chain was actually preferrable for readability. So instead, we're just `allow`ing it until it stops being a problem. Signed-off-by: hashcatHitman <[email protected]>
| * | | tor-proto: replace comparison chain with matchhashcatHitman2025-10-081-8/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a comparison chain in `tor_proto::util::poll_all::test::ResolveAfter::poll` which was causing a clippy warning. The lint in question, `clippy::comparison_chain`, was a `clippy::style` lint in 1.85.1 and got moved to `clippy::pedantic` in 1.87.0 (see [rust-clippy!14219]). Since some of us (like me) develop on MSRV, I'm fixing this lint now. Gabi didn't have any strong opinions on whether I did it like this or with an `allow` attribute, so I decided this was better since it means we don't have to come back later just to remove the `allow`. It should be noted that using a match like this can sometimes be a performance regression (see [rust-clippy#5354] and [rust-clippy!6390]). I would expect in this case the effect will be very little, if any, but if tests in `tor_proto::util::poll_all::test` start taking much longer and having an impact on CI or something, this could be why. [rust-clippy!14219]: https://github.com/rust-lang/rust-clippy/pull/14219 [rust-clippy#5354]: https://github.com/rust-lang/rust-clippy/issues/5354 [rust-clippy!6390]: https://github.com/rust-lang/rust-clippy/pull/6390 Signed-off-by: hashcatHitman <[email protected]>
* | | | Merge branch 'normal-ip-arguments' into 'main'Ian Jackson2025-10-091-0/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | tor-netdoc: impl NormalItemArgument for Ipv4Addr and SocketAddr See merge request tpo/core/arti!3343
| * | | | tor-netdoc: impl NormalItemArgument for Ipv4Addr and SocketAddrIan Jackson2025-10-081-0/+5
| |/ / / | | | | | | | | | | | | AFAICT we don't have variant parsings for these things.
* | | | arti-relay: replaced `Runtime + ToplevelBlockOn` with `ToplevelRuntime`Steven Engler2025-10-081-3/+3
| | | |
* | | | arti-relay: expand comment on `InertTorRelay`Steven Engler2025-10-081-0/+17
| | | |
* | | | arti-relay: change `allow` to `expect`Steven Engler2025-10-081-5/+4
| | | | | | | | | | | | | | | | And remove one that we didn't need.
* | | | arti-relay: add a new `TorRelay`Steven Engler2025-10-082-1/+50
| | | |
* | | | arti-relay: store the `TorRelayConfig` in the `InertTorRelay`Steven Engler2025-10-082-4/+7
| | | |
* | | | arti-relay: change `TorRelay` into `InertTorRelay`Steven Engler2025-10-082-24/+9
| | | | | | | | | | | | | | | | We'll add a `TorRelay` back in a following commit.
* | | | tor-config: remove stale comment on `ConfigurationSources::try_from_cmdline`Steven Engler2025-10-081-2/+0
| | | |
* | | | arti-relay: log the override options usedSteven Engler2025-10-081-1/+32
| | | |
* | | | tor-config: add `ConfigurationSources::options()`Steven Engler2025-10-081-0/+7
| | | |
* | | | arti-relay: add mainloopSteven Engler2025-10-082-8/+61
| | | |
* | | | arti-relay: add `ToplevelBlockOn` to returned runtimeSteven Engler2025-10-081-2/+2
| | | |
* | | | arti-relay: don't prepend "arti-relay: " to log linesSteven Engler2025-10-081-10/+2
| | | |
* | | | arti-relay: re-add trailing '/' to default paths in help textSteven Engler2025-10-081-2/+12
| | | |
* | | | Merge branch 'aarch64-fix' into 'main'Nick Mathewson2025-10-083-13/+31
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | hashx: Fix compilation on aarch64 with dynasm 4.0 Closes #2208 See merge request tpo/core/arti!3341
| * | | | hashx: A couple of comments about register rangesNick Mathewson2025-10-082-0/+4
| | | | |
| * | | | hashx: Make exceptions for clippy warnings from dynasm.Nick Mathewson2025-10-081-9/+17
| | | | | | | | | | | | | | | | | | | | | | | | | The new conversion mechanisms in dynasm 4.0 make clippy unhappy under aarch64.
| * | | | hashx: Make RegisterId::x() return u8 on aarch64Nick Mathewson2025-10-071-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | (Starting with version 4, dynasm wants something that implements Into<u8>.)
| * | | | hashx: Provide a u8 accessor for RegisterId.Nick Mathewson2025-10-072-1/+7
| | | | |
* | | | | Merge branch '2151-check-integrity-output' into 'main'opara2025-10-081-55/+183
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | arti: keys: Rework the output of `arti keys check-integrity` Closes #2151 See merge request tpo/core/arti!3286
| * | | | arti: keys: Simplify `run_check_integrity`hjrgrn2025-10-081-9/+7
| | | | |
| * | | | arti: keys: Improve readability of `print_check_integrity_incipit`hjrgrn2025-10-081-11/+7
| | | | |
| * | | | arti: keys: Fix typo in `run_check_integrity`hjrgrn2025-10-081-1/+1
| | | | |
| * | | | arti: keys: Rename `invalid_entry` to `expired_entry` in `run_check_integrity`hjrgrn2025-10-081-3/+3
| | | | |
| * | | | arti: keys: Add warning for unexpected invalid keystore entryhjrgrn2025-10-081-14/+16
| | | | |
| * | | | arti: keys: Improve readability of `run_check_integrity`hjrgrn2025-10-081-5/+4
| | | | |
| * | | | arti: keys: Add comment explaining why `services` cannot be droppedhjrgrn2025-10-081-0/+2
| | | | |
| * | | | arti: keys: Add comment explaining difference between `affected_keystores` ↵hjrgrn2025-10-081-0/+5
| | | | | | | | | | | | | | | | | | | | and `keystores`
| * | | | arti: keys: Refactor `get_expired_keys`hjrgrn2025-10-081-9/+6
| | | | | | | | | | | | | | | | | | | | The function now returns `Result<Vec<InvalidKeystoreEntry<'a>>>`
| * | | | arti: keys: Add integrity check for empty expired_entrieshjrgrn2025-10-081-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a check in `run_check_integrity` to verify that the `expired_entries` collection is empty after processing all registered keystores. This should always be true, as all expired entries are expected to be removed during iteration. If not, it indicates a bug.
| * | | | arti: keys: Introduce InvalidKeystoreEntry and InvalidKeystoreEntries structshjrgrn2025-10-081-33/+74
| | | | | | | | | | | | | | | | | | | | | | | | | Replace raw tuples with named structs to reduce type complexity and improve code clarity and maintainability.
| * | | | arti: keys: Remove `filter` in favor of `retain` in `run_check_integrity`hjrgrn2025-10-081-11/+9
| | | | |
| * | | | arti: keys: Add comment explaining expired entry handling in ↵hjrgrn2025-10-081-0/+2
| | | | | | | | | | | | | | | | | | | | `run_check_integrity`
| * | | | arti: keys: Improve `run_check_integrity` functionhjrgrn2025-10-081-11/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Fix bug where expired keys from one keystore were incorrectly associated with all keystores - Remove unnecessary clone
| * | | | arti: keys: Adapt `maybe_remove_invalid_entries` to updated ↵hjrgrn2025-10-081-14/+19
| | | | | | | | | | | | | | | | | | | | `run_check_integrity`
| * | | | arti: keys: Refactor function `display_invalid_keystore_entries`hjrgrn2025-10-081-32/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Add `display_invalid_keystore_entries` helper function `print_check_integrity_incipit` - Add `display_invalid_keystore_entries` comment
| * | | | arti: keys: Implement `display_invalid_keystore_entries`hjrgrn2025-10-081-2/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add initial functional implementation of `display_invalid_keystore_entries`, which processes a list of invalid keystore entries grouped by `KeystoreId` and displays them with associated error messages.
| * | | | arti: keys: Refactor `display_invalid_keystore_entries`hjrgrn2025-10-081-35/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Create the skeletal version of the new `display_invalid_keystore_entries` function and adapt `run_check_integrity` to use it. The function now takes a slice of pairs, each containing a `KeystoreId` and a vector of invalid keystore entries along with their error messages, and processes all entries internally by iterating over each keystore, instead of being called once per keystore.
| * | | | arti: keys: Refactor run_check_integrity to use keystores with IDshjrgrn2025-10-081-28/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the function worked with a flat `Vec<KeystoreEntryResult<KeystoreEntry>>`. Now, it uses a structured `Vec<(KeystoreId, Vec<KeystoreEntryResult<KeystoreEntry>>)>`, grouping entries by keystore. This makes it easier to track which keystore each entry belongs to, and prepares the code for upcoming improvements.
* | | | | Merge branch 'netdoc-build-feat-docs' into 'main'Nick Mathewson2025-10-081-3/+12
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | tor-netdoc: Deprecate `build_docs` and tidy feature docs See merge request tpo/core/arti!3340
| * | | | tor-netdoc: Deprecate the netdoc "builder pattern"Ian Jackson2025-10-071-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're going to eventually implement the traits in `src/build.rs` for the network document types. But, this feature mainly covers `doc/*build*`. That (a) isn't used in-tree (b) isn't really needed now that the fields are all pub (c) is currently marked experimental.
| * | | | tor-netdoc: Document the `hs-client` and `hs-service` featuresIan Jackson2025-10-071-0/+7
| | | | | | | | | | | | | | | | | | | | And mention that there are experimental and undocumented features.
* | | | | tor-netdoc: Add semver.md for parsing/printing changesIan Jackson2025-10-081-0/+4
| | | | |
* | | | | tor-netdoc: Explain that Ignored can't be used as an argumentIan Jackson2025-10-081-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is FromStr (which is fine). Which emant it was ItemArgumentParseable but but it can't be Display so it can't be NormalItemArgument. This illuminates the fact that it shouldn't really be ItemArgumentParseable since we're going to want all types that are in netdoc structs to be both parseable and printable.
* | | | | tor-netdoc: replace impl_item_argument_as_display with NormalItemArgumentIan Jackson2025-10-081-26/+8
| | | | |
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 23:30:41 +0000