| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| | * | | rpc-connect: remove todo; confirm that we do want to mkdir. | Nick Mathewson | 2025-01-27 | 1 | -1/+1 | |
| | | | | ||||||
| | * | | rpc-connect: Detect and decline connpts with invalid "auth" feields | Nick Mathewson | 2025-01-27 | 3 | -20/+18 | |
| | | | | ||||||
| | * | | rpc-connect: Abort on misformed cookie file, and explain why. | Nick Mathewson | 2025-01-27 | 1 | -6/+3 | |
| | | | | ||||||
| | * | | rpc-connect: Use file_access() API, and permit symlinks. | Nick Mathewson | 2025-01-27 | 2 | -17/+20 | |
| | |/ | ||||||
| * | | tor-proto: Use SENDME_TAG_LEN constant instead of magic value. | Gabriela Moldovan | 2025-01-28 | 2 | -7/+8 | |
| | | | ||||||
| * | | tor-proto: Use CircTag::try_from for clarity. | Gabriela Moldovan | 2025-01-28 | 2 | -7/+12 | |
| | | | ||||||
| * | | tor-proto: Use CircTag instead of raw byte slice. | Gabriela Moldovan | 2025-01-28 | 2 | -7/+6 | |
| | | | ||||||
| * | | tor-proto: Move stream msg delivery to a separate function (fmt). | Gabriela Moldovan | 2025-01-28 | 1 | -33/+32 | |
| | | | ||||||
| * | | tor-proto: Move stream msg delivery to a separate function. | Gabriela Moldovan | 2025-01-28 | 1 | -33/+47 | |
| | | | | | | | | | | | | | | | This is mostly code motion (I recommend reviewing with `--color-moved`). The code is intentionally misindented to make diffing easier. A future commit will fix the indentation. | |||||
| * | | tor-proto: Move stream ID extraction out of handle_relay_msg(). | Gabriela Moldovan | 2025-01-28 | 1 | -9/+18 | |
| | | | ||||||
| * | | tor-proto: Wrap an extra long lone. | Gabriela Moldovan | 2025-01-28 | 1 | -1/+5 | |
| | | | ||||||
| * | | tor-proto: Use continue instead of () for clarity. | Gabriela Moldovan | 2025-01-28 | 1 | -1/+1 | |
| | | | ||||||
| * | | tor-proto: Adjust handle_cell() docs. | Gabriela Moldovan | 2025-01-28 | 1 | -1/+1 | |
| | | | ||||||
| * | | tor-proto: Split handle_relay_cell(). | Gabriela Moldovan | 2025-01-28 | 1 | -4/+15 | |
| | | | ||||||
| * | | tor-proto: Split out send_relay_cell(). | Gabriela Moldovan | 2025-01-28 | 2 | -13/+28 | |
| | | | ||||||
| * | | tor-proto: Group imports. | Gabriela Moldovan | 2025-01-28 | 1 | -2/+1 | |
| | | | ||||||
| * | | tor-proto: Replace fully-qualified paths with use. | Gabriela Moldovan | 2025-01-28 | 1 | -6/+6 | |
| | | | | | | | | | For readability. | |||||
| * | | tor-proto: Derive Default for MutableState. | Gabriela Moldovan | 2025-01-28 | 2 | -4/+2 | |
| | | | | | | | | | | | This enables us to get rid of two lines from the circuit reactor constructor. | |||||
| * | | Merge branch 'strongrefs_are_not_deduped' into 'main' | Nick Mathewson | 2025-01-28 | 3 | -8/+10 | |
| |\ \ | | | | | | | | | | | | | rpc: Clean up comments surrounding strong references See merge request tpo/core/arti!2741 | |||||
| | * | | rpc: Clean up comments surrounding strong references | Nick Mathewson | 2025-01-27 | 3 | -8/+10 | |
| | |/ | | | | | | | They used to be deduplicated, but they haven't been for a while. | |||||
| * | | rpcbase: Enforce validity on error datum keywords. | Nick Mathewson | 2025-01-27 | 2 | -4/+12 | |
| | | | ||||||
| * | | rpcbase: Make recognized namespace list optional. | Nick Mathewson | 2025-01-27 | 2 | -8/+11 | |
| | | | ||||||
| * | | rpcbase: Move is_valid_rpc_identifier to crate root. | Nick Mathewson | 2025-01-27 | 2 | -91/+89 | |
| | | | ||||||
| * | | rpc: Rename InvalidMethodName to InvalidRpcIdentifier. | Nick Mathewson | 2025-01-27 | 3 | -17/+19 | |
| | | | | | | | | | We're about to use this error type for other things too. | |||||
| * | | Remove RPC TODO about bypass_method_dispatch method. | Nick Mathewson | 2025-01-27 | 1 | -6/+1 | |
| |/ | | | | | | There was formally a redundant method of this name, which could get out-of-sync with invoke_without_dispatch. But now that method is gone, and this TODO is wrong. | |||||
| * | Fix not(unix) build error introduced in cb090c7b4c. | Alexander Hansen Færøy | 2025-01-26 | 1 | -2/+2 | |
| | | | | | | | | This patch fixes a relatively harmless build error introduced for non-unix builds. Additional comma introduced in b5aa8f7a88. | |||||
| * | Merge branch 'rpc-missing-dir' into 'main' | Nick Mathewson | 2025-01-23 | 1 | -8/+16 | |
| |\ | | | | | | | | | rpc: Tolerate NotFound on configured connect point directory. See merge request tpo/core/arti!2735 | |||||
| | * | connpts: Document behavior on nonexistent directory | Nick Mathewson | 2025-01-23 | 1 | -0/+2 | |
| | | | ||||||
| | * | rpc: Tolerate NotFound on configured connect point directory. | Nick Mathewson | 2025-01-23 | 1 | -8/+14 | |
| | | | | | | | | | | | | | | | | | If Arti tries to bind to a directory of connect points, and that directory isn't there, the right behavior is to treat the directory as if it were empty. Otherwise, the user would have to create the default connect point directory (as empty) before Arti would start. | |||||
| * | | Merge branch 'avoid_execute_internal_ok' into 'main' | Nick Mathewson | 2025-01-23 | 4 | -31/+69 | |
| |\ \ | | | | | | | | | | | | | rpclib: Avoid overuse of execute_internal_ok. See merge request tpo/core/arti!2730 | |||||
| | * | | rpclib: More explanations about internal method usage. | Nick Mathewson | 2025-01-23 | 1 | -3/+5 | |
| | | | | ||||||
| | * | | arti-rpc-client-core: Rename Authentication{Rejected=>Failed} | Nick Mathewson | 2025-01-23 | 3 | -9/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | Also change corresponding message. This way, it will be clear that we're just reporting that Arti gave us an error—not that the error necessarily means that the authentication itself was "wrong". | |||||
| | * | | rpclib: Avoid overuse of execute_internal_ok. | Nick Mathewson | 2025-01-23 | 4 | -24/+60 | |
| | |/ | | | | | | | | | | | | | | | | | | | | | The execute_internal_ok method converts every error response into an internal error; as such, it's only appropriate when there is no way for a well-behaved Arti instance to give an error response. But we had been using it in a few places where errors were possible under other circumstances. This commit fixes that behavior, and adds documentation to help avoid it. | |||||
| * | | Merge branch 'rpc-todos-1' into 'main' | Nick Mathewson | 2025-01-23 | 2 | -20/+3 | |
| |\ \ | | | | | | | | | | | | | rpc: Resolve a couple of dead code TODOs See merge request tpo/core/arti!2731 | |||||
| | * | | rpcserver: remove dead code exception in objmap.rs | Nick Mathewson | 2025-01-22 | 1 | -3/+1 | |
| | | | | ||||||
| | * | | rpcserver: remove dead code in codecs.rs | Nick Mathewson | 2025-01-22 | 1 | -17/+2 | |
| | | | | ||||||
| * | | | arti: Make Rpc argument unconditional when constructing socks proxy | Nick Mathewson | 2025-01-23 | 6 | -33/+43 | |
| | | | | | | | | | | | | | | | | | | | Formerly this was a conditional method argument, which is a huge antipattern. Now it is unconditionally present, as `Option<T>` for a type that is uninhabited when RPC isn't supported. | |||||
| * | | | arti::socks: Re-wrap a section. | Nick Mathewson | 2025-01-23 | 1 | -2/+3 | |
| | | | | | | | | | | | | | | | | rust-analyzer keeps re-wrapping this piece for me, even though rustfmt doesn't complain. | |||||
| * | | | arti: remove an obsolete rpc todo. | Nick Mathewson | 2025-01-23 | 1 | -1/+0 | |
| | | | | | | | | | | | | | Information _is_ passed to the RpcMgr, via the argument to new_connection. | |||||
| * | | | arti: remove an obsolete rpc todo. | Nick Mathewson | 2025-01-23 | 1 | -1/+0 | |
| | | | | | | | | | | | | | | | | The RpcMgr does indirectly hold a reference to the client, via its make_session argument. | |||||
| * | | | arti: remove an obsolete rpc todo. | Nick Mathewson | 2025-01-23 | 1 | -1/+0 | |
| | | | | | | | | | | | | | We _do_ have error detection from this function, and have for ages. | |||||
| * | | | arti: Remove old workaround for runtime selection under RPC. | Nick Mathewson | 2025-01-23 | 1 | -6/+1 | |
| | |/ |/| | | | | | | | This was necessary before we had support for implementing RPC methods on generic types. | |||||
| * | | Merge branch 'dev/cve/mistrust-doc' into 'main' | Nick Mathewson | 2025-01-23 | 1 | -0/+12 | |
| |\ \ | | | | | | | | | | | | | tor-config: Improve mistrust documentation See merge request tpo/core/arti!2727 | |||||
| | * | | tor-config: Improve mistrust documentation | Clara Engler | 2025-01-23 | 1 | -0/+12 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | This commit improves the documentation for `ConfigurationSources::set_mistrust`, by explaining that this option is unrelated to the paths defined within the configuration file itself, referring to the `storage.permissions.dangerously_trust_everyone` option. | |||||
| * | | | arti-rpc-client-core: Use EmptyReply instead of EmptyResponse. | Gabriela Moldovan | 2025-01-23 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | It looks like !2729 and !2722 raced with each other, because we're still using the old name for `EmptyReply` (and so `arti-rpc-client-core` doesn't currently compile on `main`). | |||||
| * | | | Merge branch 'rpc-cancel-2' into 'main' | Nick Mathewson | 2025-01-23 | 9 | -49/+391 | |
| |\ \ \ | |_|/ |/| | | | | | | | | | | | | | | rpc: Implement request cancellation Closes #818 See merge request tpo/core/arti!2722 | |||||
| | * | | Document more that cancel is uncancellable. | Nick Mathewson | 2025-01-22 | 1 | -0/+2 | |
| | | | | ||||||
| | * | | rpc: Correct RPC error code for "RequestNotFound". | Nick Mathewson | 2025-01-22 | 1 | -1/+4 | |
| | | | | ||||||
| | * | | cancel: Distinguish the internal-error case for double-cancel. | Nick Mathewson | 2025-01-22 | 1 | -2/+23 | |
| | | | | ||||||
| | * | | cancel: Document deadlock/panic issue and how to avoid it. | Nick Mathewson | 2025-01-22 | 1 | -2/+19 | |
| | | | | ||||||
