summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
* rpcserver: Improve conversion of authentication error.Nick Mathewson2025-01-282-7/+14
|
* rpc: Remove auth:query.Nick Mathewson2025-01-281-53/+0
| | | | | Nothing uses it; its role in negotiation has been replaced by the connect-point design.
* rpcserver: Remove a stale TODO about ConnectionId.Nick Mathewson2025-01-281-3/+0
| | | | Other parts of the crate no longer look at the .0 field directly.
* Merge branch 'rpc-references-cleanup' into 'main'Nick Mathewson2025-01-286-183/+204
|\ | | | | | | | | rpc: Move support for weak references behind an experimental feature See merge request tpo/core/arti!2742
| * rpc: Move support for weak references behind an experimental featureNick Mathewson2025-01-276-183/+204
| | | | | | | | | | We haven't decided how these should work (see #868), so having them present by default is a bad idea.
* | Merge branch 'tor-rpc-connect-todos' into 'main'Nick Mathewson2025-01-287-70/+106
|\ \ | | | | | | | | | | | | tor-rpc-connect: Address remaining "TODO RPC" notes. See merge request tpo/core/arti!2743
| * | fs-mistrust: document that follow_final_links is not insecureNick Mathewson2025-01-281-0/+4
| | | | | | | | | | | | | | | Since it makes an exception, we need to be clear about the exceptions that it _doesn't_ make.
| * | fs-mistrust: link to documentation about "obeying constraints"Nick Mathewson2025-01-281-5/+5
| | | | | | | | | | | | | | | | | | Since "obeying the constraints of a FileAccess" is a term of art, this commit introduces links from the places where it is used to the place where it is defined.
| * | rpc-connect: Remove remaining TODO RPCsNick Mathewson2025-01-271-4/+1
| | | | | | | | | | | | I have checked the relevant code, and it seems okay.
| * | rpc-connect: Make Connect::validate more straightforwardNick Mathewson2025-01-271-11/+12
| | |
| * | rpc-connect: check that all paths inside a connpt are absolute.Nick Mathewson2025-01-271-13/+49
| | |
| * | rpc-connect: remove todo; confirm that we do want to mkdir.Nick Mathewson2025-01-271-1/+1
| | |
| * | rpc-connect: Detect and decline connpts with invalid "auth" feieldsNick Mathewson2025-01-273-20/+18
| | |
| * | rpc-connect: Abort on misformed cookie file, and explain why.Nick Mathewson2025-01-271-6/+3
| | |
| * | rpc-connect: Use file_access() API, and permit symlinks.Nick Mathewson2025-01-272-17/+20
| |/
* | tor-proto: Use SENDME_TAG_LEN constant instead of magic value.Gabriela Moldovan2025-01-282-7/+8
| |
* | tor-proto: Use CircTag::try_from for clarity.Gabriela Moldovan2025-01-282-7/+12
| |
* | tor-proto: Use CircTag instead of raw byte slice.Gabriela Moldovan2025-01-282-7/+6
| |
* | tor-proto: Move stream msg delivery to a separate function (fmt).Gabriela Moldovan2025-01-281-33/+32
| |
* | tor-proto: Move stream msg delivery to a separate function.Gabriela Moldovan2025-01-281-33/+47
| | | | | | | | | | | | | | This is mostly code motion (I recommend reviewing with `--color-moved`). The code is intentionally misindented to make diffing easier. A future commit will fix the indentation.
* | tor-proto: Move stream ID extraction out of handle_relay_msg().Gabriela Moldovan2025-01-281-9/+18
| |
* | tor-proto: Wrap an extra long lone.Gabriela Moldovan2025-01-281-1/+5
| |
* | tor-proto: Use continue instead of () for clarity.Gabriela Moldovan2025-01-281-1/+1
| |
* | tor-proto: Adjust handle_cell() docs.Gabriela Moldovan2025-01-281-1/+1
| |
* | tor-proto: Split handle_relay_cell().Gabriela Moldovan2025-01-281-4/+15
| |
* | tor-proto: Split out send_relay_cell().Gabriela Moldovan2025-01-282-13/+28
| |
* | tor-proto: Group imports.Gabriela Moldovan2025-01-281-2/+1
| |
* | tor-proto: Replace fully-qualified paths with use.Gabriela Moldovan2025-01-281-6/+6
| | | | | | | | For readability.
* | tor-proto: Derive Default for MutableState.Gabriela Moldovan2025-01-282-4/+2
| | | | | | | | | | This enables us to get rid of two lines from the circuit reactor constructor.
* | Merge branch 'strongrefs_are_not_deduped' into 'main'Nick Mathewson2025-01-283-8/+10
|\ \ | | | | | | | | | | | | rpc: Clean up comments surrounding strong references See merge request tpo/core/arti!2741
| * | rpc: Clean up comments surrounding strong referencesNick Mathewson2025-01-273-8/+10
| |/ | | | | | | They used to be deduplicated, but they haven't been for a while.
* | rpcbase: Enforce validity on error datum keywords.Nick Mathewson2025-01-272-4/+12
| |
* | rpcbase: Make recognized namespace list optional.Nick Mathewson2025-01-272-8/+11
| |
* | rpcbase: Move is_valid_rpc_identifier to crate root.Nick Mathewson2025-01-272-91/+89
| |
* | rpc: Rename InvalidMethodName to InvalidRpcIdentifier.Nick Mathewson2025-01-273-17/+19
| | | | | | | | We're about to use this error type for other things too.
* | Remove RPC TODO about bypass_method_dispatch method.Nick Mathewson2025-01-271-6/+1
|/ | | | | | There was formally a redundant method of this name, which could get out-of-sync with invoke_without_dispatch. But now that method is gone, and this TODO is wrong.
* Fix not(unix) build error introduced in cb090c7b4c.Alexander Hansen Færøy2025-01-261-2/+2
| | | | | | | This patch fixes a relatively harmless build error introduced for non-unix builds. Additional comma introduced in b5aa8f7a88.
* Merge branch 'rpc-missing-dir' into 'main'Nick Mathewson2025-01-231-8/+16
|\ | | | | | | | | rpc: Tolerate NotFound on configured connect point directory. See merge request tpo/core/arti!2735
| * connpts: Document behavior on nonexistent directoryNick Mathewson2025-01-231-0/+2
| |
| * rpc: Tolerate NotFound on configured connect point directory.Nick Mathewson2025-01-231-8/+14
| | | | | | | | | | | | | | | | If Arti tries to bind to a directory of connect points, and that directory isn't there, the right behavior is to treat the directory as if it were empty. Otherwise, the user would have to create the default connect point directory (as empty) before Arti would start.
* | Merge branch 'avoid_execute_internal_ok' into 'main'Nick Mathewson2025-01-234-31/+69
|\ \ | | | | | | | | | | | | rpclib: Avoid overuse of execute_internal_ok. See merge request tpo/core/arti!2730
| * | rpclib: More explanations about internal method usage.Nick Mathewson2025-01-231-3/+5
| | |
| * | arti-rpc-client-core: Rename Authentication{Rejected=>Failed}Nick Mathewson2025-01-233-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | Also change corresponding message. This way, it will be clear that we're just reporting that Arti gave us an error—not that the error necessarily means that the authentication itself was "wrong".
| * | rpclib: Avoid overuse of execute_internal_ok.Nick Mathewson2025-01-234-24/+60
| |/ | | | | | | | | | | | | | | | | | | | | The execute_internal_ok method converts every error response into an internal error; as such, it's only appropriate when there is no way for a well-behaved Arti instance to give an error response. But we had been using it in a few places where errors were possible under other circumstances. This commit fixes that behavior, and adds documentation to help avoid it.
* | Merge branch 'rpc-todos-1' into 'main'Nick Mathewson2025-01-232-20/+3
|\ \ | | | | | | | | | | | | rpc: Resolve a couple of dead code TODOs See merge request tpo/core/arti!2731
| * | rpcserver: remove dead code exception in objmap.rsNick Mathewson2025-01-221-3/+1
| | |
| * | rpcserver: remove dead code in codecs.rsNick Mathewson2025-01-221-17/+2
| | |
* | | arti: Make Rpc argument unconditional when constructing socks proxyNick Mathewson2025-01-236-33/+43
| | | | | | | | | | | | | | | | | | Formerly this was a conditional method argument, which is a huge antipattern. Now it is unconditionally present, as `Option<T>` for a type that is uninhabited when RPC isn't supported.
* | | arti::socks: Re-wrap a section.Nick Mathewson2025-01-231-2/+3
| | | | | | | | | | | | | | | rust-analyzer keeps re-wrapping this piece for me, even though rustfmt doesn't complain.
* | | arti: remove an obsolete rpc todo.Nick Mathewson2025-01-231-1/+0
| | | | | | | | | | | | Information _is_ passed to the RpcMgr, via the argument to new_connection.