summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
* Bump minor version of fs-mistrustIan Jackson2025-02-0714-14/+14
| | | | Fixes #1841.
* Merge branch 'versions' into 'main'Ian Jackson2025-02-0649-454/+454
|\ | | | | | | | | Version bumps for 1.4.0 See merge request tpo/core/arti!2773
| * Version bumps to 0.27.0Ian Jackson2025-02-0648-437/+437
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See Release.md. maint/list_crates | grep -P '^tor-|^arti-' | xargs -n1 nailing-cargo -Eu set-version --bump minor -p This completes the version bumps. The report of changed crates, before I started the release work, is: $ maint/changed_crates -v "arti-v$LAST_VERSION" oneshot-fused-workaround: No change. slotmap-careful: No change. test-temp-dir: No change. fslock-guard: No change. hashx: No change. equix: No change. tor-basic-utils: No change. caret: No change. fs-mistrust safelog: No change. retry-error: No change. tor-error tor-general-addr: No change. tor-geoip: No change. tor-rtcompat tor-rtmock tor-async-utils tor-config tor-config-path tor-rpc-connect tor-log-ratelim: No change. tor-rpcbase tor-memquota: No change. tor-units tor-llcrypto: No change. tor-protover: No change. tor-bytes tor-checkable: No change. tor-cert tor-key-forge tor-hscrypto: No change. tor-socksproto: No change. tor-linkspec: No change. tor-cell: No change. tor-proto tor-netdoc: No change. tor-consdiff: No change. tor-netdir tor-relay-selection: No change. tor-persist tor-chanmgr tor-ptmgr: No change. tor-guardmgr: No change. tor-circmgr tor-dirclient: No change. tor-dirmgr: No change. tor-keymgr tor-hsclient tor-hsservice tor-hsrproxy: No change. tor-relay-crypto arti-client arti-relay arti-rpcserver arti arti-rpc-client-core $
| * Bump arti crate version to 1.4.0Ian Jackson2025-02-063-3/+3
| | | | | | | | | | | | And the in-tree dependencies. cargo set-version --offline --bump minor -p fs-mistrust
| * fs-mistrust: bump minor version, and in-tree depsIan Jackson2025-02-0614-14/+14
| | | | | | | | | | | | | | | | | | | | | | | | There are new features. cargo set-version --offline --bump minor -p fs-mistrust Actually, I have discovered by diffing that some methods now take `&self` where previously they took `self`. This will need a further bump to the fs-mistrust version and a fix to the changelog. I will do that. Filed blocker ticket #1841 for it.
* | Merge branch 'fixup-features' into 'main'Ian Jackson2025-02-068-2/+16
|\ \ | | | | | | | | | | | | Run maint/fixup-features for release See merge request tpo/core/arti!2771
| * | Fix Cargo.toml features formattingIan Jackson2025-02-067-7/+18
| | | | | | | | | | | | Manual line breaks which fixup-features doesn't know how to add.
| * | Add some missing "full" featuresIan Jackson2025-02-068-7/+10
| |/ | | | | | | | | | | | | Precisely the results of maint/fixup-features. Some crates end up with slightly odd formatting, which I will fix in a moment.
* | Merge branch 'file-watcher' into 'main'Ian Jackson2025-02-061-16/+22
|\ \ | | | | | | | | | | | | file watcher tidying See merge request tpo/core/arti!2763
| * | file_watcher: Remove some now-unused thingsIan Jackson2025-02-061-8/+10
| | |
| * | file_watcher: Use .borrow_mut and sync MutexIan Jackson2025-02-061-10/+4
| | |
| * | file_watcher: Add some commentary about Event semanticsIan Jackson2025-02-061-0/+10
| |/
* | Merge branch 'key-file-macro' into 'main'gabi-2502025-02-064-60/+102
|\ \ | |/ |/| | | | | | | | | tor-keymgr: Define the test key constants using a macro. Closes #1396 See merge request tpo/core/arti!2764
| * tor-keymgr: Use @ to annotate internal macro branches.Gabriela Moldovan2025-02-061-3/+3
| |
| * tor-keymgr: Define the test key constants using a macro.Gabriela Moldovan2025-02-062-42/+84
| | | | | | | | Closes #1396
| * tor-keymgr: Rename test constants to match file names.Gabriela Moldovan2025-02-063-30/+30
| | | | | | | | Part of #1396
* | tor-proto: remove `use asynchronous_codec as futures_codec`Neel Chauhan2025-02-063-18/+18
| | | | | | | | Closes #1690.
* | tor-proto: Make ControlHandler::handler return non-optional result.Gabriela Moldovan2025-02-062-14/+14
| | | | | | | | | | | | The commands for which the function returned `Ok(None)` have been refactored into `CtrlCmd`, so we no longer need `handle()` to return an `Option`.
* | tor-proto: Turn some CtrlMsgs into CtrlCmds.Gabriela Moldovan2025-02-063-147/+166
| | | | | | | | | | | | | | All `CtrlMsg`s to which the reactor did not respond by sending a cell down the channel are now `CtrlCmd`s. Most of this is code motion, best reviewed with `--color-moved`.
* | tor-proto: Make shutdown a CtrlCmd.Gabriela Moldovan2025-02-063-26/+58
|/
* Merge branch 'update' into 'main'Ian Jackson2025-02-066-6/+6
|\ | | | | | | | | Dependency updates (part of release prep) See merge request tpo/core/arti!2767
| * Upgrade to dirs 6Ian Jackson2025-02-052-2/+2
| | | | | | | | No code changes needed.
| * Upgrade to downcast-rs 2Ian Jackson2025-02-054-4/+4
| | | | | | | | No code changes needed.
* | Merge branch 'reactor-refactor-1' into 'main'gabi-2502025-02-058-432/+339
|\ \ | |/ |/| | | | | Various refactor of tor-proto circuit reactor See merge request tpo/core/arti!2765
| * proto: Fix feature gated importDavid Goulet2025-02-041-2/+5
| | | | | | | | Signed-off-by: David Goulet <[email protected]>
| * proto: Move the begin cell handling into CircHopDavid Goulet2025-02-042-47/+38
| | | | | | | | | | | | | | Move the BEGIN cell handling into CircHop following the previous commit that move more code into CircHop. Signed-off-by: David Goulet <[email protected]>
| * proto: Move the close stream action into CircHopDavid Goulet2025-02-041-51/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the first commit of a series to make CircHop own the code of its related actions. This commit moves the "close stream" code into CircHop now owning the action and offloading the Reactor code. In order to do this, and future changes like for example handling BEGIN, the CircHop needs to be aware of its hop number. This change also allows us to add the hop number to logging. It also copies the reactor unique ID to each hop for logging purposes. Future commit will continue to move more code into CircHop. Signed-off-by: David Goulet <[email protected]>
| * proto: Remove ConversationInHandlerDavid Goulet2025-02-048-125/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is unused but most importantly it allows any RELAY cell to be sent from anywhere in the code which is really not desirable because it is skipping congestion control. It also allows us to remove the `control_tx` from the reactor which is one less channel to track/understand/think about. This opens up the door to all sorts of problems especially side channel that can be exploited if we are not careful. We can always bring this back if we need it but for now, it is unused and allows us to remove the `CtrlMsg::SendRelayCell` control message. No code behavior change. Signed-off-by: David Goulet <[email protected]>
| * proto: Introduce a reactor ControlHandlerDavid Goulet2025-02-042-223/+248
| | | | | | | | | | | | | | | | | | | | | | | | | | This object only mission is to handle a control message (CtrlMsg). It encapsulates a reference to the reactor and its lifetime is only the time it takes to handle the message. Main goal of this is to try to reduce reactor.rs size into logical containers. No code behavior change. Signed-off-by: David Goulet <[email protected]>
* | rpclib: Improve output for ConnectFailureNick Mathewson2025-02-042-2/+58
| | | | | | | | | | | | | | We want to explain better what has happened, not only with the final fatal error, but with any nonfatal errors that occurred in the middle. Closes #1826.
* | rpclib: Include sources when formatting FFI errors.Nick Mathewson2025-02-041-2/+14
| | | | | | | | Closes #1650.
* | rpclib: Obey error Display convention wrt sources.Nick Mathewson2025-02-044-26/+25
| | | | | | | | | | | | | | In general, we try to obey the convention that an error's Display method does not display that error's sources. Part of #1650.
* | tor-error: Implement ErrorReport for dyn StdError + 'static.Nick Mathewson2025-02-041-0/+6
| | | | | | | | This is needed to Report on the output of `StdError::source`.
* | tor-error: Refor to the correct trait.Nick Mathewson2025-02-041-1/+1
|/
* rpclib: Move socketpair to a testing module; use it in llconn testsNick Mathewson2025-02-034-33/+39
|
* rpclib: In tests, use an ersatz socketpair on windows.Nick Mathewson2025-02-032-3/+35
| | | | | | | | | | | | | | | Fixes #1831. I'm doing this because switching from the socketpair crate to an ersatz connect-to-localhost socketpair made the test pass. My windows skills are weak, but it appears possible that you aren't supposed to simultaneously have a blocking ReadFile and a blocking WriteFile to a named pipe from separate threads? At least, that's consistent with our findings in !2758. I first saw this hack in perl, when I needed it in 2003. I am displeased that it is still apparently needed in 2025.
* rpclib: make conn::complex use fewer iterations.Nick Mathewson2025-02-031-1/+1
| | | | This was the slowest test in our suite.
* Merge branch 'test_extend_ntor-fix' into 'main'David Goulet2025-02-031-1/+1
|\ | | | | | | | | | | | | tor-proto: Ensure rx end of chan reactor output sink is not dropped in test. Closes #1832 See merge request tpo/core/arti!2760
| * tor-proto: Ensure rx end of chan reactor output sink is not dropped in test.Gabriela Moldovan2025-02-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This hopefully fixes #1832. I haven't been able to repro the failure from #1832 locally, but judging from the logs, I suspect it's triggered by interleavings like: - `extend_fut` executes up until `circ.extend_ntor(..).await`, where it's blocked `await`ing a completion notification from the circuit reactor - `reply_fut` starts running: * `CircuitExtender` installs a meta-handler in the circuit reactor, and waits for an `EXTENDED2` cell * `test_extend()` reads a cell from the receiving end of the fake channel's output sink (`rx`) * `test_extend()` sends the `EXTENDED2` cell to the circuit reactor over `CircuitRxSender` * `rx` is dropped - `reply_fut` completes - in the channel reactor's `run_once()`, `select_biased!` resolves to an error, because the receiving end of the `output` sink (`rx`) was dropped. The reactor logs `got sink error: SendError { kind: Disconnected }` (see [`SendError`]), and exits - the circuit reactor exits too, because the receiving end of its `chan_sender` (which was in the channel reactor) was dropped Returning the `rx` of the fake channel's output sink from `reply_fut` *should* stop it from being dropped, and fix #1832. [`SendError`]: https://docs.rs/futures/latest/futures/channel/mpsc/struct.SendError.html#method.is_disconnected
* | Merge branch 'ahf/win32-rpc-fixes' into 'main'Nick Mathewson2025-02-031-1/+4
|\ \ | |/ |/| | | | | rpc: Fix test builds on Windows. See merge request tpo/core/arti!2756
| * rpc: Fix test builds on Windows.Alexander Hansen Færøy2025-01-301-1/+4
| |
* | Merge branch 'rpc_document_internal_optimism' into 'main'Nick Mathewson2025-01-305-29/+23
|\ \ | | | | | | | | | | | | | | | | | | rpc: Document what is actually going on with stream optimism. Closes #1583 See merge request tpo/core/arti!2753
| * | socks.rs: Update documentation; RpcDataStream has been renamed.Nick Mathewson2025-01-301-9/+5
| | |
| * | rpc: Correct API documentation about optimismNick Mathewson2025-01-304-18/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Our documentation had dated to an older version of our RPC stream code, where all streams were automatically optimistic. But as explained, our use of "optimistic"ness in RPC stream code is now purely internal, to make it possible to get an DataStreamCtrl. This isn't user-visible in our rpc_conn_open_stream code. Closes #1583
| * | rpc: Document what is actually going on with stream optimism.Nick Mathewson2025-01-301-2/+17
| | | | | | | | | | | | | | | | | | | | | | | | In brief: we _do_ correct implement correct optimistic vs nonoptimistic behavior for RPC streams. Only our documentation was wrong. Subsequent commits will fix our documentation more. See #1583.
* | | Merge branch 'proto-datactl-api-fixes2' into 'main'Nick Mathewson2025-01-304-35/+38
|\ \ \ | | | | | | | | | | | | | | | | tor-proto: Tweak StreamCtrl APIs for RPC. See merge request tpo/core/arti!2755
| * | | proto: deprecate DataStream::circuitNick Mathewson2025-01-301-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method is experimental, so no semver note is needed. It is redundant with `client_stream_ctrl()?.circuit()?`. (The name and the unconditional return type of this method are probably an error.)
| * | | proto: Rename (experimental) DataStream functions for ctrl accessNick Mathewson2025-01-302-7/+11
| | | | | | | | | | | | | | | | | | | | Since these return a client-specific type, they need a client-specific name before we can stabilize them for RPC.
| * | | proto: Rename ClientDataStreamCtrl::{is_open=>is_connected}Nick Mathewson2025-01-301-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Semantically, the new name matches the behavior much better. (A stream could well count as open if we had sent a RESOLVE but not received a RESOLVED, so we might someday want to have an `is_open` defined for _all_ streams, not just data streams.)
| * | | proto: Rename DataStreamCtrl to ClientDataStreamCtrlNick Mathewson2025-01-303-22/+22
| | | | | | | | | | | | | | | | | | | | | | | | The API for this type, and the fact that it implements ClientStreamCtrl unconditionally, means that it is only for client DataStreams.