summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | proto: Clarify applicability of ClientStreamCtrl.Nick Mathewson2025-01-301-4/+2
| | |/ | |/|
* | | Merge branch 'reactor-stuff' into 'main'David Goulet2025-01-3010-760/+1187
|\ \ \ | |/ / |/| | | | | | | | tor-proto: Rewrite circuit reactor run_once() loop to use select!. See merge request tpo/core/arti!2747
| * | tor-proto: Remove outdated docs about AsyncMutex use.Gabriela Moldovan2025-01-301-7/+0
| | |
| * | tor-proto: Remove unnecessary time_prov argument.David Goulet2025-01-301-28/+17
| | |
| * | tor-proto: Remove unnecessary Mutex around chan_sender.David Goulet2025-01-301-44/+20
| | |
| * | tor-proto: Resolve clippy warning about mut refs in debug_assert.Gabriela Moldovan2025-01-291-6/+7
| | | | | | | | | | | | | | | | | | It's unclear to me why this warning didn't fire before! The the circuit reactor had this exact same `debug_assert` prior to the refactoring, taking a mutable reference to the `StreamMap`.
| * | tor-proto: Add a clippy allow and corresponding TODO.Gabriela Moldovan2025-01-291-0/+1
| | |
| * | tor-proto: Remove now-unused Reactor::send_outbound().Gabriela Moldovan2025-01-291-74/+0
| | | | | | | | | | | | This is now handled in `Reactor::ready_streams_iterator()`.
| * | tor-proto: Remove old Reactor::run_once().Gabriela Moldovan2025-01-291-66/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is replaced by the new `Reactor::run_once()` impl. Note: this removal is in a separate commit to make the diff of the refactoring commits easier to review (the diff between the old and the new impl is not meaningful because the new impl is practically a rewrite).
| * | tor-proto: Remove now-unused CellStatus enum.Gabriela Moldovan2025-01-291-9/+0
| | | | | | | | | | | | This is replaced by `Option<RunOnceCmdInner>`.
| * | tor-proto: Rewrite circuit reactor run_once() loop to use select! (fmt).Gabriela Moldovan2025-01-292-27/+29
| | |
| * | tor-proto: Rewrite circuit reactor run_once() loop to use select!.Gabriela Moldovan2025-01-299-210/+653
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This rewrites the circuit reactor main loop to use `select_biased!` to poll multiple futures simultaneously. The new `run_once()`, like the old, first waits for an initial `CtrlMsg::Create`. Then, it uses a `select_biased!` to poll the `chan_sender` sink and shutdown channel for readiness. When the channel sink is ready, we poll the `control` and `input` channels like before, as well as the new `ready_streams` `Stream` (`ready_streams` is a `futures::Stream` that replaces the previous `send_outbound()` function). Most of the implementation remains unchanged, except the `handle_input`, `handle_cell` and `handle_control` functions no longer send anything on the `chan_sender` channel. Instead, they may do some (synchronous) processing, and send instructions for the remaining work that needs to be done (for example, for writing the cell to the `chan_sender` channel). These instructions are handled at the end of `run_once()`, and are encoded in the `RunOnceCmdInner` enum. What this change does **not** do: * the control channel *still* bypasses congestion control. We could fix this by making the various reactor functions send the `RunOnceCmdInner` commands to `run_once()` via a channel (instead of returning them). This would enable the reactor to stop reading the commands (except for handle `Sendme`, which would be handled separately) if it's blocked on congestion control.
| * | tor-proto: Use SendRelayCell within CtrlMsg::SendRelayCell.Gabriela Moldovan2025-01-293-8/+8
| | |
| * | tor-proto: Add enums for representing run_once() commands.Gabriela Moldovan2025-01-291-0/+104
| | |
| * | tor-proto: Move SendMsgAndInstallHandler handling to a separate function.Gabriela Moldovan2025-01-291-13/+24
| | |
| * | tor-proto: Move the CircuitExtender to a separate module.Gabriela Moldovan2025-01-292-266/+295
| | |
| * | tor-proto: Move CtrlMsg to its own module.Gabriela Moldovan2025-01-292-181/+209
| | | | | | | | | | | | No functional changes, just code motion.
| * | tor-async-utils: Make SometimesUnboundedSink::send_unbounded() pub(crate).Gabriela Moldovan2025-01-291-2/+1
| | | | | | | | | | | | | | | We are about to use this in the circuit reactor (instead of `pollish_send_unbounded`).
* | | fix: fix typosDimitris Apostolou2025-01-3014-20/+20
| |/ |/|
* | Merge branch 'rpc-docs-1' into 'main'Nick Mathewson2025-01-302-20/+104
|\ \ | | | | | | | | | | | | | | | | | | Improve and write a bunch of RPC documentation Closes #1520, #1527, and #1296 See merge request tpo/core/arti!2748
| * | tweak cbindgen documentation.Nick Mathewson2025-01-292-4/+9
| | |
| * | rpclib: Update cbindgen documentation.Nick Mathewson2025-01-292-17/+96
| |/
* | rpclib: Rename ConnPtSource to ConnPtOrigin.Nick Mathewson2025-01-291-11/+11
| |
* | rpclib: Rename WithinDir.{expanded => file}.Nick Mathewson2025-01-291-3/+6
| |
* | rpclib: Move from_env_string_elt onto SearchLocation.Nick Mathewson2025-01-291-4/+6
| |
* | rpclib: Implement accessors for ConnectFailureNick Mathewson2025-01-293-3/+23
| |
* | rpclib: Implement Display for ConnPtDescriptionNick Mathewson2025-01-291-4/+51
| |
* | rpclib: New combined error type for RPC connect failures.Nick Mathewson2025-01-293-9/+52
| | | | | | | | | | This type explains where every error came from, and explains why each declined connect point was declined.
* | rpclib: Pipe connect-point locations through our loading process.Nick Mathewson2025-01-291-22/+77
| |
* | rpclib: Keep track of where each SearchEntry comes from.Nick Mathewson2025-01-291-24/+91
|/ | | | Subsequent commits will pipe this information forward to our errors.
* rpcserver: Remove a stale TODO. (RpcMgr works.)Nick Mathewson2025-01-281-2/+0
|
* rpcserver: Remove stale TODO about authenticationNick Mathewson2025-01-281-3/+0
| | | | (This TODO dates back to the point before we had sessions.)
* rpcserver: Improve conversion of authentication error.Nick Mathewson2025-01-282-7/+14
|
* rpc: Remove auth:query.Nick Mathewson2025-01-281-53/+0
| | | | | Nothing uses it; its role in negotiation has been replaced by the connect-point design.
* rpcserver: Remove a stale TODO about ConnectionId.Nick Mathewson2025-01-281-3/+0
| | | | Other parts of the crate no longer look at the .0 field directly.
* Merge branch 'rpc-references-cleanup' into 'main'Nick Mathewson2025-01-286-183/+204
|\ | | | | | | | | rpc: Move support for weak references behind an experimental feature See merge request tpo/core/arti!2742
| * rpc: Move support for weak references behind an experimental featureNick Mathewson2025-01-276-183/+204
| | | | | | | | | | We haven't decided how these should work (see #868), so having them present by default is a bad idea.
* | Merge branch 'tor-rpc-connect-todos' into 'main'Nick Mathewson2025-01-287-70/+106
|\ \ | | | | | | | | | | | | tor-rpc-connect: Address remaining "TODO RPC" notes. See merge request tpo/core/arti!2743
| * | fs-mistrust: document that follow_final_links is not insecureNick Mathewson2025-01-281-0/+4
| | | | | | | | | | | | | | | Since it makes an exception, we need to be clear about the exceptions that it _doesn't_ make.
| * | fs-mistrust: link to documentation about "obeying constraints"Nick Mathewson2025-01-281-5/+5
| | | | | | | | | | | | | | | | | | Since "obeying the constraints of a FileAccess" is a term of art, this commit introduces links from the places where it is used to the place where it is defined.
| * | rpc-connect: Remove remaining TODO RPCsNick Mathewson2025-01-271-4/+1
| | | | | | | | | | | | I have checked the relevant code, and it seems okay.
| * | rpc-connect: Make Connect::validate more straightforwardNick Mathewson2025-01-271-11/+12
| | |
| * | rpc-connect: check that all paths inside a connpt are absolute.Nick Mathewson2025-01-271-13/+49
| | |
| * | rpc-connect: remove todo; confirm that we do want to mkdir.Nick Mathewson2025-01-271-1/+1
| | |
| * | rpc-connect: Detect and decline connpts with invalid "auth" feieldsNick Mathewson2025-01-273-20/+18
| | |
| * | rpc-connect: Abort on misformed cookie file, and explain why.Nick Mathewson2025-01-271-6/+3
| | |
| * | rpc-connect: Use file_access() API, and permit symlinks.Nick Mathewson2025-01-272-17/+20
| |/
* | tor-proto: Use SENDME_TAG_LEN constant instead of magic value.Gabriela Moldovan2025-01-282-7/+8
| |
* | tor-proto: Use CircTag::try_from for clarity.Gabriela Moldovan2025-01-282-7/+12
| |
* | tor-proto: Use CircTag instead of raw byte slice.Gabriela Moldovan2025-01-282-7/+6
| |