| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | |
| | |
| | |
| | | |
See discussion at #1210, "question 5".
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Part of #1210.
These values are not necessarily the cleverest possible, but they
match the C implementation. We can tune them if we need to.
|
| | | |
| | |
| | |
| | |
| | | |
This makes us more spec-conformant. See discussion at #1210
"question 3".
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The old names were somewhat inaccurate. (I would have considered
keeping and deprecating the old names, but we already have breaking
changes in tor-netdir.)
|
| | | | |
|
| | | |
| | |
| | |
| | | |
See #1210 "question 2" for more discussion here.
|
| | | |
| | |
| | |
| | | |
See discussion and rationale on #1210 "question 1".
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
tor-keymgr: Lowercase the role when building the ArtiPath.
Closes #1195
See merge request tpo/core/arti!1934
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The `slug` docs say slugs are not allowed to contain uppercase
characters, so let's return an error if they do.
Part of #1195
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The role is a slug, and slugs are not allowed to contain uppercase
characters.
Closes #1195
|
| |\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | | |
rtcompat: Fix a rustdoc link.
See merge request tpo/core/arti!1938
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
This is now InstanceStateHandle::purge.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
We should add more tests for these error representations but we want
to rework these errors so let's not do all that now.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Apparently we need
https://github.com/dbrgn/tracing-test/pull/17
too.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We need this bugfix
https://github.com/dbrgn/tracing-test/pull/15
for `#[traced_test]` when `Result` is redefined.
Fixes the tests with minimal-versions.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
We use `/` to separate, not `+`.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This would fix the tests on Windows I think ? (Tests which don't seem
to run in routine CI AFAICT.)
|
| | | | |
| | | |
| | | |
| | | | |
As previously decided and documented.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We're about to reuse this.
This changes the Resource in the error to be more accurate, too. This
will be more important as we add another call site.
|
| | | | |
| | | |
| | | |
| | | | |
We're going to want this some more.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
Remaining formatting churn.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
And also instance_peek_storage, which needs to share some code, so
determined the shape of this implementation.
Make StateDirectory have the (one) field we need.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
These are the straightforward methods which, given a CheckedDir,
perform the relevant operation.
Make InstanceStateHandle have the necessary fields.
Constructing an InstanceStateHandle is a bit complex and will come in
a moment.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In practice, allowing Bug here was quite inconvenient for everyone.
I think very few call sites will want to throw anything interesting.
If they *do* want to cause an error, without panicking, they could
write a syntactically invalid slug.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
state_dir doesn't support a "shared read-only" mode, so it needs an
error.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Introduce a Bug variant.
Then, use it for conversions from BadSlug. See the comment for why I
think this is appropriate.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
You don't need to consume a Mistrust to get a CheckedDir - you use a
Verifier and then something clones it for you. So StateDirectory::new
should take &Mistrust.
And instance_peek_storage needs T to be deserialisable!
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This is rather more serious than many deletions - it wipes out the
whole directory. And this name goes better with purge_instances.
|
| | | | |
| | | |
| | | |
| | | | |
The formatting will be normalised roughly as we go.
|
| | | | |
| | | |
| | | |
| | | | |
Now we get log messages about what we're reading/writing.
|
| | |/ /
|/| | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
Service nicknames are represented by `HsNickname`, so let's
rename `HsClientSpecifier` to `HsClientNickname`.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This also removes a TODO regarding adding a `Nickname` type for
representing `HsClientSpecifier` and `HsNickname` (we don't need it if
`Slug`s are non-empty).
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1931#note_2990227
|
| | | |
| | |
| | |
| | | |
This also fixes a bug in `HsId::from_component`.
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
It was previously possible to construct an `HsNickname` out of an empty
string using the `FromStr` impl.
|