summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | Upgrade to latest version of float-cmp.Nick Mathewson2024-09-251-1/+1
| | | | | | |
* | | | | | | rpclib: read SOCKS _after_ processing.Nick Mathewson2024-09-251-12/+12
| |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When doing the client handshake, we need to read data _after_ we check for stuff to send, since the client speaks first in the socks protocol. Without this patch, the socks handshake just stalls.
* | | | | | Merge branch 'socks_read_zero' into 'main'Nick Mathewson2024-09-254-5/+30
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | socks users: detect closed sockets. (TROVE-2024-011) Closes #1635 See merge request tpo/core/arti!2447
| * | | | | | socks users: copy the correct amount in our drain logic.Nick Mathewson2024-09-242-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When calling copy_within, we want to copy the amount of data that we're keeping; previously, we were copying an extra `action.drain` bytes, which could have led to a panic. Spotted by Opara.
| * | | | | | socks users: detect closed sockets.Nick Mathewson2024-09-244-3/+28
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this check, our socks code can enter an infinite loop if a socket is closed at the wrong time. Resolves TROVE-2024-011. Fixes #1635.
* | | | | | Merge branch 'rename_singleton_id' into 'main'Jim Newsome2024-09-255-14/+14
|\ \ \ \ \ \ | |_|/ / / / |/| | | | / | | |_|_|/ | |/| | | | | | | | | | | | | rpc: Rename SingletonId to SingleIdResponse Closes #1585 See merge request tpo/core/arti!2448
| * | | | rpc: Rename SingletonId to SingleIdResponseNick Mathewson2024-09-245-14/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calling it "singleton" might have suggested that it was using the [singleton pattern](https://en.wikipedia.org/wiki/Singleton_pattern), which it isn't. (Renaming done with rust-analyzer and double-checked with `git grep`.) Closes #1585.
* | | | | Run fixup-features in preparation for upcoming release.Nick Mathewson2024-09-256-5/+6
| |/ / / |/| | |
* | | | Merge branch 'impl-prop-351' into 'main'Nick Mathewson2024-09-241-124/+106
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | socks: Implement proposal 351. See merge request tpo/core/arti!2401
| * | | | socks: Add a comment about interpreting legacy usernames.Nick Mathewson2024-09-241-0/+5
| | | | |
| * | | | socks: cleanups in interpret_socks_authNick Mathewson2024-09-181-12/+22
| | | | | | | | | | | | | | | | | | | | Introduce an enum, and use explicit `format_code @` syntax.
| * | | | prop351: comment Suggestions from @diziet.Nick Mathewson2024-09-181-1/+4
| | | | |
| * | | | Socks: isolate streams from different extended-socks formatsNick Mathewson2024-09-181-3/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (These streams would already be isolated by accident, since streams with an RPC object are always on a client that's isolated from the main client. But, as discussed on torspec!280, it's best to do this sort of thing explicitly.)
| * | | | socks: Optimistically revise format to match torspec!280Nick Mathewson2024-09-101-43/+53
| | | | |
| * | | | socks: update protocol documentationNick Mathewson2024-09-091-78/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current best source here is prop351, and later will be socks-extensions.md. The examples are now correct.
| * | | | socks: Implement proposal 351.Nick Mathewson2024-09-091-40/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://spec.torproject.org/proposals/351-socks-auth-extensions.html This proposal changes the interpretation of SOCKS5 usernames/passwords to give a more principled and extensible way of getting RPC IDs and isolation strings.
* | | | | Merge branch 'impl-prop-351-client' into 'main'Nick Mathewson2024-09-243-11/+16
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | rpclib: Use prop351 protocol to open streams. See merge request tpo/core/arti!2434
| * | | | | rpclib: Use prop351 protocol to open streams.Nick Mathewson2024-09-183-11/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that prop351 is what Arti speaks, it's what the rpclib needs to provide. Note one change in particular: the `isolation` string is no longer an optional argument when opening a stream. (With prop351, there is no longer such a thing as an "absent" isolation string, and we don't want to imply that there is a difference between None and "".)
* | | | | | Merge branch 'pessimistic' into 'main'Nick Mathewson2024-09-241-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | arti SOCKS proxy: Tear down connections when client sends optimistic data See merge request tpo/core/arti!2443
| * | | | | | arti SOCKS proxy: Tear down connections when client sends optimistic dataIan Jackson2024-09-241-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We *do* want to support optimistic data, see https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2436#note_3081886 However, right now, Arti risks mis-framing bugs if clients do send optimistic data, which would be quite serious. Mitigates #1627 / TROVE-2024-010 by replacing the misframing bug with connection failure. It doesn't seem so easy to write a test case for this.
* | | | | | | rpc: Expose a delegation table in arti:x_list_all_rpc_methodsNick Mathewson2024-09-244-1/+69
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #1624.
* | | | | | | rpc: add mandatory delegate-type attribute to Object templateNick Mathewson2024-09-243-4/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When specifying a delegation, the template user must also say what type they're delegating to. We're going to use this to document and expose delegations.
* | | | | | | Merge branch 'hscircpool-builder-generic' into 'main'gabi-2502024-09-249-464/+875
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make `HsCircPool` generic over circuit builder type See merge request tpo/core/arti!2420
| * | | | | | | CircMgr: Make CircMgr and HsCircPool generic over builder type.Wesley Aptekar-Cassels2024-09-249-464/+875
| | |_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will allow for testing, as the CircuitBuilder can be replaced with a mocked version. This did require moving some of what was in the CircuitBuilder impl into the AbstractCircuitBuilder type, since Drop implementations can't be specialized, but that's fine, as we'll probably be doing more of that in the future anyways.
* | | | | | | Merge branch 'abstract-socket-v2' into 'main'Nick Mathewson2024-09-2431-406/+972
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | rtcompat: Second attempt at AF_UNIX support Closes #1152 See merge request tpo/core/arti!2437
| * | | | | | rtcompat: Finalize names for general::SocketAddr.Nick Mathewson2024-09-242-44/+52
| | | | | | |
| * | | | | | rtcompat: Expose FakeStream and friends; fix compilation in tor-rtmockNick Mathewson2024-09-244-17/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It turns out that these types are generally useful, and that they are in fact needed for tor-rtmock to compile without a PreferredRuntime.
| * | | | | | rtcompat: Fix some rustdoc links.Nick Mathewson2024-09-244-6/+6
| | | | | | |
| * | | | | | rtcompat: remove async_trait from NetStreamListener.Nick Mathewson2024-09-248-8/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (The trait no longer has any async methods.)
| * | | | | | Make Runtime require NetStreamProvider<unix::SocketAddr>Nick Mathewson2024-09-247-10/+46
| | | | | | |
| * | | | | | rtcompat: initial implementation for "Abstract" addresses.Nick Mathewson2024-09-242-0/+147
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is feature-complete, but will need tests. I'm holding off at this point so we can discuss naming on these types.
| * | | | | | rtcompat: Require Sync and 'static for NetStreamListener::IncomingNick Mathewson2024-09-243-2/+7
| | | | | | |
| * | | | | | rtcompat: Add NetStreamProvider<Unix> to CompoundRuntimeNick Mathewson2024-09-243-39/+106
| | | | | | |
| * | | | | | rtcompat: NetStreamProvider<unix::SocketAddr> for non-unix platformsNick Mathewson2024-09-244-0/+108
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since there is no way to construct a unix::SocketAddr on these platforms, it's harmless to provide an implementation for NetStreamProvider. What's more, doing so greatly simplifies our AbstractAddr implementation.
| * | | | | | Implement NetStramProvider<Unix> for async_std.Nick Mathewson2024-09-241-0/+23
| | | | | | |
| * | | | | | async_std: Perpare macro for use with Unix streams.Nick Mathewson2024-09-242-33/+35
| | | | | | |
| * | | | | | async_std: start a macro to implement wrappers for stream typeNick Mathewson2024-09-241-71/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As before, this commit does nothing interesting: it's a separate commit because it reindents a lot of code.
| * | | | | | rtcompat: Implement NetStreamProvider<Unix> for tokio.Nick Mathewson2024-09-241-4/+60
| | | | | | |
| * | | | | | tokio: Perpare macro for use with Unix streams.Nick Mathewson2024-09-241-24/+31
| | | | | | |
| * | | | | | tokio: start a macro to implement wrappers for stream typeNick Mathewson2024-09-241-67/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit does nothing interesting yet: it's a separate commit because it reindents a lot of code.
| * | | | | | rtcompat: Add ADDR parameter to NetStream{Provider,Listener}Nick Mathewson2024-09-241-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change will let us make a NetStreamProvider that works for AF_UNIX addresses, and for "abstract" addresses. I've decided to let this parameter have a default value of `std::net::SocketAddr` for now. We can remove the default later if we decide it's confusing.
| * | | | | | Documentation updates for "NetStreamProvider" renameNick Mathewson2024-09-2410-32/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Stop referring to TCP streams in its documentation; update other documentation to refer to NetStreamProvider rather than TcpProvider.
| * | | | | | rtcompat: Rename TcpProvider to NetStreamProvider.Nick Mathewson2024-09-2417-98/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (And similarly rename TcpListener to NetStreamListener, along with their TcpStream/TcpListener associated types.) These types are about to become generic over addresses, and therefore shouldn't be named after TCP. Renaming was done mostly with Rust Analyzer, except for some macros that needed to be hand-edited. (I'll revise the comments in the next commit; this one is all about renaming.)
| * | | | | | rtcompat: Remove accept() from TcpListenerNick Mathewson2024-09-2412-82/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's redundant with the incoming() method (which turns the TcpListener into a Stream of connections), and nothing actually used it outside of tests. Removing this method allows us to simplify our TcpListener code a good deal, as can be seen by some of the implementations we removed from our example and testing code.
| * | | | | | rtcompat: Add definitions for unix::SocketAddr.Nick Mathewson2024-09-243-0/+97
| | | | | | |
| * | | | | | rtcompat: reformat Cargo.tomlNick Mathewson2024-09-241-1/+5
| | | | | | |
| * | | | | | rtcompat: Add an extension trait for building modified RuntimesNick Mathewson2024-09-246-23/+80
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With this extension trait, we no longer need to construct `CompoundRuntime` directly outside of tor-rtcompat. This in turn will make it a little less painful when we have to add more generics to CompoundRuntime.
* | | | | | tor-keymgr: Rename keystore.type to keystore.kind.Gabriela Moldovan2024-09-231-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In !2394 we settled on `kind`. This updates the error messages to reference the new field name.
* | | | | | arti: Update example config with new keystore configuration.Gabriela Moldovan2024-09-231-10/+8
| | | | | |
* | | | | | tor-keymgr: Move keystore config under keystore.primary.Gabriela Moldovan2024-09-233-5/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The keystore settings only configure the *primary* keystore, so they should be under `keystore.primary`.
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 19:03:48 +0000