| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | | fs-mistrust: Use Path::try_exists() instead of Path::exists(). | Gabriela Moldovan | 2024-07-30 | 1 | -2/+2 | |
| | | | ||||||
| * | | tor-keymgr: Use Path::try_exists() instead of Path::exists(). | Gabriela Moldovan | 2024-07-30 | 1 | -3/+10 | |
| | | | ||||||
| * | | fslock-guard: Use Path::try_exists() instead of Path::exists(). | Gabriela Moldovan | 2024-07-30 | 1 | -4/+4 | |
| |/ | ||||||
| * | tor-proto::circuit: Move test-only methods into test module | Jim Newsome | 2024-07-29 | 1 | -12/+14 | |
| | | ||||||
| * | tor-proto circuit tests: dedupe circid magic number | Jim Newsome | 2024-07-29 | 1 | -6/+15 | |
| | | ||||||
| * | tor-proto circuit test: Move to tighter scope and shadow outer def | Jim Newsome | 2024-07-29 | 1 | -15/+17 | |
| | | ||||||
| * | tor-proto circuit tests: delete stale commented-out test | Jim Newsome | 2024-07-29 | 1 | -66/+0 | |
| | | ||||||
| * | tor-proto circuit tests: fix some comment copy-pasta | Jim Newsome | 2024-07-29 | 1 | -1/+1 | |
| | | ||||||
| * | circuit reactor: add comment pointing to tests in other module | Jim Newsome | 2024-07-29 | 1 | -1/+3 | |
| | | ||||||
| * | Mark a struct as allowed-to-be-unused. | Nick Mathewson | 2024-07-28 | 1 | -0/+1 | |
| | | | | | | (This will either become used later, or we will remove it; the TODO RPC will remind us.) | |||||
| * | Fix "clippy::manual-pattern-char-comparison" warning on nightly | Nick Mathewson | 2024-07-28 | 2 | -2/+2 | |
| | | | | | | | | This warning suggests using `[a,b]` as a Pattern when it sees a search for `|ch| ch == a || ch == b`. (All of our supported rust versions allow this kind of Pattern.) | |||||
| * | Fix new "clippy::needless-maybe-sized" warning on nightly | Nick Mathewson | 2024-07-28 | 3 | -4/+4 | |
| | | | | | | This warning complains when we say `where T: SomeTrait + ?Sized` when `SomeTrait` is inherently Sized. | |||||
| * | Merge branch 'rpclib-i64-id' into 'main' | David Goulet | 2024-07-25 | 1 | -3/+2 | |
| |\ | | | | | | | | | rpclib: Use i64 rather than u64 for request IDs. See merge request tpo/core/arti!2279 | |||||
| | * | rpclib: Use i64 rather than u64 for request IDs. | Nick Mathewson | 2024-07-22 | 1 | -3/+2 | |
| | | | | | | | | | This makes it conform to the spec and match arti-rpcserver. | |||||
| * | | Merge branch 'rpcbase-cleanup' into 'main' | Nick Mathewson | 2024-07-25 | 16 | -268/+192 | |
| |\ \ | | | | | | | | | | | | | rpcbase: Fix most TODO RPC comments. See merge request tpo/core/arti!2284 | |||||
| | * | | rpc: Remove special conversion for SendUpdateError. | Nick Mathewson | 2024-07-25 | 2 | -10/+6 | |
| | | | | ||||||
| | * | | rpc: Rename the error codes for something like consistency. | Nick Mathewson | 2024-07-25 | 6 | -24/+25 | |
| | | | | ||||||
| | * | | rpc: Remove RpcError data field and use Report | Nick Mathewson | 2024-07-25 | 6 | -102/+32 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Per discussion, this field isn't really specified in a way that lets us fill it sensibly at the moment. So for now, we're going to just omit it. Additionally, we said that we'd Report on our errors; this branch changes the implementation of RpcError to do that. Question: Will the blanket implementation for Into<RpcError> make it harder to re-add a Data field later on if we want to do so? | |||||
| | * | | rpc: Refactor errors part 1: a new RpcMethod trait. | Nick Mathewson | 2024-07-25 | 9 | -56/+49 | |
| | | | | | | | | | | | | | | | | It is no longer necessary to say, for every RPC method, that its error type is RpcError. | |||||
| | * | | rpcbase: remove now-unused invoke methods | Nick Mathewson | 2024-07-25 | 2 | -71/+34 | |
| | | | | | | | | | | | | | | | | | | | | | | These methods were defined on DispatchTable, and then replaced by top-level functions in the crate. (The reason for using top-level functions instead is so that we get the locking on the dispatch table correct.) | |||||
| | * | | rpcbase: Remove a TODO RPC about duplication | Nick Mathewson | 2024-07-25 | 1 | -1/+0 | |
| | | | | | | | | | | | | | | | | The duplication is only a few lines. I've looked into a couple of ways for removing it, but they make the code flow even less clear. | |||||
| | * | | rpcbase: Replace a TODO with a set of notes and caveats | Nick Mathewson | 2024-07-25 | 2 | -7/+45 | |
| | | | | | | | | | | | | | | | | | | | We have decided not to remove the "anybody can define methods" property. This commit documents the consequences, and warns extenders away from some really bad ideas. | |||||
| | * | | rpc: remove TODO about adding an extension trait | Nick Mathewson | 2024-07-25 | 1 | -4/+0 | |
| | | | | | | | | | | | | | | | | These functions are called rarely enough that it is probably okay for the ergonomics to be a bit verbose. | |||||
| | * | | rpc: Remove TODO about moving @special to a different macro. | Nick Mathewson | 2024-07-25 | 1 | -4/+0 | |
| | | | | ||||||
| | * | | rpc: Do not hide InvokeError::Bug when converting to RpcError | Nick Mathewson | 2024-07-25 | 1 | -18/+35 | |
| | | | | ||||||
| | * | | rpc: split "method not found" | Nick Mathewson | 2024-07-25 | 3 | -11/+15 | |
| | | | | | | | | | | | | | | | | We've wanted separate error codes for "no such method exists" and "this method exists, but this object doesn't have it." | |||||
| | * | | rpcbase: remove "Nil" TODO. | Nick Mathewson | 2024-07-25 | 1 | -3/+0 | |
| | | | | | | | | | | | | | This change would take some serde magic that is probably not worth it. | |||||
| | * | | rpcbase: Use newer "tgens" deftly syntax | Nick Mathewson | 2024-07-25 | 1 | -3/+1 | |
| | | | | ||||||
| | * | | rpcbase: remove a TODO about expose_outside_of_session | Nick Mathewson | 2024-07-25 | 1 | -4/+0 | |
| | | | | | | | | | | | | | (There is no longer such a thing as a "pseudomethod.") | |||||
| * | | | tor-memquota: discuss StreamUnobtrusivePeeker name | Ian Jackson | 2024-07-24 | 1 | -7/+8 | |
| | | | | | | | | | | | | | | | | See https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2280#note_3051134 | |||||
| * | | | tor-memquota: Elide a lifetime | Ian Jackson | 2024-07-24 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2280#note_3051270 | |||||
| * | | | tor-memquota: Fix a wrong comment | Ian Jackson | 2024-07-24 | 1 | -3/+1 | |
| | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2280#note_3051268 | |||||
| * | | | tor-memquota: Provide StreamUnobtrusivePeeker (tests) | Ian Jackson | 2024-07-24 | 1 | -0/+163 | |
| | | | | ||||||
| * | | | tor-memquota: Provide StreamUnobtrusivePeeker | Ian Jackson | 2024-07-24 | 5 | -2/+377 | |
| |/ / | | | | | | | | | | | I'm not particularly pleased with this name. We need names for both the type, and the trait we'll almost certainly want to introduce in the future. | |||||
| * | | rpclib: Add tests for errors that terminate an RpcConn. | Nick Mathewson | 2024-07-24 | 1 | -1/+101 | |
| | | | ||||||
| * | | rpclib: Initial tests for RpcConn | Nick Mathewson | 2024-07-24 | 5 | -4/+240 | |
| | | | | | | | | | | | | | The "complex" test here is fairly involved, since it tries to detect deadlocks and race conditions by using multiple threads and answering requests out of order. | |||||
| * | | rpclib: Test low-level reader/writer. | Nick Mathewson | 2024-07-24 | 2 | -0/+126 | |
| | | | ||||||
| * | | rpc: Relax 'static requirement on execute_with_updates closure. | Nick Mathewson | 2024-07-24 | 1 | -1/+1 | |
| | | | | | | | | | This turns out not to be necessary. | |||||
| * | | rpclib: do not include `"meta":null` when serializing. | Nick Mathewson | 2024-07-24 | 1 | -0/+1 | |
| | | | ||||||
| * | | rpclib: re-encode outgoing requests. | Nick Mathewson | 2024-07-24 | 1 | -5/+6 | |
| | | | | | | | | | | | | | I hadn't been sure that we wanted to do this, since arti is forgiving about its inputs, but IIRC Diziet was in favor of this, and it _does_ make it easier to write tests. | |||||
| * | | Merge branch 'memquota-typed' into 'main' | Ian Jackson | 2024-07-24 | 6 | -38/+469 | |
| |\ \ | | | | | | | | | | | | | tor-memquota: HasMemoryCost trait, and type-safe methods See merge request tpo/core/arti!2282 | |||||
| | * | | tor-memquota: Test Debug, Display and HasKind impls for errors | Ian Jackson | 2024-07-24 | 1 | -0/+72 | |
| | | | | ||||||
| | * | | tor-memquota: impl HasKind for StartupError and ReclaimCrashed | Ian Jackson | 2024-07-24 | 1 | -0/+19 | |
| | | | | | | | | | | | | | | | | Trying to write comprehensive tests for the errors showed that these impls were missing. | |||||
| | * | | tor-memquota: impl HasKind for ReclaimedErrorInner | Ian Jackson | 2024-07-24 | 1 | -1/+7 | |
| | | | | | | | | | | | | | This will make testing easier. | |||||
| | * | | tor-memquota: Fix Display impl for Error::TrackerCorrupted | Ian Jackson | 2024-07-24 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | Bug found in review: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2282#note_3051101 | |||||
| | * | | tor-memquota: memory_cost: Introduce try_claim (tests) | Ian Jackson | 2024-07-24 | 1 | -0/+31 | |
| | | | | ||||||
| | * | | tor-memquota: memory_cost: Introduce try_claim | Ian Jackson | 2024-07-24 | 1 | -0/+38 | |
| | | | | | | | | | | | | | | | | Our stream wrapper is going to want this. It's fiddly enough that doing it as a standalone facility seems sensible. | |||||
| | * | | tor-memquota: memory_cost: New trait and typed wrappers (tests) | Ian Jackson | 2024-07-24 | 1 | -0/+69 | |
| | | | | ||||||
| | * | | tor-memquota: memory_cost: New trait and typed wrappers | Ian Jackson | 2024-07-24 | 3 | -0/+158 | |
| | | | | ||||||
| | * | | tor-memquota: Expose some test utilities for the rest of the crate | Ian Jackson | 2024-07-24 | 2 | -5/+8 | |
| | | | | ||||||
