summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
* | | tor-hsservice: Abolish OnionServiceState.Gabriela Moldovan2024-07-151-38/+21
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes a mostly-unnecessary struct holding the state of an `OnionService` or `RunningOnionService`. It only exists because I wanted to reduce the duplication of the `OnionService` and `RunningOnionService` fields. I am removing it because `OnionService` will soon become a builder, and this inner structure is making it difficult to create an ergonomic builder API (if we keep `OnionServiceState`, the builder fields won't map 1:1 to the fields of the build `OnionService` type). Note: this commit intentionally a bit misformatted to make reviewing easier. The reformatting will come in a future commit.
* | Merge branch 'dev/cve/handshake_clarification' into 'main'gabi-2502024-07-151-1/+1
|\ \ | | | | | | | | | | | | UnverifiedChannel: Clarify check's peer_cert See merge request tpo/core/arti!2260
| * | UnverifiedChannel: Clarify check's peer_certClara Engler2024-07-111-1/+1
| | | | | | | | | | | | | | | | | | | | | This commit clarifies the documentation of the `peer_cert` parameter in the `UnverifiedChannel::check` function, in order to reflect that it represents the certificate presented during the ServerHello in the TLS handshake and not in the in-protocol CERTS cell.
* | | tor-proto: Return proper `Error::MissingId`Clara Engler2024-07-121-1/+1
|/ / | | | | | | | | | | | | | | | | This commit fixes a bug in the `ClientCirc::extend_ntor` function, which currently returns a `Error::MissingId(Ed25519)` in the case that no RSA identity has been found in the accompanying channel target. This behavior is obviously wrong, because a missing RSA identity should yield a `Error::MissingId(Rsa)`.
* | implement TorClient::wait_for_stoptrinity-1686a2024-07-113-0/+29
| |
* | Merge branch 'fix-arti-hsc-subcommand' into 'main'gabi-2502024-07-113-5/+14
|\ \ | | | | | | | | | | | | arti: Add a keymgr feature. See merge request tpo/core/arti!2257
| * | arti: Gate the hsc subcommand behind the keymgr feature (fmt).Gabriela Moldovan2024-07-102-2/+10
| | |
| * | arti: Gate the hsc subcommand behind the keymgr feature.Gabriela Moldovan2024-07-102-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `arti hsc` subcommand can't run without keymgr support. Previously, it relied on `tor-keymgr/keymgr` being enabled indirectly by its dependencies, via the `experimental` feature. We need to be able to enable this feature in `arti` without relying on `experimental` (because `arti hsc` will eventually be made non-experimental). Part of #1487
| * | arti: Add a keymgr feature.Gabriela Moldovan2024-07-101-1/+2
| | | | | | | | | | | | | | | | | | | | | Adding a `keymgr` feature here will enable us to detect if `arti` is running without keymgr support. This is needed for the correct handling of subcommands that require keymgr support (such as the `arti hsc` subcommand).
* | | Merge branch 'mistrust-message' into 'main'Ian Jackson2024-07-108-16/+54
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Fix fs_mistrust error messages and some misnamed error variants Closes #1473 See merge request tpo/core/arti!2253
| * | tor-persist: Deprecate ErrorSource::Permissions, use InaccessibleIan Jackson2024-07-101-1/+9
| | |
| * | tor-dirmgr: Deprecate Error::CachePermissions, use CacheAccessIan Jackson2024-07-101-1/+12
| | |
| * | tor-config: Deprecate ConfigError::Permissions, use FileAccessIan Jackson2024-07-102-1/+6
| | |
| * | tor-persist: Correct message and description for mistrust errorIan Jackson2024-07-101-2/+4
| | |
| * | tor-dirmgr: Correct message and description for mistrust errorIan Jackson2024-07-101-2/+4
| | |
| * | tor-config: Correct message and description for mistrust errorIan Jackson2024-07-101-2/+4
| | | | | | | | | | | | Part of #1473
| * | tor-keymgr: Correct message for mistrust errorIan Jackson2024-07-102-4/+4
| | |
| * | arti-client: Correct message for mistrust errorIan Jackson2024-07-101-1/+1
| | |
| * | fs-mistrust: Explain that Error might not be a permissions errorIan Jackson2024-07-101-0/+7
| | |
| * | fs-mistrust: Fix a formatting botchIan Jackson2024-07-101-2/+3
| | | | | | | | | | | | rustfmt didn't want to fix this, for some reason.
* | | arti-client: Gate generate_service_discovery_key() behind keymgr feature.Gabriela Moldovan2024-07-101-2/+10
|/ / | | | | | | | | Otherwise arti-client fails to build with `-no-default-features --features onion-service-client,experimental-api`.
* | Merge branch 'descriptor-publisher-warnings' into 'main'gabi-2502024-07-095-238/+26
|\ \ | | | | | | | | | | | | tor-hsservice: Remove dead code from the descriptor publisher See merge request tpo/core/arti!2251
| * | tor-hsservice: Remove unnecessary let-binding.Gabriela Moldovan2024-07-091-1/+2
| | |
| * | tor-hsservice: Specify the type when discarding value.Gabriela Moldovan2024-07-092-3/+3
| | | | | | | | | | | | | | | | | | | | | This should give us some confidence that we are not accidentally discarding results we should actually be using. Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2251#note_3046219
| * | tor-hsservice: Resolve dead code warnings in publisher tests.Gabriela Moldovan2024-07-091-11/+7
| | |
| * | tor-hsservice: Ignore uninteresting netdir events in the publisher.Gabriela Moldovan2024-07-091-1/+12
| | | | | | | | | | | | This also makes the publisher exit if the netdir event stream ends.
| * | tor-hsservice: Resolve warning about unused response variable.Gabriela Moldovan2024-07-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | It is OK to discard the response string (the response is validated below where we call `DirResponse::into_output_string()`). (Perhaps we should just make `DirResponse::check_ok()` public. That way, we could validate the response without having to handle its output string).
| * | tor-hsservice: Resolve a handful of unused variable warnings.Gabriela Moldovan2024-07-092-4/+4
| | |
| * | tor-hsservice: Remove unused field from TimePeriodContext.Gabriela Moldovan2024-07-091-3/+0
| | |
| * | tor-hsservice: Remove unused variables.Gabriela Moldovan2024-07-092-14/+0
| | |
| * | tor-hsservice: Remove unnecessary locking.Gabriela Moldovan2024-07-091-2/+0
| | |
| * | tor-hsservice: Remove unused code (fmt).Gabriela Moldovan2024-07-091-1/+1
| | |
| * | tor-hsservice: Remove unused code.Gabriela Moldovan2024-07-094-188/+1
| | | | | | | | | | | | This is being reimplemented as #1292
| * | tor-hsservice: Remove unused publisher functions.Gabriela Moldovan2024-07-092-13/+0
| | | | | | | | | | | | | | | | | | | | | This removes a couple of unimplemented functions. These were supposed to be the starting point for #1217, but we won't be implementing that any time soon.
| * | tor-hsservice: Remove unnecessary allow.Gabriela Moldovan2024-07-091-1/+0
| | | | | | | | | | | | Note: #1217 is still open and we may want to implement it at some point.
* | | Remove reference to arti-hyper in arti-client README.mdIan Jackson2024-07-091-2/+0
|/ / | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2225#note_3043992 We have an example for how to use arti-client with hyper 1.x, but I don't think we need to to mention that here.
* | Merge branch 'fix-time-period-parsing-bug' into 'main'gabi-2502024-07-081-5/+7
|\ \ | | | | | | | | | | | | tor-keymgr: Use collect_tuple in TimePeriod::from_slug. See merge request tpo/core/arti!2248
| * | tor-keymgr: Use collect_tuple in TimePeriod::from_slug (fmt).Gabriela Moldovan2024-07-081-1/+2
| | |
| * | tor-keymgr: Use collect_tuple in TimePeriod::from_slug.Gabriela Moldovan2024-07-081-5/+5
| | | | | | | | | | | | | | | | | | The previous approach was buggy: collecting the parts of the time period into an `ArrayVec` of length 3 would panic if the number of parts was greater than 3.
| * | tor-keymgr: Test that parsing a TimePeriod with too many parts doesn't panic.Gabriela Moldovan2024-07-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | This test currently fails because we have a bug in `TimePeriod`'s `from_slug()` implementation. `TimePeriod::from_slug()` splits the slug by `_`, and attempts to collect the parts into an `ArrayVec` of length 3. This is wrong, because the `collect()` will panic if there are more than 3 parts.
* | | Merge branch 'parse-client-auth-key' into 'main'gabi-2502024-07-082-17/+136
|\ \ \ | | | | | | | | | | | | | | | | tor-hscrypto: Implement FromStr for HsClientDescEncKey. See merge request tpo/core/arti!2246
| * | | tor-hscrypto: Use collect_tuple to avoid unnecessary Vec allocation.Gabriela Moldovan2024-07-081-6/+3
| | | |
| * | | tor-hscrypto: Remove HsClientDescKeyParseError's HasKind impl.Gabriela Moldovan2024-07-081-12/+0
| | | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2246#note_3045656
| * | | tor-hscrypto: Implement FromStr for HsClientDescEncKey.Gabriela Moldovan2024-07-081-3/+149
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We will use this impl for parsing the authorized clients of a hidden service running in "restricted discovery" mode. NB: "Restricted discovery" is the new terminology for "services that require client authorization", i.e. services that implement "client authorization" as described in rend-spec HS-DESC-ENC[0]. Note we haven't fully transitioned to the new terminology yet (see #1476). Part of #1292 [0]: https://spec.torproject.org/rend-spec/hsdesc-encrypt.html#HS-DESC-SECOND-LAYER
| * | | tor-hscrypto: Remove unnecessary Display wrapper.Gabriela Moldovan2024-07-082-18/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I don't think we need a separate wrapper type for displaying `HsClientDescEncKey` keys in the "C Tor format" (`<auth-type>:<key-type>:<base32-encoded-public-key>`). I think this should be the canonical string representation of `HsClientDescEncKey`, so I'm removing the `display_authorized_client` function and corresponding `DisplayAuthorizedHsClientDescEncKey` wrapper type.
* | | | Fix a footnote reference that Nightly complains aboutIan Jackson2024-07-081-1/+1
|/ / /
* | | Merge branch 'deftly' into 'main'Ian Jackson2024-07-0813-14/+14
|\ \ \ | | | | | | | | | | | | | | | | Update to derive-deftly 0.14 See merge request tpo/core/arti!2241
| * | | Update to derive-deftly 0.14Ian Jackson2024-07-0813-14/+14
| | | | | | | | | | | | | | | | | | | | This removes the deprecated syntaxes. Updating now will prevent us re-introducing the old syntaxes, which we updated in arti!2209.
* | | | Merge branch 'warnings' into 'main'Ian Jackson2024-07-0811-26/+34
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Fix or allow warnings that show up in beta See merge request tpo/core/arti!2244
| * | | | Work around clippy::doc_lazy_continuation false positivesIan Jackson2024-07-082-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://github.com/rust-lang/rust-clippy/issues/13001 I think it's OK to change this in our tree, nevertheless.
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 18:20:16 +0000