summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
* | tor-hsservice: Remove extraneous blank line.Gabriela Moldovan2024-02-191-1/+0
| | | | | | | | | | We don't have blank lines between the other variants, so let's remove this one too for consistency.
* | tor-keymgr: Pick a better name for error variable.Ian Jackson2024-02-191-1/+1
| |
* | tor-keymgr: Add more context to errors returned from HsId::from_slug.Gabriela Moldovan2024-02-191-5/+4
| | | | | | | | | | `InvalidKeyPathComponentValue::Slug` now has to wrap a `String`, because we can't get `HsIdParse` errors as static strings.
* | tor-keymgr: Add more context to InvalidKeyPathComponentValue errors (fmt).Gabriela Moldovan2024-02-191-5/+11
| |
* | tor-keymgr: Add more context to InvalidKeyPathComponentValue errors.Gabriela Moldovan2024-02-191-9/+7
| |
* | tor-keymgr: Document what context to add to invalid slug errors.Gabriela Moldovan2024-02-191-0/+7
| | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1960#note_2994317
* | tor-keymgr: Downgrade a documentation TODO.Gabriela Moldovan2024-02-191-1/+1
| | | | | | | | | | The tor-keymgr crate *is* documented, but could use a better README and some examples and/or usage guides.
* | tor-keymgr: Reword the README.Gabriela Moldovan2024-02-191-24/+30
| | | | | | | | | | | | This rewords the docs for clarity. Part of #1115
* | tor-keymgr: Remove vestigial comment.Gabriela Moldovan2024-02-191-2/+0
| | | | | | | | This removes a remnant of a now-gone TODO.
* | tor-keymgr: Make InvalidKeyPathComponentValue public.Gabriela Moldovan2024-02-192-3/+5
| | | | | | | | | | It appears within the public API (it is the error type returned from `KeySpecifierComponent`), so let's make it public.
* | tor-keymgr: Make InvalidKeyPathComponentValue an enum.Gabriela Moldovan2024-02-191-11/+20
| | | | | | | | | | | | | | | | | | Previously, `InvalidKeyPathComponentValue` was a single error type, with the error message hard-coded to "invalid key denotator". This was wrong, because this error is used for other types of invalid components too (not just for invalid denotators). Part of #1115
* | tor-keymgr: Add a note about KeyPathError.Gabriela Moldovan2024-02-191-0/+10
| |
* | tor-keymgr: Include the ArtiPath in PatternNotMatched.Gabriela Moldovan2024-02-192-6/+3
| | | | | | | | | | | | | | All `KeyPathError` variants now include the `ArtiPath` that caused the error. Part of #1115
* | tor-keymgr: Include ArtiPath in InvalidArtiPath (fmt).Gabriela Moldovan2024-02-192-5/+19
| |
* | tor-keymgr: Include ArtiPath in InvalidArtiPath.Gabriela Moldovan2024-02-193-4/+11
| | | | | | | | Part of #1115
* | tor-keymgr: Include the ArtiPath in InvalidKeyPathComponentValue.Gabriela Moldovan2024-02-194-4/+10
| | | | | | | | | | | | The offending `ArtiPath` should be included in the error. Part of #1115
* | tor-keymgr: Rename {to,from}_component to {to,from}_slug.Gabriela Moldovan2024-02-195-24/+25
| | | | | | | | | | | | | | | | | | Originally, these functions converted to and from `ArtiPathComponent`. In !1931, we replaced `ArtiPathComponent` with `Slug` without renaming the conversion functions. Since we're converting to and from `Slug` now, I think it makes sense to rename them too. Part of #1115
* | Merge branch 'keymgr-list-matching' into 'main'gabi-2502024-02-196-48/+109
|\ \ | | | | | | | | | | | | | | | | | | tor-keymgr: Return KeystoreEntryDescriptors from KeyMgr::list_matching Closes #1271 See merge request tpo/core/arti!1988
| * | tor-keymgr: Make the &KeystoreId getter `as_copy`.Gabriela Moldovan2024-02-191-2/+4
| | |
| * | tor-keymgr: Test that KeyMgr::list_matching returns the right descriptors.Gabriela Moldovan2024-02-191-2/+16
| | |
| * | tor-keymgr: Test KeyMgr::{get_entry, remove_entry}.Gabriela Moldovan2024-02-191-0/+27
| | |
| * | tor-keymgr: Remove a TODO.Gabriela Moldovan2024-02-191-2/+0
| | | | | | | | | | | | | | | I am not so sure it makes sense to unify these functions, so let's remove the TODO.
| * | tor-keymgr: Remove outdated reference to KeyMgr::get_with_type.Gabriela Moldovan2024-02-191-1/+1
| | |
| * | tor-keymgr: Replace KeyMgr::get_with_type with KeyMgr::get_entry (fmt).Gabriela Moldovan2024-02-191-4/+1
| | |
| * | tor-keymgr: Replace KeyMgr::get_with_type with KeyMgr::get_entry.Gabriela Moldovan2024-02-193-10/+11
| | | | | | | | | | | | Part of #1271
| * | tor-keymgr: Rename KeyMgr::remove_with_type to KeyMgr::remove_entry.Gabriela Moldovan2024-02-194-9/+15
| | | | | | | | | | | | Part of #1271
| * | tor-keymgr: Make KeyMgr::remove_with_type take a KeystoreEntry (fmt).Gabriela Moldovan2024-02-191-4/+1
| | |
| * | tor-keymgr: Make KeyMgr::remove_with_type take a KeystoreEntry.Gabriela Moldovan2024-02-194-16/+6
| | | | | | | | | | | | | | | | | | | | | NB: `KeyMgr::remove_with_type` will need to be renamed to `KeyMgr::remove_entry`. Part of #1271
| * | tor-keymgr: Derive From for KeystoreSelector.Gabriela Moldovan2024-02-191-2/+2
| | | | | | | | | | | | We will soon use this in `KeyMgr`.
| * | tor-keymgr: Make KeyMgr::list_matching return `KeystoreEntry`s.Gabriela Moldovan2024-02-195-9/+20
| | | | | | | | | | | | Part of #1271
| * | tor-keymgr: Add KeystoreEntry.Gabriela Moldovan2024-02-193-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This type will soon replace `(KeyPath, KeyType)` in `KeyMgr::list_matching`. The KeystoreEntry documentation mentions a couple of functions that don't exist right now (they will be added in a subsequent commit). Part of #1271
* | | Merge branch 'better_hints' into 'main'Ian Jackson2024-02-197-56/+195
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Refactor and improve error hinting. Closes #1165 See merge request tpo/core/arti!1986
| * | Add tests for finding (or not) hints in our error types.Nick Mathewson2024-02-161-0/+58
| | |
| * | Discourage providing HintableErrorImpl without using the macro.Nick Mathewson2024-02-161-3/+10
| | |
| * | Rename one of the hint methods to hint_specificNick Mathewson2024-02-161-3/+10
| | |
| * | Use and document the new arti-client/anyhow featureNick Mathewson2024-02-152-1/+5
| | |
| * | Refactor and improve error hinting.Nick Mathewson2024-02-145-55/+118
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of using complicated match statements, use downcasting to find error types that define specific hints. This also lets us define a reasonable hint-extractor for anyhow::Error, and use it when reporting errors in main. I've left an implementation of hint() in `impl Error`, to avoid breaking backward compatibility. Closes #1165.
* | | Merge branch 'expire-ipts-bis' into 'main'Nick Mathewson2024-02-155-101/+129
|\ \ \ | | | | | | | | | | | | | | | | Code cleanup for IPT external state expiry See merge request tpo/core/arti!1982
| * | | tor-hsservice: ipt mgr: Remove/downgrade two allowsIan Jackson2024-02-131-2/+1
| | | |
| * | | tor-hsservice: ipt mgr: expiry: Add some commentsIan Jackson2024-02-131-0/+4
| | | |
| * | | tor-hsservice: ipt mgr: expiry: Break out all_ipts (fmt)Ian Jackson2024-02-131-4/+1
| | | |
| * | | tor-hsservice: ipt mgr: expiry: Break out all_iptsIan Jackson2024-02-131-8/+15
| | | | | | | | | | | | | | | | And clarify docs for the *current* ipt functions.
| * | | tor-hsservice: ipt mgr: expiry: rename a variableIan Jackson2024-02-131-3/+3
| | | | | | | | | | | | | | | | | | | | "current" has a special meaning here: it means an IPT that we haven't replaced with another at the same relay due to number of requests.
| * | | tor-hsservice: replay: Fix an error message slightlyIan Jackson2024-02-131-1/+1
| | | | | | | | | | | | | | | | | | | | On Windows filenames are WTF-16, not bytes, so a weird filename fails to be UTF-16 rather than failing to be UTF-8.
| * | | tor-hsservice: ipt mgr: Move/rename to StateExpiryError (fmt)Ian Jackson2024-02-131-3/+1
| | | |
| * | | tor-hsservice: ipt mgr: Move/rename to StateExpiryError (followup)Ian Jackson2024-02-131-4/+4
| | | |
| * | | tor-hsservice: ipt mgr: Move/rename to StateExpiryErrorIan Jackson2024-02-132-39/+41
| | | | | | | | | | | | | | | | | | | | The private ExpiryError type is now err::StateExpiryError. We'll fix up the local alias in the HasKind impl in a moment.
| * | | tor-hsservice: replay: Move replay filename knowledge into replay.rs (fmt)Ian Jackson2024-02-131-10/+5
| | | |
| * | | tor-hsservice: replay: Move replay filename knowledge into replay.rsIan Jackson2024-02-132-41/+58
| | | |
| * | | tor-hsservice: tests: Greak out mk_state_instance helperIan Jackson2024-02-131-3/+12
| | | |