summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
| * equix/fuzz: rustfmtMicah Elizabeth Scott2023-08-011-19/+16
| |
| * equix/fuzz: Fixes to get nick's prototype runningMicah Elizabeth Scott2023-08-017-23/+65
| | | | | | | | | | | | | | | | | | There are some places we might improve this, maybe testing more data types and shapes. This patch just makes the minimal changes necessary to get it working: adds allocation logic to the fuzzer itself, and adds visibility for the bucket_array::mem interface. Signed-off-by: Micah Elizabeth Scott <[email protected]>
| * hashx/fuzz: Comments, explain our 'seed' inputMicah Elizabeth Scott2023-08-011-2/+23
| | | | | | | | | | | | | | | | In response to review feedback, explain that 'seed' here is more for compatibility and convenience and not central to our goal of fuzzing the program generator. Signed-off-by: Micah Elizabeth Scott <[email protected]>
| * hashx/fuzz: Simplify, remove rayon dependencyMicah Elizabeth Scott2023-08-012-15/+4
| | | | | | | | | | | | Review feedback is that we don't want parallelism here. Signed-off-by: Micah Elizabeth Scott <[email protected]>
| * hashx/fuzz: Start a cross-implementation fuzzer for HashXMicah Elizabeth Scott2023-08-013-0/+216
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fuzz testing for HashX. Uses a hook into the pseudorandom number stream to test the program generator deeply on input that can be mutated by the fuzzer. Confirms program generation by running a small number of arbitrary test hashes, so we don't need to understand the implementation-specific program format to test the program generator. We test four implementations in parallel this way, the compiled and interpreted implementations included in both this crate and c-tor. Signed-off-by: Micah Elizabeth Scott <[email protected]>
| * WIP: Fuzzer for BucketArray.Nick Mathewson2023-08-013-0/+179
| |
* | Merge branch 'ticket991_mr' into 'main'Nick Mathewson2023-08-021-9/+107
|\ \ | | | | | | | | | | | | Reduce runtime of hspow_vectors and split it up See merge request tpo/core/arti!1462
| * | tor-hspow: Shorten the solve_effort1k_aa_41_01 testMicah Elizabeth Scott2023-08-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The solve tests are all tunable so that we can balance execution time with test coverage. A longer solve will test more random programs and it will test more of the nonce increment function, minor benefits at the cost of much more CPU. The starting nonce in solve_effort1k_aa_41_01 was set so that we would exercise a rollover in bit 7 of the nonce increment before the full width rollover, but this wasn't a particularly helpful place to test and certainly not worth the 13+ seconds it takes on my machine. This patch bumps the starting nonce to a value much closer to the target, and still including the full-width rollover. Brings solve_effort1k_aa_41_01 down from 13.2 seconds to 0.5 sec for me. For ticket #991 Signed-off-by: Micah Elizabeth Scott <[email protected]>
| * | tor-hspow: Split up hspow_vectors testsMicah Elizabeth Scott2023-08-011-8/+106
| |/ | | | | | | | | | | | | | | | | | | | | This test had one large function for all the verifies and one for all the solves. The solve test was slow enough to be a bottleneck, documented in ticket #991. This patch splits the existing tests up in to one labeled function per solve or verify configuration. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* | Merge branch 'encodable-key-rename' into 'main'Ian Jackson2023-08-026-26/+46
|\ \ | | | | | | | | | | | | | | | | | | keymgr: Replace EncodableKey::to_bytes() with SSH-specific function. Closes #965 See merge request tpo/core/arti!1464
| * | keymgr: Add TODO regarding SshEncodableKey impl for x25519.Gabriela Moldovan2023-08-021-0/+1
| | |
| * | keymgr: Implement SshEncodableKey for ed25519::Keypair.Gabriela Moldovan2023-08-022-4/+10
| | |
| * | keymgr: Remove KeyType::to_ssh_format.Gabriela Moldovan2023-08-023-11/+16
| | | | | | | | | | | | | | | | | | | | | | | | This function isn't actually needed (it's not the responsibility of `KeyType` to encode keys). This commit also rewrites `ArtiNativeKeystore::insert` to use the new `as_ssh_keypair_data` function instead of `to_ssh_format`.
| * | keymgr: Replace EncodableKey::to_bytes() with SSH-specific function.Gabriela Moldovan2023-08-024-12/+20
| |/ | | | | | | | | | | | | | | | | | | | | The `EncodableKey::to_bytes` function didn't make much sense, because not all keys have a canonical byte representation. This commit replaces `EncodableKey::to_bytes` with `EncodableKey::as_ssh_keypair_data`. In the future, `EncodableKey` will grow functions for encoding keys in other storage formats too. Closes #965
* | hashx/bench: Shared generate wrapper for u64-hash and full-hashMicah Elizabeth Scott2023-08-011-11/+14
| | | | | | | | | | | | Code cleanup from review feedback Signed-off-by: Micah Elizabeth Scott <[email protected]>
* | hashx/bench, equix/bench: Enable debug symbolsMicah Elizabeth Scott2023-08-012-0/+10
| | | | | | | | | | | | | | | | Propagates this setting from the outer Cargo.toml to the new benchmark crates, since they no longer get the setting by being included in the main workspace. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* | hashx/bench, equix/bench: check in matching Cargo.lock filesMicah Elizabeth Scott2023-08-014-2/+2208
| | | | | | | | | | | | | | | | It might be useful to keep these locked down for benchmark reproducibility. Currently the hashx and equix crates are fully separate. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* | equix, hashx: Benchmark against C implementationMicah Elizabeth Scott2023-08-0110-185/+444
|/ | | | | | | | | | | | | | | | | | | | | This is a small batch of improvements for the equix and hashx benchmarks. The headline feature is that we are now including the C implementations (slightly modified from tevador's, hosted as part of c-tor) and using them in apples-to-apples comparisons. Minor features: - Benchmarks moved to new nested crates, preventing their dependencies from spilling into the main workspace build. - Tests are now grouped - We also test the performance of memory reuse where possible - Code cleanup for per-runtime options These benchmark builds will now automatically pull in the c-tor git repo and build portions of it with a Rust wrapper. This uses the 'cc' and 'bindgen' crates, so it requires a C compiler and libclang on the host system. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* Upgrade to sanitize-filename 0.5.0Nick Mathewson2023-08-011-1/+1
|
* hsservice: Upgrade tor-keymgr depNick Mathewson2023-08-011-1/+1
| | | | | | This breakage was caused by increasing the version of tor-keymgr and independently merging !1452, which added a dependency on the old version.
* Merge branch 'remove_semver' into 'main'Ian Jackson2023-08-0111-31/+0
|\ | | | | | | | | Remove semver.md files now that 1.1.7 is out. See merge request tpo/core/arti!1460
| * Remove semver.md files now that 1.1.7 is out.Nick Mathewson2023-08-0111-31/+0
| |
* | Merge branch 'hss_apis' into 'main'Nick Mathewson2023-08-019-85/+551
|\ \ | | | | | | | | | | | | | | | | | | hsservice: Initial data structures and APIs Closes #972, #971, and #970 See merge request tpo/core/arti!1452
| * | hsservice: Add a sketched API for HsDir publishers.Nick Mathewson2023-07-312-0/+99
| | | | | | | | | | | | | | | | | | | | | As with the other APIs here, I'd expect that the implementors will need to refactor this a lot. Closes #972.
| * | A couple of notes on intropoint establisher API.Nick Mathewson2023-07-311-1/+10
| | |
| * | hsservice: Add a draft API for intropoint establisher.Nick Mathewson2023-07-312-0/+107
| | | | | | | | | | | | | | | | | | | | | Taken from @diziet's !1439 and lightly cleaned up so that it compiles. Closes #971.
| * | hsservice: Adapt API sketches from onion-service-notes.mdNick Mathewson2023-07-313-0/+44
| | |
| * | hsservice: Adapt data structures from onion-service-notes.mdNick Mathewson2023-07-317-85/+292
| | | | | | | | | | | | | | | | | | | | | Also, removed some older structures that don't make sense in the current design. Closes #970
* | | Add error if [[bridges.transports]] isn't written in config fileSaksham Mittal2023-08-012-10/+203
| |/ |/|
* | Merge branch 'bump_versions_117' into 'main'arti-v1.1.7Nick Mathewson2023-08-0145-211/+211
|\ \ | | | | | | | | | | | | Vesion bumps for 1.1.7. See merge request tpo/core/arti!1458
| * | Bump patchlevel versions of crates with trivial changesNick Mathewson2023-08-0121-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These crates have had trivial changes only: typically, changes to documentation or to clippy warnings. There's no good reason to update which version of them other crates depend on, so we only bump _their_ patchlevels. ``` tor-async-utils caret safelog tor-events tor-units tor-rtcompat tor-rpcbase tor-llcrypto tor-protover tor-bytes tor-hscrypto tor-socksproto tor-cert tor-cell tor-consdiff tor-congestion arti-rpcserver arti-testing arti-bench arti-config arti-hyper ```
| * | Increment patchlevel versions of crates with minor changesNick Mathewson2023-08-0135-133/+133
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These crates are at version 0.x.y, so we don't need to distinguish new-feature changes from other changes: ``` tor-basic-utils fs-mistrust tor-error tor-geoip tor-checkable tor-linkspec tor-netdoc tor-netdir tor-persist tor-ptmgr tor-hsservice ``` This crate has a breaking change, but only when the semver-breaking feature `experimental-api` is enabled: ``` tor-config ``` This crate is at version 1.x.y, but has no new public APIs, and therefore does not need a minor version bump: ``` arti ```
| * | Update minor versions on crates that have had breaking changesNick Mathewson2023-08-0119-60/+60
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These crates had first-order breaking changes: ``` retry-error tor-keymgr tor-proto tor-hsclient tor-rtmock ``` Additionally, these broke because they re-exposed RetryError: ``` tor-circmgr ``` Additionally, these broke because they may re-expose something from tor-proto: ``` arti-client tor-chanmgr tor-dirclient tor-dirmgr tor-guardmgr ``` Additionally, these broke for other fiddly reasons: `tor-ptmgr` implements traits from tor-chanmgr, which has a breaking change above. `arti-hyper` exposes types from arti-client in its API.
* / Run "fixup features" in preparation for a release.Nick Mathewson2023-08-016-7/+7
|/
* equix, hashx: Additional comment tweaksMicah Elizabeth Scott2023-07-275-12/+68
| | | | | | More review feedback. Thanks nickm! Signed-off-by: Micah Elizabeth Scott <[email protected]>
* equix, hashx: Prepare for an initial LGPL releaseMicah Elizabeth Scott2023-07-272-2/+12
| | | | | | | This replaces the 'TODO' marker from earlier commits, using tevador's copyright and license (LGPL 3.0 only) for the hashx and equix crates. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* tor-hspow, equix, hashx: Comment tweaksMicah Elizabeth Scott2023-07-2726-296/+438
| | | | | | Making a few comment tweaks suggested in review feedback. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* tor-hspow: Simplify and optimize Challenge::newMicah Elizabeth Scott2023-07-271-10/+17
| | | | | | | | | Challenges are now built using try_extend_from_slice instead of iterators. There's no CPU benchmark in this crate yet, but I can confirm that the resulting code is shorter. With this patch, the entirety of Challenge:new() is automatically inlined at call sites. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* hashx: Simplify RegisterWriterMapMicah Elizabeth Scott2023-07-271-28/+5
| | | | | | | | | | | | I originally wrote this in an overcomplicated way, to avoid frequent initialization of a RegisterWriter array. It turns out that RegisterWriter can be fairly compact, so this extra level of indirection isn't necessary or measurably helpful. This still manages to avoid declaring RegisterWriter as Copy, by using Default to initialize the array instead of an array constructor. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* tor-hspow, equix, hashx: Make all error types CloneMicah Elizabeth Scott2023-07-274-9/+17
| | | | | | | This uses an Arc to hold std::io::Error for low-level HashX runtime errors. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* hashx: Simplify hash_to_bytes, only support fixed output widthMicah Elizabeth Scott2023-07-272-5/+5
| | | | | | | | | | | | In response to review feedback. The byte output is only needed for unit tests right now, since Equi-X uses u64 output exclusively. The optimization for shorter output widths can shave tiny amounts of time off hash benchmarks, but in this case it's more helpful to avoid introducing APIs that offer parameters with incomplete compile-time range checking. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* hashx: use RngCore for HashX's internal PRNGMicah Elizabeth Scott2023-07-277-302/+381
| | | | | | | | | | | | | | | | | | | | | This refactors the random number generator used within HashX's program generator so that it uses the rand::RngCore trait. The basic SipHash powered u64 generator now implements RngCore, while a buffer layer wraps this and provides u8 and u32 values as needed by the generator. Some of this new RngCore layer is now exposed to the hashx crate's public API. The intent is to allow external code to test, benchmark, or fuzz the program generator by supplying its own random number stream. Benchmarks show a small but confusing performance improvement associated with this patch. About a 2% improvement in generation. This could be due to the Rng changes. No change in compiled hash execution performance. Even though this patch only touches program generation, benchmarks show a 4% speedup in interpreted execution. This seems most likely explained by instruction cache effects, but I'm not sure. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* hashx: Implement Default for RuntimeOptionMicah Elizabeth Scott2023-07-271-11/+4
|
* equix: Refactoring for bucket_arrayMicah Elizabeth Scott2023-07-274-434/+662
| | | | | | | This splits up bucket_array into two smaller modules, one for the hash table behavior and one for the MaybeUninit memory management. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* Update equix, hashx, tor-hspow for new clippy defaultsMicah Elizabeth Scott2023-07-273-3/+3
| | | | Just running maint/add_warning after the rebase
* hashx: register set optimizations, 20% faster generatorMicah Elizabeth Scott2023-07-276-64/+177
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I was hoping most of the program generator would get inlined, so we can resolve a lot of the edge cases at compile-time. This patch gets us close to that, adding many inline attrs and rewriting RegisterSet with explicit unrolling and storage types that are easier for the optimizer to reason about. From the disassembly of the program generator, it's now mostly one big function with a jump table. From callgrind instruction profiles, there are no longer obvious hotspots in register set scanning loops. It also looks like we're often keeping per-register schedule information all loaded into machine registers now. Keeping the Rng entry points non-inlined for now seems to be slightly better, by a percent or two. There's some work left to do in compiled programs, and maybe room for improvement in the Program representation too. That will be in a future patch. Benchmark shows about 20% improvement on my machine, generate-interp time: [75.440 µs 75.551 µs 75.684 µs] change: [-24.083% -23.775% -23.483%] (p = 0.00 < 0.05) Performance has improved. Found 11 outliers among 100 measurements (11.00%) 5 (5.00%) high mild 6 (6.00%) high severe generate-x86_64 time: [96.068 µs 96.273 µs 96.540 µs] change: [-18.699% -18.381% -18.013%] (p = 0.00 < 0.05) Performance has improved. Found 10 outliers among 100 measurements (10.00%) 4 (4.00%) high mild 6 (6.00%) high severe Signed-off-by: Micah Elizabeth Scott <[email protected]>
* Start implementing Proposal 327Micah Elizabeth Scott2023-07-2711-0/+1055
| | | | | | | | | | | | | This adds a new tor-hspow crate with the first layers of support in place for onion service client puzzles as described in Proposal 327. The API here is experimental, and it's currently only implementing the self-contained parts of the client puzzle. So, it can verify and solve puzzles, but it has no event loop integration or nonce replay tracking or prioritization code yet. These things seem like they would eventually live in the same crate. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* Reimplement Equi-X in RustMicah Elizabeth Scott2023-07-2712-0/+1706
| | | | | | | | | | | This is a new pure Rust implementation of the Equi-X algorithm designed by tevador for Tor's onion service proof of work puzzle v1. Equi-X is an asymmetric puzzle algorithm based on Equihash, with N=60, K=3, the XOR replaced with modular addition, a 16-bit index space, and HashX as the inner hash function. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* Reimplement HashX in RustMicah Elizabeth Scott2023-07-2717-0/+3643
| | | | | | | | | | | | | | | | | This is a new pure Rust implementation of the HashX algorithm designed by tevador for Tor's onion service proof of work puzzle v1. HashX is a lightweight family of randomly generated hash functions. A seed, via blake2 and siphash, drives a program generation model which randomly selects opcodes and registers while following some constraints that avoid timing stalls or insufficient hash mixing. The execution of these hash funcions can be done using a pure Rust interpreter, or about 20x faster using a very simple just in time compiler based on the dynasm assembler crate. This has been implemented for x86_64 and aarch64. Signed-off-by: Micah Elizabeth Scott <[email protected]>
* Merge branch 'circuit-reactor-first-hop' into 'main'Nick Mathewson2023-07-271-59/+116
|\ | | | | | | | | tor-proto: Extract Create message handling from Reactor::run_once() See merge request tpo/core/arti!1441
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-28 02:54:20 +0000