mirrors/arti.git - mirror of https://gitlab.torproject.org/tpo/core/arti

	Commit message (Collapse)	Author	Age	Files	Lines
...
* \| \| \|	Precisely cfg-decorate a constant	Ian Jackson	2023-10-31	1	-0/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Peraonally I would prefer \| #![cfg_attr(not(all(feature = "full", feature = "experimental")), \| allow(dead_code))] but I think that is almost certainly controversial. See tpo/core/arti#704.
* \| \| \|	Add cfg_attr allow(unused_imports) to two crates	Ian Jackson	2023-10-31	2	-0/+12
\|/ / / \| \| \| \| \| \| \| \| \| \| \| \|	As per this comment, and preceding discussion https://gitlab.torproject.org/tpo/core/arti/-/issues/1060#note_2959187
* \| \|	Merge branch 'timeout' into 'main'	Ian Jackson	2023-10-30	1	-25/+83
\|\ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	timeout_track improvements See merge request tpo/core/arti!1711
\| * \| \|	Fix typo in doc comment	gabi-250	2023-10-30	1	-1/+1
\| \| \| \|
\| * \| \|	tor-hsservice: timeout_track: Test `update` functions	Ian Jackson	2023-10-30	1	-2/+30
\| \| \| \|
\| * \| \|	tor-hsservice: timeout_track: Provide `update` via a trait	Ian Jackson	2023-10-30	1	-25/+53
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We have a profusion of similar methods with similar names and similar documentation. Centralising the documentation in a trait is helpful. This also means that callers can just naturally call `.update` rather than needing to spell out `.update_abs` vs `.update_rel` etc.
\| * \| \|	tor-hsservice: timeout_track: Clarify edge cases	Ian Jackson	2023-10-30	1	-2/+4
\| \|/ / \| \| \| \| \| \| \| \| \| \| \| \|	Clarify this in the update functions, and in the general discussion. We don't want zero timeouts.
* \| \|	tor-netdoc: Use the new HandshakeType enum to represent CREATE2 HTYPEs (fmt).	Gabriela Moldovan	2023-10-30	1	-17/+21
\| \| \|
* \| \|	tor-netdoc: Use the new HandshakeType enum to represent CREATE2 HTYPEs.	Gabriela Moldovan	2023-10-30	5	-16/+20
\|/ / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Representing the supported HTYPEs as `HandshakeType`s instead of `u32`s makes it more difficult to pass in wrong/invalid values to `HsDescBuilder::create2_formats`. This also fixes a descriptor publisher bug spotted by @jnewsome, where the advertised CREATE2 HTYPEs included HTYPE `1`, which is actually supposed to be a reserved value. The publisher now only advertises the `NTOR` HTYPE (just like C Tor).
* \|	Run "fixup-features" in preparation for release this week.	Nick Mathewson	2023-10-29	9	-9/+9
\| \|
* \|	Remove a broken rustdoc link and fix a typo.	Nick Mathewson	2023-10-27	1	-3/+0
\| \|
* \|	Add a caret_int HandshakeType for HTYPE constants	Jim Newsome	2023-10-26	6	-12/+41
\| \|
* \|	Merge branch 'opt-circid' into 'main'	Nick Mathewson	2023-10-26	18	-215/+306
\|\ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Make StreamId and CircId NonZero Closes #1080 See merge request tpo/core/arti!1697
\| * \|	Change `CircId` to never be zero	Jim Newsome	2023-10-25	11	-95/+154
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This changes the internal representation to be `NonZeroU32` instead of just `u32`. Various places where a circuit ID is optional now use `Option<CircId>`. Fixes a bug in `CircIdRange::sample` that would previously return a circuit ID of 0, when the rng returned 0x8000_0000 for a low range.
\| * \|	Convert StreamId to NonZeroU16	Jim Newsome	2023-10-25	10	-120/+152
\| \| \|
* \| \|	Merge branch 'tweaks' into 'main'	Ian Jackson	2023-10-26	2	-4/+4
\|\ \ \ \| \|/ / \|/\| \| \| \| \| \| \| \|	Tiny cleanup refactors See merge request tpo/core/arti!1696
\| * \|	AbstractCircMgr::get_or_launch: inline wait_for_circ	Jim Newsome	2023-10-25	1	-2/+1
\| \| \|
\| * \|	AbstractCircMgr::get_or_launch: document MSRV where div_ceil was stabilized	Jim Newsome	2023-10-25	1	-1/+2
\| \| \|
\| * \|	handle_socks_conn: update parameter name in doc comment	Jim Newsome	2023-10-25	1	-1/+1
\| \| \|
* \| \|	tor-cert, tor-netdoc: Use EncodedEd25519Cert instead of Vec<u8>.	Gabriela Moldovan	2023-10-25	5	-13/+11
\| \| \|
* \| \|	tor-cert: Add EncodedEd25519Cert type.	Gabriela Moldovan	2023-10-25	4	-0/+17
\| \| \|
* \| \|	tor-netdoc: Change return type of create_desc_sign_key_cert.	Gabriela Moldovan	2023-10-25	2	-8/+8
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	`Bug` wasn't necessarily the right error type here. Plus, with the new error type adding new errors (i.e. `CertEncodeError` variants), is not a breaking change.
* \| \|	tor-netdoc: Update outdated doc string.	Gabriela Moldovan	2023-10-25	1	-1/+1
\| \| \|
* \| \|	tor-netdoc: Building a descriptor now only requires the public part of ↵	Gabriela Moldovan	2023-10-25	3	-9/+12
\| \| \| \| \| \| \| \| \| \| \| \|	blinded_id.
* \| \|	tor-netdoc: Remove now-unused blinded_id field.	Gabriela Moldovan	2023-10-25	2	-7/+0
\| \| \|
* \| \|	tor-netdoc: Update HsDesc, HsDescOuter to accept the hs_desc_sign cert as an ↵	Gabriela Moldovan	2023-10-25	4	-24/+43
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	argument. This will enable us to (eventually) the load the descriptor signing key cert from the keystore (as opposed to always recomputing it when building the `HsDesc`). Part of #1048
* \| \|	tor-netdoc: Add helper function for computing the descriptor signing key cert.	Gabriela Moldovan	2023-10-25	4	-15/+35
\|/ /
* \|	Merge branch 'todo-hss-misc' into 'main'	Alexander Færøy	2023-10-25	8	-55/+30
\|\ \ \| \| \| \| \| \| \| \| \| \| \| \|	Resolve some simpler TODO HSS items. See merge request tpo/core/arti!1701
\| * \|	hss: remove some more now-moot "allows".	Nick Mathewson	2023-10-24	2	-4/+0
\| \| \|
\| * \|	hss::svc::publish: Remove a no-longer-needed TODO HSS.	Nick Mathewson	2023-10-24	1	-3/+0
\| \| \|
\| * \|	hss::svc::publish: Resolve previously suppressed warnings.	Nick Mathewson	2023-10-24	3	-13/+8
\| \| \|
\| * \|	hss::svc::ipt_establish: Include nickname in messages.	Nick Mathewson	2023-10-24	1	-2/+4
\| \| \|
\| * \|	hss::svc::ipt_establish: Resolve suppressed warnings.	Nick Mathewson	2023-10-24	2	-16/+12
\| \| \|
\| * \|	hsserive::req: Yes, leave these functions as async and fallible.	Nick Mathewson	2023-10-24	1	-8/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Enough of them have turned out to need to be async so far that I don't think it's a great idea to commit to making any of them not-async forever. Additionally, we've written the code that uses these, and having them be async didn't seem to cause any major trouble. By the same "we may want to make these more complicated underneath" argument, we should IMO leave them as fallible.
\| * \|	hsserive::req: Lower/remove allowed warnings	Nick Mathewson	2023-10-24	1	-2/+1
\| \| \|
\| * \|	hss: Remove an unused type.	Nick Mathewson	2023-10-24	1	-7/+0
\| \| \|
* \| \|	hsclient: Rename get_or_launch{connection => circuit}	Nick Mathewson	2023-10-24	2	-2/+26
\|/ / \| \| \| \| \| \|	Closes #1078.
* \|	tor-keymgr: Use a macro to declare the KeyType enum (fmt).	Gabriela Moldovan	2023-10-24	1	-46/+46
\| \|
* \|	tor-keymgr: Use a macro to declare the KeyType enum.	Gabriela Moldovan	2023-10-24	1	-40/+62
\| \| \| \| \| \| \| \| \| \|	The bad identation is there to make reviewing the diff easier (the macro will be reindented in a future commit).
* \|	tor-keymgr: Stop open-coding range operations.	Gabriela Moldovan	2023-10-24	1	-6/+1
\| \|
* \|	tor-dirclient, tor-netdoc: Add TODO SPECs.	Gabriela Moldovan	2023-10-24	2	-0/+4
\| \|
* \|	tor-dirclient: Always set the Content-Length header (fmt).	Gabriela Moldovan	2023-10-24	1	-1/+4
\| \|
* \|	tor-dirclient: Always set the Content-Length header.	Gabriela Moldovan	2023-10-24	2	-19/+12
\| \|
* \|	tor-hsservice: Look up the keypair, not the public key.	Gabriela Moldovan	2023-10-24	1	-5/+5
\| \| \| \| \| \| \| \| \| \|	This particular public key is not stored in the keystore (though maybe it should be).
* \|	tor-keymgr: Rename key_stores to secondary_stores for clarity.	Gabriela Moldovan	2023-10-24	1	-8/+8
\| \| \| \| \| \| \| \| \| \| \| \|	The name `key_stores` was a bit misleading, as this field only contains the _secondary_ key stores (the primary/default key store is stored in a separate field).
* \|	tor-keymgr: list() should include the keys from the default key store.	Gabriela Moldovan	2023-10-24	1	-2/+1
\| \| \| \| \| \| \| \| \| \|	`KeyMgr::list()` was supposed to look in _all_ key stores, not just the secondary ones.
* \|	tor-keymgr: Fix broken glob pattern.	Gabriela Moldovan	2023-10-24	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \|	The pattern was only supposed to match the 3 components of the time period, separated by `_`, but not the leading `_`, which separates the key name from its denotators.
* \|	tor-keymgr: Remove now-outdated TODO HSS.	Gabriela Moldovan	2023-10-24	1	-9/+0
\| \| \| \| \| \| \| \|	Key file extensions now have `_private`/`_public` suffixes again.
* \|	tor-keymgr: Add TODO explaining why we're not using strum.	Gabriela Moldovan	2023-10-24	1	-0/+7
\| \|
* \|	tor-keymgr: Use the right extension for expanded ed25519 keys.	Gabriela Moldovan	2023-10-24	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \|	This line was out of sync with `KeyType::arti_extension`, which uses `ed25519_expanded_private` as the extension (and not `ed25519_expanded`).