| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| | * | | tor-hsservice: Fix broken doc link. | Gabriela Moldovan | 2023-12-14 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | Merge branch 'return-of-the-son-of-arti-todos' into 'main' | Nick Mathewson | 2023-12-14 | 4 | -59/+140 | |
| |\ \ \ | |_|/ |/| | | | | | | | | Resolve Arti crate todos, redux See merge request tpo/core/arti!1833 | |||||
| | * | | Trivial case fix in a comment. | Ian Jackson | 2023-12-14 | 1 | -1/+1 | |
| | | | | ||||||
| | * | | arti: Add a todo to describe how and why to test build_list. | Nick Mathewson | 2023-12-13 | 1 | -0/+7 | |
| | | | | ||||||
| | * | | arti: Use BTreeMap for maps of onion service configs. | Nick Mathewson | 2023-12-13 | 1 | -9/+9 | |
| | | | | ||||||
| | * | | arti: Simplify build_list slightly | Nick Mathewson | 2023-12-13 | 1 | -4/+3 | |
| | | | | ||||||
| | * | | arti: Use a macro to declare modules as conditionally public. | Nick Mathewson | 2023-12-13 | 1 | -25/+36 | |
| | | | | | | | | | | | | | | | | (We can't use `visibility::make(pub)` or `visible` here. Try it yourself if you don't believe me!) | |||||
| | * | | arti: Test for expected value of onion service cfg. | Nick Mathewson | 2023-12-12 | 1 | -2/+34 | |
| | | | | ||||||
| | * | | arti: resolve a TODO in onion_proxy launch_new. | Nick Mathewson | 2023-12-12 | 1 | -7/+2 | |
| | | | | ||||||
| | * | | arti: rethink a TODO HSS about nicknames | Nick Mathewson | 2023-12-12 | 1 | -1/+9 | |
| | | | | | | | | | | | | | | | | | | | The TODO HSS in question is about our inability to serialize every possible builder. The right answer here might be to use something else instead of a ListBuilder. | |||||
| | * | | arti: Enforce onion service nickname distinctness | Nick Mathewson | 2023-12-12 | 2 | -18/+39 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The most logical way to do this was to change the "List" type to a HashMap, and add a build function to the ListBuilder. This change additionally renames: OnionServiceProxyConfig{List=>Map} NamedProxyMap => ProxyBuilderMap (We now have two kinds of map, and this name change will clarify the distinction.) | |||||
| | * | | arti: Downgrade a TODO HSS about testing onion-service config. | Nick Mathewson | 2023-12-12 | 1 | -1/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | IIUC, there will never be a Some(InNew) entry here, since we will never have an onion service be configured by default. Instead we test this kind of configuration by having commented-out options that we uncomment as needed. | |||||
| | * | | arti: Generalize a TODO HSS about reconfiguration. | Nick Mathewson | 2023-12-12 | 2 | -1/+10 | |
| | | | | | | | | | | | | | | | | | | | It's correct that we'd like someday for the `arti` crate APIs to allow all the different modes supported by `Reconfigure` enum; this is #1156, and it does not block an HSS release. | |||||
| | * | | arti: conditionally expose onion_proxy module when experimental-api is enabled | Nick Mathewson | 2023-12-12 | 1 | -4/+4 | |
| | | | | ||||||
| | * | | Remove TODOs obsoleted by onion service reconfiguration. | Nick Mathewson | 2023-12-12 | 2 | -2/+0 | |
| | | | | | | | | | | | | | (This was solved with !1798) | |||||
| * | | | Merge branch 'hss-cli' into 'main' | gabi-250 | 2023-12-14 | 5 | -2/+116 | |
| |\ \ \ | | | | | | | | | | | | | | | | | arti: Add an hss subcommand. See merge request tpo/core/arti!1837 | |||||
| | * | | | tor-hsservice: Add TODO about rethinking the HSS StateMgr API. | Gabriela Moldovan | 2023-12-14 | 1 | -0/+3 | |
| | | | | | ||||||
| | * | | | arti: Print out the onion address retrieved from StateMgr. | Gabriela Moldovan | 2023-12-14 | 1 | -1/+15 | |
| | | | | | ||||||
| | * | | | tor-hsservice: Add an hss state mgmt API | Gabriela Moldovan | 2023-12-14 | 2 | -0/+47 | |
| | | | | | ||||||
| | * | | | arti-client: Add an accessor for the keystore config. | Gabriela Moldovan | 2023-12-14 | 2 | -0/+6 | |
| | | | | | ||||||
| | * | | | arti: Add an hss subcommand. | Gabriela Moldovan | 2023-12-14 | 1 | -2/+46 | |
| | | |/ | |/| | | | | | | | Part of #1071 | |||||
| * | | | ChannelState::ready_to_expire: return true when rem time is zero | Jim Newsome | 2023-12-13 | 1 | -0/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a race condition that would normally be fairly benign - it would result in scheduling to check for expired channels again immediately, and assuming non-zero time passes would then remove the channel. In Shadow's default time model though, zero time passes in this case, so we just keep scheduling to check again immediately forever; i.e. deadlock. | |||||
| * | | | ChannelState::ready_to_expire: refactor using let-else | Jim Newsome | 2023-12-13 | 1 | -18/+14 | |
| | | | | ||||||
| * | | | continually_expire_channels: don't round off expiration delay | Jim Newsome | 2023-12-13 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this change, if the delay is less than one second, the code will effectively busy-loop until the delay has elapsed. This potentially leads to deadlock in shadow simulations, and wastes CPU in real usage. https://shadow.github.io/docs/guide/limitations.html?highlight=busy#busy-loops | |||||
| * | | | continually_expire_channels: refactor using let-else | Jim Newsome | 2023-12-13 | 1 | -3/+2 | |
| |/ / | ||||||
| * | | Merge branch 'todos-hss' into 'main' | Nick Mathewson | 2023-12-13 | 3 | -25/+29 | |
| |\ \ | | | | | | | | | | | | | Clear away some misc todos in tor-hsservice. See merge request tpo/core/arti!1819 | |||||
| | * | | hss: Explain why wait_for_netdir_to_list does not need more complexity. | Nick Mathewson | 2023-12-13 | 1 | -6/+11 | |
| | | | | ||||||
| | * | | hss::svc::netdir: Explain why it is okay to suppress errors. | Nick Mathewson | 2023-12-12 | 1 | -1/+3 | |
| | | | | ||||||
| | * | | hss::config: Downgrade or remove some TODO HSS comments. | Nick Mathewson | 2023-12-12 | 1 | -16/+15 | |
| | | | | ||||||
| | * | | hss: remove TODO about making DangerouslyNonAnonymous conditional. | Nick Mathewson | 2023-12-12 | 1 | -2/+0 | |
| | | | | ||||||
| * | | | Merge branch 'log_hsid_unconditionally' into 'main' | Nick Mathewson | 2023-12-13 | 1 | -14/+20 | |
| |\ \ \ | | | | | | | | | | | | | | | | | hsservice: Log hsid whether we just generated it or not. See merge request tpo/core/arti!1830 | |||||
| | * | | | tor-hsservice: Retrieve the public hsid for logging purposes. | gabi-250 | 2023-12-13 | 1 | -3/+3 | |
| | | | | | ||||||
| | * | | | hsservice: Log hsid whether we just generated it or not. | Nick Mathewson | 2023-12-13 | 1 | -14/+20 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | With this change you can find your hsid in your logs (if safe logging is off) even if you forgot to notice it the first time around. | |||||
| * | | | | Merge branch 'keymgr_enabled_default' into 'main' | Nick Mathewson | 2023-12-13 | 2 | -24/+14 | |
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | arti_client: Cleanup around keymgr feature and config See merge request tpo/core/arti!1832 | |||||
| | * | | | | arti_config: remove experimental-api as way to enable keymgr. | Nick Mathewson | 2023-12-13 | 1 | -7/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | keymgr is always on when it is needed, so experimental-api isn't needed here. | |||||
| | * | | | | arti-client: use sub_builder for ArtiNativeKeystoreConfig | Nick Mathewson | 2023-12-13 | 2 | -10/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The sub_builder pattern changes `StorageConfigBuilder` so that instead of holding an `Option<ArtiNativeKeystoreConfig>`, it holds an `ArtiNativeKeystoreConfigBuilder`. This makes it a little more ergonomic to use from Rust, and lets us use defaults for the builder fields so that we can make them optional in our configuration. | |||||
| | * | | | | arti_client: enable keymgr when keymgr feature is configured | Nick Mathewson | 2023-12-13 | 1 | -11/+9 | |
| | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | This change causes arti_client to have a configurable keymgr when the onion-service-service feature is present, so that you no longer need to configure "experimental" or "experimental-api" as well in order to get a working onion service. | |||||
| * | | | | Merge branch 'circmgr_warning' into 'main' | Nick Mathewson | 2023-12-13 | 1 | -2/+3 | |
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | circmgr:Resolve a warning when building without ntor-v3 See merge request tpo/core/arti!1831 | |||||
| | * | | | | circmgr:Resolve a warning when building without ntor-v3 | Nick Mathewson | 2023-12-13 | 1 | -2/+3 | |
| | |/ / / | ||||||
| * | | | | Merge branch 'publisher-do-not-retry-fatal' into 'main' | gabi-250 | 2023-12-13 | 1 | -16/+1 | |
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | tor-hsservice: If the error is fatal, do not retry the desc upload. See merge request tpo/core/arti!1821 | |||||
| | * | | | | tor-hsservice: If the error is fatal, do not retry the desc upload. | Gabriela Moldovan | 2023-12-13 | 1 | -16/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The errors returned by `upload_all` are now all fatal, so we there is no point in retrying `upload_all` on failure. Note this will exacerbate #1155, as it will cause the seemingly transient time skew issues to become fatal (the corresponding error type is `Bug`, so in principle they ought to be fatal) | |||||
| * | | | | | arti-client: TorClient.storage_mistrust: Correct doc comment | Ian Jackson | 2023-12-13 | 1 | -1/+6 | |
| | | | | | | ||||||
| * | | | | | tor-hsservice: Add more explanation of replay_log locking | Ian Jackson | 2023-12-13 | 1 | -0/+5 | |
| | | | | | | ||||||
| * | | | | | tor-hsservice: Add more explanation of replay_log locking | Ian Jackson | 2023-12-13 | 1 | -0/+6 | |
| | | | | | | ||||||
| * | | | | | tor-hsservice: Cargo.toml: sort | Ian Jackson | 2023-12-13 | 1 | -1/+1 | |
| | | | | | | ||||||
| * | | | | | tor-hsservice: replay: Note a bug | Ian Jackson | 2023-12-13 | 1 | -0/+4 | |
| | | | | | | ||||||
| * | | | | | tor-hsservice: Make IPT logs be persistent (fmt) | Ian Jackson | 2023-12-13 | 1 | -1/+3 | |
| | | | | | | ||||||
| * | | | | | tor-hsservice: Make IPT logs be persistent | Ian Jackson | 2023-12-13 | 3 | -7/+88 | |
| | | | | | | ||||||
| * | | | | | tor-hsservice ipt_mgr: Rename STORAGE_RETRY from KEYSTORE_RETRY | Ian Jackson | 2023-12-13 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | We're going to reuse this for other kinds of storage error. | |||||
| * | | | | | tor-hsservice: Plumb state dir and its mistrust into ipt_mgr (fmt) | Ian Jackson | 2023-12-13 | 1 | -5/+2 | |
| | | | | | | ||||||
