| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | hsservice: Turn FatalError todo into part of #1083. | Nick Mathewson | 2024-01-12 | 1 | -2/+2 | |
| | | ||||||
| * | hsservice: Downgrade TODO HSS about internal fn on IptStoreError | Nick Mathewson | 2024-01-12 | 1 | -1/+1 | |
| | | ||||||
| * | hsservice: Move "Cleanup ErrorKind" TODOs to #1225. | Nick Mathewson | 2024-01-12 | 3 | -7/+7 | |
| | | ||||||
| * | hsservice: Convert TODO about circuit lifetimes to #1224 | Nick Mathewson | 2024-01-12 | 1 | -1/+1 | |
| | | | | | This one is a MUST. | |||||
| * | hsservice: Convert a "TODO" to a ticket about logic duplication | Nick Mathewson | 2024-01-12 | 2 | -1/+4 | |
| | | | | | New ticket is #1223. | |||||
| * | hsservice: Downgrade TODO about possible moving of a check. | Nick Mathewson | 2024-01-12 | 1 | -1/+1 | |
| | | ||||||
| * | hsservice: Remove TODO about IntroRequestError variants. | Nick Mathewson | 2024-01-12 | 1 | -1/+1 | |
| | | | | | | IMO it's okay that these 3 variants have similar names: we wouldn't really want to rename them to anything else. | |||||
| * | hsservice: Downgrade TODO HSS about having a type not be Clone. | Nick Mathewson | 2024-01-12 | 1 | -1/+1 | |
| | | | | | The type is crate-internal, so changing this is not blocking. | |||||
| * | hsservice: Convert TODOs about status to "TODO (#1083)" | Nick Mathewson | 2024-01-12 | 1 | -5/+5 | |
| | | ||||||
| * | hsservice: Downgrade TODO HSS comments about adding accessors. | Nick Mathewson | 2024-01-12 | 1 | -2/+2 | |
| | | | | | We can add these accessors as needed. | |||||
| * | hsservice: Remove unused proof-of-work enum | Nick Mathewson | 2024-01-12 | 1 | -14/+0 | |
| | | | | | When we implement this, we'll use APIs from the equix crate. | |||||
| * | Merge branch 'publisher-todo-triage' into 'main' | Nick Mathewson | 2024-01-12 | 5 | -78/+39 | |
| |\ | | | | | | | | | tor-hsservice: Triage descriptor publisher TODOs See merge request tpo/core/arti!1875 | |||||
| | * | tor-hsservice: Turn a TODO HSS into #1219. | Gabriela Moldovan | 2024-01-11 | 1 | -1/+1 | |
| | | | ||||||
| | * | tor-hsservice: Turn a TODO HSS into #1218. | Gabriela Moldovan | 2024-01-11 | 1 | -1/+1 | |
| | | | ||||||
| | * | tor-hsservice: Remove two misleading TODO HSS. | Gabriela Moldovan | 2024-01-11 | 1 | -5/+0 | |
| | | | | | | | | | There is no point in retrying after all our retries have failed. | |||||
| | * | tor-hsservice: Turn a TODO into #1217. | Gabriela Moldovan | 2024-01-11 | 1 | -1/+1 | |
| | | | ||||||
| | * | tor-hsservice: Downgrade some TODO HSS. | Gabriela Moldovan | 2024-01-11 | 2 | -2/+2 | |
| | | | ||||||
| | * | Revert "tor-hsservice: Make descriptor publisher wait for shutdown signal." | Gabriela Moldovan | 2024-01-11 | 3 | -34/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 73559bad575e9e9cecb2a57828344a3702fa44de. See https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1812#note_2976757 (This really should've been reverted before merging, but better late than never). Addresses a TODO HSS. | |||||
| | * | tor-hsservice: Turn a TODO HSS into #1106. | Gabriela Moldovan | 2024-01-11 | 1 | -1/+1 | |
| | | | ||||||
| | * | tor-hsservice: Remove no longer relevant TODO HSS. | Gabriela Moldovan | 2024-01-11 | 1 | -3/+0 | |
| | | | | | | | | | The publisher _does_ watch for config changes. | |||||
| | * | tor-hsservice: Turn some TODOs into #1216, #1098. | Gabriela Moldovan | 2024-01-11 | 1 | -7/+7 | |
| | | | ||||||
| | * | tor-hsservice: Turn some TODOs into #1083. | Gabriela Moldovan | 2024-01-11 | 2 | -4/+4 | |
| | | | ||||||
| | * | tor-hsservice: Turn some TODOs into #1194. | Gabriela Moldovan | 2024-01-11 | 1 | -3/+3 | |
| | | | ||||||
| | * | tor-hsservice: Turn a TODO into #955. | Gabriela Moldovan | 2024-01-11 | 1 | -1/+1 | |
| | | | ||||||
| | * | tor-hsservice: Turn some TODOs into #1206. | Gabriela Moldovan | 2024-01-11 | 2 | -3/+3 | |
| | | | ||||||
| | * | tor-hsservice: Turn a TODO into #1028. | Gabriela Moldovan | 2024-01-11 | 1 | -1/+1 | |
| | | | ||||||
| | * | tor-hsservice: Turn some TODOs into #1121. | Gabriela Moldovan | 2024-01-11 | 1 | -5/+5 | |
| | | | ||||||
| | * | tor-hsservice: Turn some TODOs into #1120. | Gabriela Moldovan | 2024-01-11 | 2 | -6/+6 | |
| | | | ||||||
| * | | Merge branch 'state' into 'main' | Nick Mathewson | 2024-01-12 | 4 | -0/+661 | |
| |\ \ | | | | | | | | | | | | | Proposed new state facility See merge request tpo/core/arti!1853 | |||||
| | * | | state_dir sketch: Explain why we take slugs, effectively, as str | Ian Jackson | 2024-01-12 | 1 | -0/+5 | |
| | | | | ||||||
| | * | | state_dir sketch: Remove some docs whitespace | Ian Jackson | 2024-01-12 | 1 | -2/+2 | |
| | | | | ||||||
| | * | | state_dir sketch: Use KIND/INSTANCE rather than KIND_INSTANCE | Ian Jackson | 2024-01-12 | 1 | -10/+10 | |
| | | | | | | | | | | | | | | | | | | | Both my colleages prefer it that way. There's no implementation yet to change. | |||||
| | * | | state_dir sketch: Introduce InstanceRawSubdir including the lock guard | Ian Jackson | 2024-01-12 | 1 | -2/+17 | |
| | | | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2983413 | |||||
| | * | | state_dir sketch: Reference the slug ticket | Ian Jackson | 2024-01-12 | 1 | -0/+4 | |
| | | | | ||||||
| | * | | state_dir sketch: Provide a comprehensive example | Ian Jackson | 2024-01-12 | 1 | -0/+70 | |
| | | | | ||||||
| | * | | state_dir sketch: Fix API: InstanceIdString | Ian Jackson | 2024-01-12 | 1 | -1/+21 | |
| | | | | | | | | | | | | | It should have as_ref and as_str and Display and TryFrom<String>. | |||||
| | * | | state_dir sketch: Fix API: Fallible methods | Ian Jackson | 2024-01-12 | 1 | -3/+3 | |
| | | | | | | | | | | | | | Some methods were missing the Result. | |||||
| | * | | state_dir sketch: Fix API: Fix Slug | Ian Jackson | 2024-01-12 | 1 | -3/+5 | |
| | | | | | | | | | | | | | | | | We need to implement it. And we need to take it ?Sized so that &str works without the user having to write another &. | |||||
| | * | | state_dir sketch: Fix API: Add missing self paraemeters | Ian Jackson | 2024-01-12 | 1 | -2/+2 | |
| | | | | ||||||
| | * | | state_dir sketch: Fix API: make things pub | Ian Jackson | 2024-01-12 | 1 | -8/+8 | |
| | | | | | | | | | | | | | These should have been pub all along. | |||||
| | * | | state_dir sketch: Make the module public for doctests | Ian Jackson | 2024-01-12 | 2 | -1/+7 | |
| | | | | | | | | | | | | | This will let us make a tested example in the module doc. | |||||
| | * | | state_dir sketch: Pass more information to dispose | Ian Jackson | 2024-01-12 | 2 | -3/+22 | |
| | | | | | | | | | | | | | | | | Provide the last modification time too, since we have it. This allows handlers to things not contemplated by the convenience API. | |||||
| | * | | state_dir sketch: Fix purge trait API | Ian Jackson | 2024-01-12 | 1 | -13/+32 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | This needs to take a value. The caller is going to have some context, eg a configured list of instances. This means that it no longer has InstanceIdentity as a supertrait. Have the purge handler return the retain for time as a method. | |||||
| | * | | state_dir sketch: Rename "expire" to "purge" | Ian Jackson | 2024-01-12 | 1 | -9/+9 | |
| | | | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2983029 | |||||
| | * | | state_dir sketch: Make flock guards and locking clearer | Ian Jackson | 2024-01-12 | 1 | -3/+8 | |
| | | | | ||||||
| | * | | state_dir sketch: Rename Liveness::PossiblyUnused from Unused | Ian Jackson | 2024-01-12 | 1 | -3/+5 | |
| | | | | | | | | | | | | | | | | | | | It is OK to return this even for used things, or if you don't know - the API user (trait implementor) gets a second bite at the cherry in `dispose`. | |||||
| | * | | state_dir sketch: Make an ExpirableInstanceIdentity trait | Ian Jackson | 2024-01-12 | 1 | -10/+31 | |
| | | | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2982352 | |||||
| | * | | state_dir sketch: Make an InstanceIdentity trait | Ian Jackson | 2024-01-12 | 1 | -19/+45 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This gives us somewhere central to hang the rules about names, and avoids us passing un-typed strings into the StateDirectory methods. This inhibits certain kinds of future dynamism, without more work, but that's fine. (It also produces more generics in the functions, but we can avoid too much monomorphisation with the inner function pattern.) Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2982354 | |||||
| | * | | state_dir sketch: Make a Slug trait | Ian Jackson | 2024-01-12 | 1 | -7/+36 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This gives us somewhere central to hang the rules about slugs. (The trait is just an alias for ToString.) Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2982354 | |||||
| | * | | state_dir sketch: Rename InstanceIdString (from InstanceIdentity) | Ian Jackson | 2024-01-12 | 1 | -5/+5 | |
| | | | | | | | | | | | | | | | | We're going to want the InstanceIdentity name for a trait. Also this is clearer I think. | |||||
