| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| | * | | | tor-hsservice: Fix hsid being logged inappropriately. | Gabriela Moldovan | 2023-10-19 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | The condition for logging the "generated a new identity.." message was wrong (`generate_with_derive()` returns `Some(())` if it generated a new key, and `None` if the key was already present). | |||||
| | * | | | tor-hsservice: Log newly generated HsIds. | Gabriela Moldovan | 2023-10-19 | 1 | -2/+16 | |
| | | | | | ||||||
| | * | | | tor-hscrypto: Add a From<&HsIdKeypair> impl for HsIdKey. | Gabriela Moldovan | 2023-10-19 | 2 | -0/+7 | |
| | |/ / | | | | | | | | | | | | | | | | | | | | | | Sometimes it's useful to have the ability to derive the `HsIdKey` from the keypair (for example, if we've just read the `HsIdKeypair` from the keystore and also need the `HsIdKey`, this `From` impl enables us to derive the public part of the key, instead of having to read it from the keystore). | |||||
| * | | | Merge branch 'tricky_terminate' into 'main' | Nick Mathewson | 2023-10-19 | 5 | -181/+151 | |
| |\ \ \ | |/ / |/| | | | | | | | | | | | | | | Refactor the stream-closing logic in tor-proto Closes #1065 See merge request tpo/core/arti!1681 | |||||
| | * | | proto: Revise the behavior of IncomingStream::discard(). | Nick Mathewson | 2023-10-19 | 4 | -22/+47 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because dropping a `StreamTarget` causes the circuit reactor to send an End, the previous do-nothing implementation of `discard()` wasn't sufficient to cause the request to be ignored without sending an End. This commit modifies our "close pending stream" behavior to only optionally send an End message. To avoid confusion, I'm using a new `CloseStreamBehavior` enum rather than an `Option<End>`, since we had previously used `None` in some cases to indicate a default (misc) end message. | |||||
| | * | | IncomingStream:: flatten IncomingStreamInner. | Nick Mathewson | 2023-10-19 | 1 | -13/+11 | |
| | | | | ||||||
| | * | | IncomingStream: Remove state. | Nick Mathewson | 2023-10-19 | 2 | -67/+5 | |
| | | | | | | | | | | | | | | | | | | | Now that every state-change function consumes the IncomingStream, there is no longer any reason to keep track of an internal state enum. | |||||
| | * | | Note a bug in IncomingStream::discard. | Nick Mathewson | 2023-10-19 | 1 | -0/+2 | |
| | | | | ||||||
| | * | | Remove IncomingStreamInner from its Option. | Nick Mathewson | 2023-10-19 | 1 | -34/+7 | |
| | | | | | | | | | | | | | | | | Now that IncomingStream doesn't implement Drop, we can just destructure it. | |||||
| | * | | Remove impl Drop from IncomingStream | Nick Mathewson | 2023-10-19 | 1 | -11/+4 | |
| | | | | | | | | | | | | | | | | Since dropping a StreamTarget will send an End, we don't need to call reject_internal in this case. | |||||
| | * | | proto: Remove TODOs about panics on double-close. | Nick Mathewson | 2023-10-19 | 2 | -31/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | Now that `StreamMap::terminate` no longer panics, and now that it permits the kind of double-call that we allow, we can close #1065. Closes #1065. | |||||
| | * | | proto: Have EndSent remember if we have dropped the stream target. | Nick Mathewson | 2023-10-19 | 2 | -14/+46 | |
| | | | | | | | | | | | | | | | | The rule is that we allow up to one explicit `close_pending`, followed by exactly one final `mpsc::Sender` drop. | |||||
| | * | | proto: Give StreamMap::terminate a "why" argument | Nick Mathewson | 2023-10-19 | 2 | -7/+45 | |
| | | | | | | | | | | | | | | | | We will use this to enforce correct ordering on "close" vs "drop" APIs. | |||||
| * | | | tor-hsservice: Print error sources for descriptor upload errors | Ian Jackson | 2023-10-19 | 1 | -1/+3 | |
| | | | | ||||||
| * | | | tor-hsservice: Fix downcast | Ian Jackson | 2023-10-19 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | Downcasting is tricksy. We need to try the downcast on a type-erased &IptEstablisher, not &Box<dyn Any>, and if we don't dereference nothing tells us it's wrong since &Box<dyn Any> also implements and we end up with &Box<dyn Any> as &dyn Any. | |||||
| * | | | tor-hsservice: Add a TODO for logging HS status | Ian Jackson | 2023-10-19 | 1 | -0/+6 | |
| | | | | ||||||
| * | | | tor-hsservice: Adjust log level of IPT relay choice failure | Ian Jackson | 2023-10-19 | 1 | -6/+15 | |
| | | | | | | | | | | | | | | | | | | | If it's due to lack of useable netdir, that's normal during startup, so don't log it. Hopefully something else somewhere will log if a consensus can't be obtained. | |||||
| * | | | tor-hsservice: Bump log level of main termination message | Ian Jackson | 2023-10-19 | 1 | -2/+2 | |
| | | | | ||||||
| * | | | tor-hsservice: impl HasKind for ChooseIptError | Ian Jackson | 2023-10-19 | 1 | -1/+14 | |
| | | | | | | | | | | | | | We want to pass one of these to info_report!, which demands HasKind. | |||||
| * | | | tor-hsservice: Declare an IPT that fails during Establishing to be Faulty | Ian Jackson | 2023-10-19 | 1 | -1/+5 | |
| | | | | | | | | | | | | | If we don't do this then the manager won't ever select a replacement. | |||||
| * | | | tor-hsservice: Do not claim a completely broken IPT wants to retire | Ian Jackson | 2023-10-19 | 1 | -1/+6 | |
| | | | | ||||||
| * | | | HSS: Do not drop ProxySet immediately - let HS services continue to run (fmt) | Ian Jackson | 2023-10-19 | 1 | -2/+4 | |
| | | | | ||||||
| * | | | HSS: Do not drop ProxySet immediately - let HS services continue to run | Ian Jackson | 2023-10-19 | 1 | -4/+19 | |
| | | | | | | | | | | | | | Dropping the ProxySet causes all the services to terminate. | |||||
| * | | | HSS: Add many must_use annotations | Ian Jackson | 2023-10-19 | 2 | -0/+3 | |
| | | | | ||||||
| * | | | Merge branch 'hs-fixes-2' into 'main' | Alexander Færøy | 2023-10-19 | 1 | -21/+30 | |
| |\ \ \ | | | | | | | | | | | | | | | | | tor-hsservice: ipt_mgr: Track notional estab started for faulty IPTs See merge request tpo/core/arti!1686 | |||||
| | * | | | tor-hsservice: ipt_mgr: Track notional estab started for faulty IPTs (fmt) | Ian Jackson | 2023-10-18 | 1 | -8/+10 | |
| | | | | | ||||||
| | * | | | tor-hsservice: ipt_mgr: Track notional estab started for faulty IPTs | Ian Jackson | 2023-10-18 | 1 | -12/+19 | |
| | | | | | | | | | | | | | | | | | An IPT can go from Faulty to Good. | |||||
| | * | | | tor-hsservice: ipt_mgr: Prepare for TS::Faulty to contain data | Ian Jackson | 2023-10-18 | 1 | -4/+4 | |
| | | | | | ||||||
| * | | | | ipt_establish: Try to make note_open work. | Nick Mathewson | 2023-10-19 | 1 | -6/+28 | |
| | | | | | ||||||
| * | | | | tor-hsservice: Fix cargo doc warnings. | Gabriela Moldovan | 2023-10-19 | 1 | -3/+3 | |
| | | | | | ||||||
| * | | | | tor-keymgr: Fix broken doc link. | Gabriela Moldovan | 2023-10-19 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | tor-hsservice: Rename KeyMetadata to KeyDenotator (fmt). | Gabriela Moldovan | 2023-10-19 | 1 | -1/+2 | |
| | | | | | ||||||
| * | | | | tor-hsservice: Rename KeyMetadata to KeyDenotator. | Gabriela Moldovan | 2023-10-19 | 5 | -40/+43 | |
| | | | | | ||||||
| * | | | | tor-keymgr: Rename KeyPathError to ArtiPathUnavailableError (fmt). | Gabriela Moldovan | 2023-10-19 | 7 | -14/+29 | |
| | | | | | ||||||
| * | | | | tor-keymgr: Rename KeyPathError to ArtiPathUnavailableError. | Gabriela Moldovan | 2023-10-19 | 6 | -23/+24 | |
| | | | | | ||||||
| * | | | | tor-keymgr: Remove From<ArtiPathError> impl for KeyPathError. | Gabriela Moldovan | 2023-10-19 | 3 | -12/+8 | |
| | | | | | ||||||
| * | | | | tor-hsclient, arti-client: Make BadClientSpecifier wrap an ArtiPathError. | Gabriela Moldovan | 2023-10-19 | 2 | -4/+4 | |
| | | | | | ||||||
| * | | | | tor-keymgr: Make KeyType::Unknown a fields-variant. | Gabriela Moldovan | 2023-10-19 | 2 | -10/+16 | |
| | | | | | | | | | | | | | | | | | | | | | This makes it clearer than the underlying `String` represents the `arti_extension` of the key. | |||||
| * | | | | tor-keymgr: Expand on the KeyPathError docs. | Gabriela Moldovan | 2023-10-19 | 1 | -0/+3 | |
| | | | | | ||||||
| * | | | | tor-keymgr: Apply cargo fmt. | Gabriela Moldovan | 2023-10-19 | 3 | -8/+11 | |
| | | | | | ||||||
| * | | | | tor-hsservice: Add some TODOs about error handling. | Gabriela Moldovan | 2023-10-19 | 2 | -0/+10 | |
| | | | | | ||||||
| * | | | | tor-keymgr: Make error handling less repetitive using a closure. | Gabriela Moldovan | 2023-10-19 | 1 | -9/+8 | |
| | | | | | ||||||
| * | | | | tor-keymgr: Rework the ArtiPath error types. | Gabriela Moldovan | 2023-10-19 | 3 | -22/+30 | |
| | | | | | ||||||
| * | | | | tor-keymgr: Add TODO about removing metadata handling from keymgr. | Gabriela Moldovan | 2023-10-19 | 1 | -0/+3 | |
| | | | | | ||||||
| * | | | | tor-hsservice: Add TODO about putting keymgr in the immutable state. | Gabriela Moldovan | 2023-10-19 | 1 | -0/+1 | |
| | | | | | ||||||
| * | | | | tor-hsservice: Add TODO about ArtiPath underscore ambiguity. | Gabriela Moldovan | 2023-10-19 | 1 | -0/+2 | |
| | | | | | ||||||
| * | | | | tor-keymgr: Add TODO about using derive-adhoc. | Gabriela Moldovan | 2023-10-19 | 1 | -0/+2 | |
| | | | | | ||||||
| * | | | | tor-keymgr: Add KeyPathPattern constructor that does not match any valid paths. | Gabriela Moldovan | 2023-10-19 | 1 | -0/+7 | |
| | | | | | ||||||
| * | | | | tor-hsservice: Replace placeholder subcredentials with values from the keystore. | Gabriela Moldovan | 2023-10-19 | 2 | -9/+101 | |
| | | | | | ||||||
| * | | | | tor-hsservice: Add HsSvcKeySpecifier::arti_pattern helper. | Gabriela Moldovan | 2023-10-19 | 1 | -1/+9 | |
| | | | | | ||||||
 |
index : mirrors/arti.git | |
| mirror of https://gitlab.torproject.org/tpo/core/arti |
| summaryrefslogtreecommitdiff |