summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
| * | tor_memtrack: Use DropBombCondition in refcount.rsIan Jackson2024-04-242-12/+74
| | | | | | | | | | | | | | | | | | In addition to the in-module, switchable, tests, I have done an ad-hoc test, removing the Drop impl for Participation, and it crashes in a test as expected.
| * | tor-memtrack: New DropBombCondition typeIan Jackson2024-04-242-5/+191
| | | | | | | | | | | | This will be used by refcount and bookkeeping.
| * | tor-memtrack: Add test cases for drop_reentrancyIan Jackson2024-04-241-0/+39
| | |
| * | tor_memtrack: Soup up DropBomb and make into its own moduleIan Jackson2024-04-245-65/+335
| | | | | | | | | | | | | | | | | | | | | | | | And make it testable. In addition to the in-module tests, I have done an ad-hoc test, removing the .promise call from deferred_drop, and it does panic in the test cawe as desired.
* | | Circuit reactor: document some requirements and assumptionsJim Newsome2024-04-251-10/+42
| | | | | | | | | | | | | | | | | | | | | | | | There are some tricky bits here that implicitly assume particular behavior in other bits for correctness. Document these requirements and assumptions. Fixes arti#1373
* | | Mark tor_dirmgr::storage::Store::consensus_by_meta cfg(test)Ian Jackson2024-04-252-0/+2
| | | | | | | | | | | | This seems to be used only in tests, since at least 2022.
* | | Delete duplicate KeySpecifierComponentPrettyHelperIan Jackson2024-04-251-9/+0
| | | | | | | | | | | | This had somehow got duplicated; remove the one in derive.rs.
* | | Add temporary allows for some dead code warningsIan Jackson2024-04-254-0/+5
| | |
* | | Add a dead code allow in RPC codeIan Jackson2024-04-251-0/+1
| | |
* | | Suppress a spurious dead code lintIan Jackson2024-04-251-0/+1
| |/ |/|
* | tor-circmgr: Loop until we run out of circuits to launch.Gabriela Moldovan2024-04-251-1/+1
|/ | | | | Previously this would only loop `n_to_launch - 1` times, so the pool was always 1 circuit short of the `n_to_launch` target.
* Merge branch 'misc-nightly-warnings' into 'main'Alexander Færøy2024-04-2311-19/+21
|\ | | | | | | | | | | | | Clean up various nightly clippy warnings Closes #1379 See merge request tpo/core/arti!2097
| * Use clone_from in CircMgr config updater.Nick Mathewson2024-04-221-1/+3
| | | | | | | | | | Clippy prefers this idiom as potentially more efficient. It's not critical-path, but let's let clippy have its way.
| * Fix recursive impl for arti_client::Error.Nick Mathewson2024-04-221-1/+1
| | | | | | | | This is an actual bug. Closes #1379.
| * dirmgr: Use contains_key in check.Nick Mathewson2024-04-221-1/+1
| |
| * Use uXX::MAX in place of std::uXX::MAXNick Mathewson2024-04-228-14/+14
| | | | | | | | | | | | The old code produced a warning from clippy nightly; we may as well update to use the new associated consts. (They've been there since Rust 1.4x.)
| * proto: Simplify a check-and-convert to use try_into+expectNick Mathewson2024-04-221-2/+2
| |
* | tor-memtrack: Explain lack of thread parallelism in notify_victimsIan Jackson2024-04-231-0/+6
| |
* | tor-error: Fix message for LocalResourceExhaustedIan Jackson2024-04-231-1/+1
| |
* | RustfmtIan Jackson2024-04-231-2/+2
| |
* | tor-memtrack: Explain the code structure in reclaim::inner_loopIan Jackson2024-04-231-0/+4
| |
* | tor-memtrack: Break out aid_and_children_recursivelyIan Jackson2024-04-232-14/+24
| | | | | | | | | | As per paras 2- of https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2091#note_3021478
* | tor-memtrack: Remove an unused mutIan Jackson2024-04-231-1/+1
| | | | | | | | | | As per para 1 of https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2091#note_3021478
* | tor-memtrack: Correct doc comment for `reclaim::inner_loop`Ian Jackson2024-04-231-1/+5
| | | | | | | | | | Addresses https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2091#note_3021475
* | tor-memtrack: Explain the relationship to `mtracker` betterIan Jackson2024-04-231-1/+4
| | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2091#note_3021473
* | tor-memtrack: Clarify what "stuff of ours" might be droppedIan Jackson2024-04-231-1/+2
| | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2091#note_3021471
* | tor-memtrack: Add xref to help explain drop_reentrancyIan Jackson2024-04-231-0/+2
| | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2091#note_3021467 https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2091#note_3021470
* | tor-memtrack: Explain drop impl for GuardWithDeferredDrop in prodIan Jackson2024-04-231-0/+8
| |
* | tor-memtrack: Correct "reentrant" terminologyIan Jackson2024-04-231-1/+1
| |
* | tor-memtrack: Explain why drop_reentrancy no-op ok outside testsIan Jackson2024-04-231-0/+15
| |
* | tor-memtrack: Avoid accidental poisoning during claimIan Jackson2024-04-231-0/+7
| |
* | tor-memtrack: Explain what poisoned total state is forIan Jackson2024-04-231-0/+2
| | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2091#note_3021460
* | tor-memtrack: Clarify error message about ratioIan Jackson2024-04-231-1/+1
| | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2091#note_3021444
* | tor-memtrack: Clarify behavioural commentIan Jackson2024-04-231-1/+1
| | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2091#note_3021436
* | tor-memtrack: Set Cargo categoriesIan Jackson2024-04-231-2/+1
| | | | | | | | | | Adopting suggestion from https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2091#note_3021435
* | tor-memtrack: Docs fixesgabi-2502024-04-232-2/+2
| |
* | tor-memtrack: Add a let binding to clarifygabi-2502024-04-231-1/+1
| |
* | tor-memtrack: Fix docs typogabi-2502024-04-231-1/+1
| |
* | tor-memtrack: say how to get an `Account`gabi-2502024-04-231-0/+2
| |
* | tor-memtrack: Say how to get a `Participation`gabi-2502024-04-231-0/+3
| |
* | tor-memtrack: Fix docs typosgabi-2502024-04-232-2/+2
| |
* | tor-memtrack: Doc fixesgabi-2502024-04-232-5/+5
| |
* | tor-memtrack: Docs fixes/improvementsgabi-2502024-04-232-2/+2
| |
* | tor-memtrack: Fix various typosgabi-2502024-04-233-3/+3
| |
* | tor-memtrack: Clarify a doc commentgabi-2502024-04-231-1/+1
| |
* | tor-memtrack: Doc comment: Fix erroneous module referencegabi-2502024-04-231-1/+1
| |
* | tor-memtrack: Fix doc comment (and change capitalisation)gabi-2502024-04-231-1/+1
| |
* | tor-memtrack: Fix doc comment grammargabi-2502024-04-231-1/+1
| |
* | tor-memtrack: Clarify a doc commentgabi-2502024-04-231-2/+2
| |
* | tor-memtrack: Add a doctest example for mtrackerIan Jackson2024-04-231-0/+56
| |