summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
* | clippy nightly: For now, locally allow blocks_in_conditionsIan Jackson2024-01-023-0/+3
| | | | | | | | | | | | Filed https://gitlab.torproject.org/tpo/core/arti/-/issues/1176 proposing a final fix.
* | clippy nightly: Use Poll.is_pending() in two placesIan Jackson2024-01-021-2/+2
| | | | | | | | clippy correctly identifies that this is nicer than matches!.
* | clippy: An an allow for fallible ed25519 conversionIan Jackson2024-01-021-0/+5
| | | | | | | | | | I'm not sure about this. Leaving it this way seems the most conservative choice for now.
* | clippy: Add an allow to work around a clippy bugIan Jackson2024-01-021-0/+3
| | | | | | | | | | | | | | | | | | | | clippy in current stable thinks |(a, b)| (a, b) is always the identity function, but due to match ergonomics, it might be an implicit copy. This is fixed in nightly by https://github.com/rust-lang/rust-clippy/pull/11792
* | clippy: Use infallible callsIan Jackson2024-01-024-10/+5
| | | | | | | | Resolves clippy complaints about needless fallible conversions.
* | clippy: Replace many calls to .get(0) with .first()Ian Jackson2024-01-026-9/+9
|/ | | | | FTR I don't think agree with clippy on this question, but then I often don't.
* tor-rtcompat: use track-caller for thin wrappersJim Newsome2023-12-182-0/+4
| | | | | | | | | | | | | | In particular, when the (unstable) tokio tracing feature is enabled, every tracing line includes the name of where the current task was created. Without this change, that ends up being the name of intermediate trait methods like TokioRuntimeHandle::block_on, which is not very helpful. Adding the `track_caller` attribute causes the name of the caller of these methods to be used instead, which is typically more helpful. IIUC this change is not breaking in terms of semver https://rustc-dev-guide.rust-lang.org/backend/implicit-caller-location.html.
* Merge branch 'hs-desc-builder' into 'main'Alexander Færøy2023-12-183-17/+23
|\ | | | | | | | | | | | | tor-netdoc: Make HsDescBuilder::auth_clients take an Option. Closes #1019 See merge request tpo/core/arti!1840
| * tor-netdoc: Make HsDescBuilder::auth_clients take an Option.Gabriela Moldovan2023-12-143-17/+23
| | | | | | | | Closes #1019
* | Merge branch 'doctest-deprecated-name' into 'main'Nick Mathewson2023-12-141-2/+2
|\ \ | | | | | | | | | | | | tor-cell: Stop using deprecated name in doctest See merge request tpo/core/arti!1842
| * | tor-cell: Stop using deprecated name in doctestNick Mathewson2023-12-141-2/+2
| | |
* | | Merge branch 'keymgr-proto-domain-name' into 'main'gabi-2502023-12-146-88/+23
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | tor-keymgr: Use spec.torproject.org for the SSH algo name domain. Closes #1108 See merge request tpo/core/arti!1838
| * | | arti: Fix log message typo.Gabriela Moldovan2023-12-141-1/+1
| | | |
| * | | tor-keymgr: Wrap a long doc comment line.Gabriela Moldovan2023-12-141-3/+3
| | | |
| * | | tor-keymgr: Update docs referencing outdated SSH algo names.Gabriela Moldovan2023-12-142-3/+3
| | | |
| * | | tor-keymgr: Remove the TODOs about adding a protocol name registry.Gabriela Moldovan2023-12-141-68/+3
| | | | | | | | | | | | | | | | Diziet addressed these in #1049
| * | | tor-keymgr: Use spec.torproject.org for the SSH algo name domain.Gabriela Moldovan2023-12-145-15/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Note: any existing x25519 or expanded ed25519 keys you might have in the keystore will become invalid (your keystore will appear corrupt, so you will need to manually delete them if you want to continue using the onion service they were originally generated for). Part of #1108
* | | | Merge branch 'update-onion-doc' into 'main'Nick Mathewson2023-12-141-1/+1
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | doc: Document how to find out your .onion address with `arti hss`. See merge request tpo/core/arti!1841
| * | | arti: Fix log message typo.Gabriela Moldovan2023-12-141-1/+1
| | |/ | |/|
* | | Merge branch 'rename_relaycell' into 'main'Ian Jackson2023-12-1411-80/+73
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Rename {Any}RelayCell to {Any}RelayMsgOuter Closes #775 See merge request tpo/core/arti!1839
| * | Add deprecated aliases for old RelayCell namesNick Mathewson2023-12-141-0/+8
| | | | | | | | | | | | | | | We should remove these once we do our final renaming here, but for now we may as well avoid a breaking change.
| * | Fix relaymsg fuzzer to refer to AnyRelayMsgOuter.Nick Mathewson2023-12-141-2/+2
| | |
| * | Fix documentation that referred to RelayCell.Nick Mathewson2023-12-143-26/+5
| | |
| * | Fix documentation for {Any}RelayMsgOuterNick Mathewson2023-12-141-3/+7
| | |
| * | Rename {Any}RelayCell to {Any}RelayMsgOuterNick Mathewson2023-12-148-49/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit is pure renaming, done automatically with rust-analyzer. Comment fixes and other cleanups will be in the subsequent commits. We're doing this renaming because we need a name for the combination of a `RelayMsg` and an `Option<StreamId>` that we use when we have a `RelayMsg` we intend to route to a given stream or circuit internally. Previously we called this a `RelayCell`, but that name was already somewhat inaccurate, and will become _very_ inaccurate with the arrival of prop340, which breaksthe 1:1 relationship between relay cells and relay messages. (If we didn't do this renaming now, we'd soon be making the relationship between `UnparsedRelayCell`and `RelayCell` many-to-many, which would be ridiculous and confusing.) The `RelayMsgOuter` name is a placeholder: We expect that we'll want to rename this type, and may also want to rename `RelayMsg`, and unify our vocabulary in other areas too. But such a renaming will have to wait for a larger discussion affecting the specifications, so that we can use the same vocabulary everywhere.
* | | Merge branch 'doc-link' into 'main'gabi-2502023-12-141-1/+1
|\ \ \ | |/ / |/| | | | | | | | tor-hsservice: Fix broken doc link. See merge request tpo/core/arti!1836
| * | tor-hsservice: Fix broken doc link.Gabriela Moldovan2023-12-141-1/+1
| | |
* | | Merge branch 'return-of-the-son-of-arti-todos' into 'main'Nick Mathewson2023-12-144-59/+140
|\ \ \ | |_|/ |/| | | | | | | | Resolve Arti crate todos, redux See merge request tpo/core/arti!1833
| * | Trivial case fix in a comment.Ian Jackson2023-12-141-1/+1
| | |
| * | arti: Add a todo to describe how and why to test build_list.Nick Mathewson2023-12-131-0/+7
| | |
| * | arti: Use BTreeMap for maps of onion service configs.Nick Mathewson2023-12-131-9/+9
| | |
| * | arti: Simplify build_list slightlyNick Mathewson2023-12-131-4/+3
| | |
| * | arti: Use a macro to declare modules as conditionally public.Nick Mathewson2023-12-131-25/+36
| | | | | | | | | | | | | | | (We can't use `visibility::make(pub)` or `visible` here. Try it yourself if you don't believe me!)
| * | arti: Test for expected value of onion service cfg.Nick Mathewson2023-12-121-2/+34
| | |
| * | arti: resolve a TODO in onion_proxy launch_new.Nick Mathewson2023-12-121-7/+2
| | |
| * | arti: rethink a TODO HSS about nicknamesNick Mathewson2023-12-121-1/+9
| | | | | | | | | | | | | | | | | | The TODO HSS in question is about our inability to serialize every possible builder. The right answer here might be to use something else instead of a ListBuilder.
| * | arti: Enforce onion service nickname distinctnessNick Mathewson2023-12-122-18/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The most logical way to do this was to change the "List" type to a HashMap, and add a build function to the ListBuilder. This change additionally renames: OnionServiceProxyConfig{List=>Map} NamedProxyMap => ProxyBuilderMap (We now have two kinds of map, and this name change will clarify the distinction.)
| * | arti: Downgrade a TODO HSS about testing onion-service config.Nick Mathewson2023-12-121-1/+2
| | | | | | | | | | | | | | | | | | | | | IIUC, there will never be a Some(InNew) entry here, since we will never have an onion service be configured by default. Instead we test this kind of configuration by having commented-out options that we uncomment as needed.
| * | arti: Generalize a TODO HSS about reconfiguration.Nick Mathewson2023-12-122-1/+10
| | | | | | | | | | | | | | | | | | It's correct that we'd like someday for the `arti` crate APIs to allow all the different modes supported by `Reconfigure` enum; this is #1156, and it does not block an HSS release.
| * | arti: conditionally expose onion_proxy module when experimental-api is enabledNick Mathewson2023-12-121-4/+4
| | |
| * | Remove TODOs obsoleted by onion service reconfiguration.Nick Mathewson2023-12-122-2/+0
| | | | | | | | | | | | (This was solved with !1798)
* | | Merge branch 'hss-cli' into 'main'gabi-2502023-12-145-2/+116
|\ \ \ | | | | | | | | | | | | | | | | arti: Add an hss subcommand. See merge request tpo/core/arti!1837
| * | | tor-hsservice: Add TODO about rethinking the HSS StateMgr API.Gabriela Moldovan2023-12-141-0/+3
| | | |
| * | | arti: Print out the onion address retrieved from StateMgr.Gabriela Moldovan2023-12-141-1/+15
| | | |
| * | | tor-hsservice: Add an hss state mgmt APIGabriela Moldovan2023-12-142-0/+47
| | | |
| * | | arti-client: Add an accessor for the keystore config.Gabriela Moldovan2023-12-142-0/+6
| | | |
| * | | arti: Add an hss subcommand.Gabriela Moldovan2023-12-141-2/+46
| | |/ | |/| | | | | | | Part of #1071
* | | ChannelState::ready_to_expire: return true when rem time is zeroJim Newsome2023-12-131-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a race condition that would normally be fairly benign - it would result in scheduling to check for expired channels again immediately, and assuming non-zero time passes would then remove the channel. In Shadow's default time model though, zero time passes in this case, so we just keep scheduling to check again immediately forever; i.e. deadlock.
* | | ChannelState::ready_to_expire: refactor using let-elseJim Newsome2023-12-131-18/+14
| | |
* | | continually_expire_channels: don't round off expiration delayJim Newsome2023-12-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Without this change, if the delay is less than one second, the code will effectively busy-loop until the delay has elapsed. This potentially leads to deadlock in shadow simulations, and wastes CPU in real usage. https://shadow.github.io/docs/guide/limitations.html?highlight=busy#busy-loops