| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
The feature name is wrong now.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
I think this name is fine.
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
handle_msg is going to want this in a moment.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
If the circuit is just being used by us (which is likely, if we're
using this API) then the only reactor we're blocking is our own.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Now, after you call start_conversation_last_hop, you can send more
messages if you like.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We're going to want to do almost-the-same thing but without installing
a new handler.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This is just a placeholder for now, but it'll be a thing you can send
more messages with.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Was send_control_message.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We're going to let people start a conversation and either expect to
receive first, or send messages ad-hoc later.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Was UninstallHandler. We are going to talk more about conversations
and less about handlers (although, the fact of there being a handler
will still be visible).
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Nothing else wants this and having it pub(super) is confusing.
|
| |\| | | | |
| |/ / / /
|/| | | |
| | | | |
| | | | | |
tor-hsclient: Mock traits: Work around an async boobytrap
See merge request tpo/core/arti!1365
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix new "useless_vec" warning from clippy +nightly
See merge request tpo/core/arti!1395
|
| | | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Explanation at
https://rust-lang.github.io/rust-clippy/master/index.html#/useless_vec
This is the non-tests subset of the same-named commmit in !1388,
(recreated by hand by me, and then checked against that commit;
I stole the commit message from Nick's.)
This should be uncontroversial I think.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Clippy nightly now detects when you're calling into_iter() and
passing the result into something that accepts an
`impl IntoIterator`.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
See here for documentation on the lint:
https://rust-lang.github.io/rust-clippy/master/index.html#/diverging_sub_expression
The issue here, from what I can tell, is that the lint triggers
whenever you use a diverging expression as a function body within an
|
| |/ / / /
| | | |
| | | |
| | | | |
We're doing this deliberately, I believe.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
RFC: tor-rtmock: Use derive-adhoc for composite runtimes
See merge request tpo/core/arti!1381
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It is no longer experimental, but still not rated for security-sensitive
usage per <https://blog.torproject.org/arti_116_released/>.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Originally they didn't check err.kind(), since err.kind() can never
increase their severity. We lost that behavior with !1386, and we
became dependent on it with arti!1383. Since they both merged at
the same time, CI broke.
This patch restores their original behavior.
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
arti: Build with HS client support by default
Closes #948
See merge request tpo/core/arti!1382
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixes #948
|
| | |/ / / / |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Throughout: Use event_report!() macros for reporting Errors.
Closes #949
See merge request tpo/core/arti!1383
|
| | | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I identified the cases to replace by searching for the string
`.report()`. There are a few that I didn't change:
* A couple of cases that used anyhow::Error,
* One case that reported two Errors.
* Two cases in `tor_hsclient::err` that just did
`error!("Bug: {}")`.
I have also not audited the cases in `tor-hsclient` where we're using
`tor_error::Report` manually.
Nonetheless, closes #949.
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
tor-error: tracing module: Use macro to generate macros
See merge request tpo/core/arti!1386
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This abolishes some quintuplication.
The output is identical except that:
* The syntax display in the rustdoc output for the resulting macros
seems to have somewhat less whitepsace.
* The whimsical error messages in the examples are all identical.
Ah well.
|
| | |/ / / / |
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
rng ranges: Use inclusive Duration ranges in several places
See merge request tpo/core/arti!1385
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Many of these call sites would panic if, somehow, the upper bound was
zero. In most cases it is very complicated to see if whether this
could happen.
However, there is a better answer:
Durations are (conceptually) dense, so picking the closed set (which
includes its boundary) rather than the open one (which doesn't) will
make little practical difference.
So change four call sites to use `..=` instead of just `..`.
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
Optional tracing support in tor-error for error reporting
See merge request tpo/core/arti!1379
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
(Also, document that this static assertion is the reason why you are
seeing a confusing error message.)
|
| | | | | |
| | | | |
| | | | |
| | | | | |
This simplifies our logging a little, and implements part of
|
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The main contribution here is a set of convenience macros for
logging error `Report`s. Notably, this macros always logs
`Internal` and `BadAspiUsage` errors at `WARN`, unless they
are already at `ERROR` or more.
This is a little tricky because `tracing::event!()` requires
its Level argument to be a constant.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
add_warning: Tolerate clippy::missing_panics_doc
Closes #950
See merge request tpo/core/arti!1380
|
| | | | | |
| | | | |
| | | | |
| | | | | |
These are no longer needed.
|
| | |/ / /
| | | |
| | | |
| | | | |
Closes #950.
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
Fix various warnings from clippy nightly
Closes #943
See merge request tpo/core/arti!1369
|
| | | | |
| | | |
| | | |
| | | | |
This appeases clippy-nightly.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Clippy nightly doesn't like `#[cfg(all(...))]` with only a single
expression inside the `all(...)`.
This requires an adjustment in check_doc_features.
|
| | |/ /
| | |
| | |
| | | |
This is a new warning^Wsuggestion from clippy nightly.
|
| | | | |
|
| | | |
| | |
| | |
| | | |
These are always the same and probably always will be.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Introduce a MockExecutor for fully-isolated test cases
See merge request tpo/core/arti!1375
|
| | | | | |
|