| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | | | | | |
|
| | | | | | | |
|
| | |/ / / / |
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I am not sure why we wrote these comments, but they are incorrect:
I've investigated the C code and found only 3 key types. The
"unimplemented" types that the TODO comment here complains about are
in fact certificate types.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
keymgr: Downgrade "TODO hs" to "TODO HSS".
See merge request tpo/core/arti!1334
|
| | | |_|/
| |/| |
| | | |
| | | |
| | | | |
These TODOs can be deferred for now: we're not declaring the keymgr APIs
stable until we add support for hidden services.
|
| | | | |
| | | |
| | | |
| | | | |
Since arti!1233 this is trivial.
|
| |/ / /
| | |
| | |
| | |
| | | |
For some reason this wasn't used in the actual errors,
although it *was* used in the types of the functions etc.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
tor-hsclient: Discuss intro circuit extend-and-reuse
See merge request tpo/core/arti!1298
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
This is a summary of a discussion I had on IRC.
|
| |\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | | |
keymgr: Remove/downgrade a few "TODO hs"
See merge request tpo/core/arti!1328
|
| | | | |
| | | |
| | | |
| | | | |
These don't need to be blockers for the next release.
|
| | | | |
| | | |
| | | |
| | | | |
These were tackled in #901.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
tor-hsclient: Add configuration settings
See merge request tpo/core/arti!1305
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Conceptually this is a fixup to
HS configuration: Add retry parameters to configuration
which erroneously removed these comments - they were intended to apply
to *all* these parameters, not just the max attempts.
Not marking it as fixup! because that would involve merge conflicts.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Explain why this fallback to MAX is good.
Discussion
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1305#note_2915927
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Apply deferred rustfmt churn.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Apply deferred clippy churn.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Invent a trait a la circmgr config for the hs client connector config.
Plumb a suitable value all the way through to the code that will use it.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I think these should go in `[circuit_timing]`. That section already
has some retry parameters, so is not strictly *timing*.
This is not honoured yet.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We put this in `[address_filter]`.
The interaction with the corresponding stream preference is a bit
complicated. We must turn the stream pref into a `BoolOrAuto`.
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
Missing semver entry for new dirclient API from !1323
See merge request tpo/core/arti!1327
|
| | |/ / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
tor-hsclient: Completely hide hsdir identities in errors
See merge request tpo/core/arti!1326
|
| | |/ / / |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This was super confusing and fragile. Amongst the problems:
* Information about exceptional config keys was spread across a
number of places, manipulated in ad-hoc ways (conditional Vec
appends, etc).
* As a consequence, each exceptional table has confusing and unclear
semantics.
* It doesn't deal well with the way that cargo sometimes enables
features for dependency crates even if arti itself wouldn't demand
them; this can lead to sub-crates supporting config keys when the
tests in arti don't expect them to, causing spurious test failures.
Fix this:
* Introduce a new, systematic, way of writing information about
configuration keys that need some kind of special handling.
* Use this new approach in *both* sets of "thorough" config tests.
* Be more relaxed about deprecated keys. We don't want to tightly
couple this to absence in the supported file, I think.
* Understand more clearly the concept of keys of which we don't know,
in the current build config, whether the code is expected to
accept them.
I have tested this locally with:
for p in '-p arti' '--workspace'; do for f in '--no-default-features --features=tokio,native-tls' '--all-features' ''; do nailing-cargo test $p $f; done; done
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We *do* have a thing that works like this.
It's fragile and confusing and that's what I'm about to fix.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Bring the exciting tests together, and move some more normal tests out
of the middle.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Without this, the build fails with
cargo test --workspace --no-default-features --features=tokio,native-tls
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Fixes a warning with
cargo clippy --locked --offline --workspace --all-targets
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
If all the fields vanish, this generates a warning with
cargo clippy --locked --offline --workspace --all-targets
Fix that.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
keymgr: Implement ErrorKind for keymgr error types
See merge request tpo/core/arti!1315
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
Resolve remaining dirclient HS todos
See merge request tpo/core/arti!1323
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Yes, it's 50 kilobytes, not 50 kibibytes. I double-checked this with
the C implementation and with param-spec.txt's documentation for
`HSV3MaxDescriptorSize`.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | |/
| |/| |
|
| |\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | | |
Remove support for receiving unauthenticated SENDMEs.
Closes #914
See merge request tpo/core/arti!1283
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
We haven't generated these since Tor 0.3.5, which is no longer
supported on the network.
Closes #914.
|