summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | Import educe into tor-bytes and provide skip_fmtIan Jackson2022-03-022-0/+36
| | | | | | | | | | | | | | | | | | | | | | | | Preparatory work for getting rid of some manual Debug impls
* | | | | | Merge branch 'hex_decode' into 'main'Ian Jackson2022-03-047-27/+34
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Speed up RsaIdentity decoding Closes #377 See merge request tpo/core/arti!381
| * | | | | Use RsaIdentity::from_hex() and hex::decode_to_slice in more placesNick Mathewson2022-03-044-16/+8
| | | | | | | | | | | | | | | | | | | | | | | | These aren't critical-path, but they do make the code a little nicer.
| * | | | | tor-netdoc: Use RsaIdentity::from_hex() in critical path.Nick Mathewson2022-03-041-6/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes the main parsing code for RsaIdentity in tor-netdoc, and . Previously, parse_hex_ident was something like 10% of our startup CPU time; now it's only like ~2%. (Still not perfect, but way better.) Closes #377.
| * | | | | Add a from_hex method for RsaIdentity.Nick Mathewson2022-03-042-5/+25
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We perform this operation in a bunch of places, and most of them use hex::decode(). That's not great, since hex::decode() has to do heap allocation. This implementation uses hex::decode_to_slice(), which should be faster. (In the future we might choose to use one of the faster hex implementations, but I'm hoping that this change will be sufficient to get hex decoding out of our profiles.) Part of #377.
* | | | | Merge branch 'arti-testing-part1' into 'main'eta2022-03-046-0/+693
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | arti-testing: Initial implementation See merge request tpo/core/arti!378
| * | | | Allow println in arti-testing.Nick Mathewson2022-03-031-0/+2
| | | | |
| * | | | arti-testing: Initial implementationNick Mathewson2022-03-036-0/+691
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds a new program to try to implement the ideas behind experimentation in arti#329. In particular, it tries to implement basic client "can I bootstrap and connect" functionality testing, with a lot of instrumentation, and support for breaking things. So far, the instrumentation is limited to counting TCP bytes and connections, and counting events. Still, this is enough to measure behavior on some of the incorrect-clock tests. NOTE: For now, you are _required_ to pass in an explicit configuration, in hopes that this will lead you to override your storage directories for doing specific experiments.
* | | | Merge branch 'derive-traits' into 'main'Ian Jackson2022-03-0412-112/+41
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Tidy up many open-coded trait impls See merge request tpo/core/arti!374
| * | | | Fix introduced junk in doc comment.eta2022-03-041-1/+1
| | | | |
| * | | | Replace manual Default, and abolish new, in tor-rtcompatIan Jackson2022-03-021-13/+1
| | | | | | | | | | | | | | | | | | | | The Default impl was the only call site for new()
| * | | | Replace manual Default and new with std derive in tor-protoIan Jackson2022-03-022-18/+4
| | | | |
| * | | | Replace manual Default and new with std derive in tor-netdocIan Jackson2022-03-022-17/+5
| | | | |
| * | | | Replace manual Default and new with std derive in tor-dirclientIan Jackson2022-03-021-30/+6
| | | | |
| * | | | Replace manual Default impl with std derive in tor-configIan Jackson2022-03-021-7/+1
| | | | |
| * | | | Replace manual Default impl with std derive in tor-cellIan Jackson2022-03-021-6/+1
| | | | |
| * | | | Replace manual Clone impl with std derive in retry-errorIan Jackson2022-03-021-11/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This just clones the fields. It is not clear to me why it was written this way in be86df631dec Remove anyhow dependency from tor-retry, and rename it to retry-error Previously, I think, RetryError wasn't Clone.
| * | | | Replace manual Debug impl with std derive in tor-circmgrIan Jackson2022-03-021-10/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When I wrote this, I arranged to skip dumping the field `pending`. This must have been because I thought that either (a) PendingEntry couldn't `#[derive(Debug)]` (but it can) and/or (b) Some of the fields of PendingEntry ought not to be dumped because they might contain (eg) packet data. But I think they don't: there's just the spec, and the Result which is (basically) a Circ. I tried preseving something closer to the original using educe, but educe gets somehow tangled up with the generics, and the result fails to compile. I haven't investigated this further.
| * | | | tor-llcrypto: Replace a tiny bit of code duplication with a callIan Jackson2022-03-021-1/+1
| | | | | | | | | | | | | | | | | | | | No functional change.
| * | | | tor-llcrypto: Add test case for RsaIdentity formattingIan Jackson2022-03-021-0/+19
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | I'm going to change the code that does this, so add a test first to check the output doesn't change. At some point we should have more RSA tests.
* | | | Merge branch 'return_ref_arc' into 'main'Ian Jackson2022-03-041-4/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | arti-client: Make dirmgr() and circmgr() return &Arc<..> Closes #369 See merge request tpo/core/arti!379
| * | | | arti-client: Make dirmgr() and circmgr() return &Arc<..>Nick Mathewson2022-03-031-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously they returned an Arc, which wasn't necessary unless the client actually _wanted_ a new Arc. This would be an API break, except that these functions are marked 'experimental-api', so semver does not apply; nonetheless I've noted the break in semver_status.md, just in case we care. Closes #369
* | | | | Merge branch 'shellexpand' into 'main'eta2022-03-031-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | Switch to shellexpand-fork version of shellexpand See merge request tpo/core/arti!373
| * | | | Switch to shellexpand-fork version of shellexpandIan Jackson2022-03-021-1/+1
| |/ / / | | | | | | | | | | | | | | | | Apropos discussion in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/274
* | | | Merge branch 'dir-provider-redux' into 'main'Ian Jackson2022-03-026-27/+158
|\ \ \ \ | |/ / / |/| | | | | | | | | | | Alternative DirProvider setup See merge request tpo/core/arti!347
| * | | Have caller of dirmgr_builder() provide Arc.Nick Mathewson2022-03-021-2/+2
| | | |
| * | | DirProvider: Fix infinite recursion bugNick Mathewson2022-02-252-5/+5
| | | |
| * | | Add a builder function for replacing a DirProvider.Nick Mathewson2022-02-235-21/+86
| | | | | | | | | | | | | | | | Put it behind experimental_api.
| * | | Un-parameterize DirProvider.Nick Mathewson2022-02-232-20/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch removes the EventStream associated type and the Runtime parameter. The Runtime parameter wasn't actually used for anything, and the EventStream was easy enough to replace with a BoxStream in this case. Also replaced DirBootstrapEvents with a BoxStream to avoid tying anything to our backend.
| * | | Add basic DirProvider trait, use it in clientChristian Grigis2022-02-232-6/+80
| | | |
* | | | Merge branch 'clippy-allow-arc-clone' into 'main'Nick Mathewson2022-03-0130-30/+0
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Disable clippy::clone_on_ref_ptr See merge request tpo/core/arti!352
| * | | | Disable clippy::clone_on_ref_ptrIan Jackson2022-02-2430-30/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lint is IMO inherently ill-conceived. I have looked for the reasons why this might be thought to be a good idea and there were basically two (and they are sort of contradictory): I. "Calling ‘.clone()` on an Rc, Arc, or Weak can obscure the fact that only the pointer is being cloned, not the underlying data." This is the wording from https://rust-lang.github.io/rust-clippy/v0.0.212/#clone_on_ref_ptr It is a bit terse; we are left to infer why it is a bad idea to obscure this fact. It seems to me that if it is bad to obscure some fact, that must be because the fact is a hazard. But why would it be a hazard to not copy the underlying data ? In other languages, faliing to copy the underlying data is a serious correctness hazard. There is a whose class of bugs where things were not copied, and then mutated and/or reused in multiple places in ways that were not what the programmer intended. In my experience, this is a very common bug when writing Python and Javascript. I'm told it's common in golang too. But in Rust this bug is much much harder to write. The data inside an Arc is immutable. To have this bug you'd have use interior mutability - ie mess around with Mutex or RefCell. That provides a good barrier to these kind of accidents. II. "The reason for writing Rc::clone and Arc::clone [is] to make it clear that only the pointer is being cloned, as opposed to the underlying data. The former is always fast, while the latter can be very expensive depending on what is being cloned." This is the reasoning found here https://github.com/rust-lang/rust-clippy/issues/2048 This is saying that *not* using Arc::clone is hazardous. Specifically, that a deep clone is a performance hazard. But for this argument, the lint is precisely backwards. It's linting the "good" case and asking for it to be written in a more explicit way; while the supposedly bad case can be written conveniently. Also, many objects (in our codebase, and in all the libraries we use) that are Clone are in fact simply handles. They contain Arc(s) (or similar) and are cheap to clone. Indeed, that is the usual case. It does not make sense to distinguish in the syntax we use to clone such a handle, whether the handle is a transparent Arc, or an opaque struct containing one or more other handles. Forcing Arc::clone to be written as such makes for code churn when a type is changed from Arc<Something> to Something: Clone, or vice versa.
* | | | | Bump all crates to 0.1.0arti-v0.1.0Nick Mathewson2022-03-0131-160/+160
| | | | |
* | | | | Update README.md files from rustdoc.Nick Mathewson2022-03-017-112/+173
| | | | |
* | | | | Fix rustdoc errors.Nick Mathewson2022-03-013-10/+11
| | | | |
* | | | | Run rustfmt.Nick Mathewson2022-03-011-1/+0
| | | | |
* | | | | Merge remote-tracking branch 'origin/mr/371'Nick Mathewson2022-03-012-2/+31
|\ \ \ \ \
| * | | | | arti-hyper: Upgrade from an example to an "adaptation layer"Ian Jackson2022-03-011-0/+8
| | | | | |
| * | | | | arti-hyper: Expand docsIan Jackson2022-03-011-1/+15
| | | | | |
| * | | | | arti-hyper: Drop obsolete comment about not doing TLSIan Jackson2022-03-011-2/+0
| | | | | |
| * | | | | arti-client: Add stability warning to config moduleIan Jackson2022-03-011-0/+9
| | | | | |
| * | | | | Merge branch 'main' into hyper-docsIan Jackson2022-03-016-83/+183
| |\ \ \ \ \
* | | | | | | Merge branch '010_docs'Nick Mathewson2022-03-014-7/+36
|\| | | | | |
| * | | | | | Update our stability warning on arti-client.Nick Mathewson2022-02-281-5/+12
| | | | | | |
| * | | | | | Add warnings about configuration stability.Nick Mathewson2022-02-283-2/+24
| | | | | | |
* | | | | | | Merge branch 'main' into 364Ian Jackson2022-03-017-84/+183
|\ \ \ \ \ \ \ | | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: crates/arti-hyper/examples/hyper.rs Trivially resolved. Hyper example still works.
| * | | | | | Merge branch 'tls' into 'main'Nick Mathewson2022-02-285-38/+133
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement TLS in arti-hyper See merge request tpo/core/arti!355
| | * | | | | | Fix typo in messageNick Mathewson2022-02-281-1/+1
| | | | | | | |
| | * | | | | | arti-hyper: Add vacuous doc comments as required by clippyIan Jackson2022-02-281-0/+3
| | | | | | | |
| | * | | | | | EK::RemoteProtocolFailed replaces OtherRemoteIan Jackson2022-02-282-7/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/355#note_2781816
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 22:28:40 +0000