| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This will make it easier to change the semantics of what exactly we
return, whether it has to be/contain a client, whether you can use
it to look up all the live objects, &etc.
|
| | | | | |
|
| | | | | |
|
| | |/ / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
rpc: Use the real generational-arena crate
See merge request tpo/core/arti!1203
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Now that generation-arena has merged [@diziet's patch] to clarify
their license, we no longer need to disable it.
[@diziet's patch]: https://github.com/fitzgen/generational-arena/pull/56
|
| |/ / / |
|
| |\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | | |
Fix a local-only CPU DoS bug.
Closes #861
See merge request tpo/core/arti!1196
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously, there was a bug in the way that our code used our SOCKS
implementations. If the buffer used for a SOCKS handshake became full
without completing the handshake, then rather than expanding the buffer
or closing the connection, our code would keep trying to read into the
zero-byte slice available in the full buffer forever, in a tight loop.
We're classifying this as a LOW-severity issue, since it is only
exploitable by pluggable transports (which are trusted) and by
local applications with access to the SOCKS port.
Closes #861.
Fixes TROVE-2023-001.
Reported-By: Jakob Lell <jakob AT srlabs DOT de>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Method dispatch rules mean that if the receiver type of the actual
function changes, `self.call()` can turn into a purely-recursive call
which overflows the stack.
Async Rust doesn't have the usual warning for this situation :-(.
UFCS is clumsier but doesn't have that problem because it involves
much less magical dispatch. Instead of generating a recursive call
which overflows the stack, it fails to compile.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
ClientCirc::begin_dir_stream now takes Arc<Self>. Method resolution
rules mean that this code would just recurse, leading to a stack
overflow.
|
| | |/
|/|
| |
| |
| |
| |
| |
| | |
Fixes warning from
cargo -o doc --document-private-items --all-features --workspace
This was evidentlhy overlooked during recent replacement of unescorted
private keys in the code.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |/
|
|
| |
(`cargo-upgrade` warns about this.)
|
| |\
| |
| |
| |
| | |
Fix a few warnings from clippy nightly
See merge request tpo/core/arti!1193
|
| | |
| |
| |
| |
| |
| | |
I could also have stopped using `::default()` to construct this
(testing-only) object, but I think it makes more sense to turn it
into a non-unit object.
|
| | |
| |
| |
| | |
Found by clippy nightly
|
| | |
| |
| |
| |
| | |
I don't love this change, but apparently we are trying for
"consistency".
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Refactor code not to use unescorted ed25519 secrets
Closes #798
See merge request tpo/core/arti!1192
|
| | | |
| | |
| | |
| | |
| | | |
(It said that we want to deprecate all unescorted secret keys; in
fact, only unescorted EdDSA secrets are bad.)
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Fortunately, these are all in experimental code.
Closes #798
|
| | | |
| | |
| | |
| | | |
Part of #798: We no longer use unescorted ed25519 secret keys.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Per #798, we want to make sure that we never pass around an
`ed25519::SecretKey`; only an `ed25519::Keypair` (or
`ExpandedKeypair`). This is because, when you're computing an
ed25519 signature, you have to use the public key as one of your
inputs, and if you ever use a mismatched public key you are
vulnerable to a nonce reuse attack.
(For more info see
https://moderncrypto.org/mail-archive/curves/2020/001012.html )
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is like an `ed25519::Keypair`, except that instead of a
`SecretKey` it contains an `ExpandedSecretKey`.
We'll be using this to implement #798, where we impose a rule that
there must be no "unescorted" ed25519 secret keys.
|
| |\ \ \
| |_|/
|/| |
| | |
| | |
| | |
| | | |
tor-proto: Add support for extending circuits through virtual hops.
Closes #726
See merge request tpo/core/arti!1191
|
| | | |
| | |
| | |
| | | |
Based on text from @diziet
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
Sadly, this adds a few more `TODO HS` entries, but I think we can
clean them up later after a bit of discussion.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
There are a few new TODO hs comments, though, and an XXXX I'll need
to fix up in the next commit.
Implements #726.
|
| | | |
| | |
| | |
| | |
| | | |
This is fairly straightforward, thanks to our existing design work
on this code.
|
| | |/
|/|
| |
| |
| |
| |
| |
| | |
- We make the tor-guardmgr "We have found that {} is usable" line
include the word "guard", otherwise it doesn't appear very useful to a
user in safe logging mode, since the guard gets replaced with
[scrubbed].
- The "Actually got an end cell..." message is downgraded to DEBUG.
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Clean up hs_ntor.rs, add test vectors generated by C tor, and fix some bugs
Closes #865
See merge request tpo/core/arti!1189
|
| | | | |
|
| | | |
| | |
| | |
| | | |
This is still not the most beautiful interface, but it'll do for now.
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
There were two bugs here that made the behavior unlike that of C
tor: we had swapped the MAC inputs, and we had forgotten to include
the public key X in the input.
|
| | | |
| | |
| | |
| | | |
We'll want these so we can implement some test vectors.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
I think that these Input structs had been defined so that we could
use hs_ntor interchangeably with other handshakes. The trouble is,
though, that it doesn't really work like any other handshakes we
have.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Note that some of the invocations for this function seem to put the
key and the message in a questionable order. But that's a thing to
figure out later, while debugging.
|
| | | | |
|
| | |/ |
|
| | |
| |
| |
| |
| |
| | |
We never want to create one of these from its parts except when we
are testing it; we only want to forward an Introduce1 message with a
new command on it.
|
| | |
| |
| |
| |
| | |
We'll need to store this so that it can later on be used to complete
the hs_ntor handshake.
|
| |/
|
|
|
|
|
|
| |
We'll want this because our hs_ntor handshake requires access to an
encoded version of the header independent from the actual encrypted
message.
part of #866.
|
| |\
| |
| |
| |
| |
| |
| | |
Change log levels of messages from INFO to others
Closes #854
See merge request tpo/core/arti!1172
|