summaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix documentation references for tor-rtcompat refactoring.Nick Mathewson2022-01-263-14/+18
|
* arti: be more careful to use the user-selected runtimeNick Mathewson2022-01-262-5/+13
|
* Rename `SpawnBlocking` trait to `BlockOn`.Nick Mathewson2022-01-2611-21/+21
| | | | | This avoids a future confusion with the new `SpawnBlocking` trait in async_executors v0.5, and better describes what the trait provides.
* Make test_with_all_runtimes cover _all_ the runtimes.Nick Mathewson2022-01-266-84/+138
| | | | | | | | | | | This took some refactoring, so that I wouldn't need to define 9 different versions of the function. It also required that we change the behavior of test_with_all_runtimes slightly, so that it asserts on _any_ failure rather than asserting on most but returning Err() for others. That in turn required changes to a few of its callers. There's probably a better way to do all of this macro business, but this is the best I could find.
* Make the native-tls crate optional.Nick Mathewson2022-01-2621-45/+143
| | | | | | | | | | | This commit puts the native-tls crate behind a feature. The feature is off-by-default in the tor-rtcompat crate, but can be enabled either from arti or arti-client. There is an included script that I used to test that tor-rtcompat could build and run its tests with all subsets of its features. Closes #300
* Define aliases for "the best enabled runtime".Nick Mathewson2022-01-264-23/+45
| | | | | This helps us simplify our code in a few ways, and will help even more once native_tls is optional.
* Make current/create functions into runtime member functions.Nick Mathewson2022-01-269-104/+127
| | | | | This should help avoid some amount of temptation towards API proliferation.
* Rename FooRuntime to FooNativeTlsRuntime for consistency.Nick Mathewson2022-01-265-23/+25
|
* Limit the inner types in tor-rtcompat that have to implement CloneNick Mathewson2022-01-263-33/+10
| | | | | If we implement our own clone on CompoundRuntime, we no longer need Clone implementations on our TlsProvider implementations.
* Remove no-longer-needed tokio runtime helper macroNick Mathewson2022-01-261-27/+18
|
* Unify TokioRuntime and TokioRuntimeHandleNick Mathewson2022-01-264-66/+54
| | | | | | | | | Having separate types here doesn't justify the (very limited) benefit of distinguishing between the case where we have created an executor that we own and the case where we have a handle to an already-running tokio executor. Part of #301.
* Remove a now-incorrect comment in tor-proto.Nick Mathewson2022-01-261-3/+0
|
* Remove misspellings of "rusttls".Nick Mathewson2022-01-261-2/+2
|
* More comments on the limitations of tor-rtcompat's TLS APINick Mathewson2022-01-252-3/+29
| | | | | Also, more comments on why these limitations are safe within the context of Tor, but you wouldn't want to use them elsewhere.
* Comment-only: document sni_hostname more.Nick Mathewson2022-01-251-3/+5
| | | | | Previously we expected the reader to automatically know why it was called "SNI", which really isn't fair.
* Refactor native_tls usage into its own moduleNick Mathewson2022-01-257-230/+130
| | | | | This change uses the async-native-tls crate for everything, and deletes some duplicated code.
* tor-rtcompat: Add support for rustls.Nick Mathewson2022-01-258-9/+461
| | | | | | | | | | | | | | | | | | | This is based on @janimo's approach in !74, but diverges in a few important ways. 1. It assumes that something like !251 will merge, so that we can have separate implementations for native_tls and rustls compiled at the same time. 2. It assumes that we can implement this for the futures::io traits only with no real penalty. 3. It uses the `x509-signature` crate to work around the pickiness of the `webpki` crate. If webpki eventually solves their [bug 219](https://github.com/briansmith/webpki/issues/219), we can remove a lot of that workaround. Closes #86.
* Add a C program to make Tor-style X509 link certificatesNick Mathewson2022-01-241-0/+159
| | | | | We should never use this for anything but making the testing certificates we use for making sure our TLS implementation works.
* Merge branch 'ticket255' into 'main'eta2022-01-249-45/+339
|\ | | | | | | | | | | | | Refactor our Runtime implementations to allow replacement parts Closes #255 See merge request tpo/core/arti!251
| * Refactor Runtimes to use separate TLS implementations internally.Nick Mathewson2022-01-198-45/+135
| | | | | | | | | | This will make it easier to implement them using some other TLS provider as well, without having to duplicate all of our code.
| * Add a macro to help with opaque Runtime wrappers.Nick Mathewson2022-01-192-0/+70
| | | | | | | | | | | | | | We're soon going to have our different Runtime types be built as CompoundRuntime instances. We don't want to expose that detail, though, so we'll use this macro to make them implement the right traits.
| * Add a CompoundRuntime type for runtime construction.Nick Mathewson2022-01-192-0/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | This type can solve two problems at once. First, it lets users replace parts of an existing runtime implementation without replacing the whole thing. For example, you can use it to override your TcpProvider implementation to solve problems like #235. Second, we can use it internally to tor-rtcompat to define Runtimes piece-by-piece. Mostly we'll use this to separate our Tls implementations from our implementations of the rest of the Runtime.
* | Rename TorClient::set_stream_prefsIan Jackson2022-01-211-2/+2
| | | | | | | | | | | | | | In line with the rest of the renaming. As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/256#note_2771617
* | StreamPrefs: Re-alphabetise imports following renameIan Jackson2022-01-211-1/+1
| | | | | | | | Placates rustfmt
* | StreamPrefs: rename from ConnectPrefsIan Jackson2022-01-215-20/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | The docs even say this is about stream. As @nickm writes in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/252#note_2771289 we generally call end-to-end connections that are tunneled over Tor "Streams" to distinguish them from everything else in the Tor protocols that could possibly be called a "Connection". That seems to apply here too.
* | Merge branch 'always-isolate' into 'main'Ian Jackson2022-01-201-4/+58
|\ \ | | | | | | | | | | | | | | | | | | Provide isolate-all-streams function Closes #279 See merge request tpo/core/arti!252
| * | isolation: Rename isolate_every_stream from ..._connectionIan Jackson2022-01-201-1/+1
| | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/252#note_2771291
| * | isolation: Rename (internal) EveryStream enum variantIan Jackson2022-01-201-3/+3
| | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/252#note_2771289
| * | isolation: Much better wording for always isolate settingNick Mathewson2022-01-201-1/+6
| | |
| * | isolation: Provide isolate-every-connection optionIan Jackson2022-01-201-0/+16
| | |
| * | isolation: Provide new_isolation_group methodIan Jackson2022-01-201-0/+14
| | | | | | | | | | | | | | | | | | | | | In the usual case, set_isolation_group is awkward. This is perhaps slightly duplicative with TorClient::isolated_client(). If so then perhaps the *latter* should be abolished.
| * | isolation: Refactor to introduce a bespoke enumIan Jackson2022-01-201-4/+23
| | | | | | | | | | | | | | | | | | No functional change. This will grow a new variant shortly.
* | | Test for PathConfig::at_least_as_permissive_as().Nick Mathewson2022-01-201-0/+29
| | | | | | | | | | | | | | | | | | This is totally not just an exercise to get combined test coverage for tor-circmgr over 90% because I needed something to do that wouldn't distract anybody else. :)
* | | Rename PathConfig::more_permissive_than()Nick Mathewson2022-01-202-2/+4
| | | | | | | | | | | | | | | | | | Since it implements a "<=" type relationship, it should be called "at_least_as_permissive_as()." Since it's a crate-private function, the long name isn't too bad.
* | | Remove "self" arg from PathConfig::builder()Nick Mathewson2022-01-201-1/+1
| | | | | | | | | | | | This was added by mistake.
* | | Merge branch 'stuff-prefs' into 'main'Nick Mathewson2022-01-202-21/+62
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | Provide TorClient::set_default_prefs and clone_with_prefs Closes #290 See merge request tpo/core/arti!250
| * | connection preferences: Make `set_default_prefs` private for nowIan Jackson2022-01-201-1/+4
| | |
| * | connection preferences: Make `clone_with_prefs` must_useIan Jackson2022-01-201-0/+1
| |/ | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/250#note_2771239
| * connection preferences: Provide `clone_with_prefs` methodIan Jackson2022-01-191-0/+10
| |
| * connection preferences: Provide `set_connect_prefs` methodIan Jackson2022-01-191-6/+22
| |
| * connection preferences: Take ConnectPrefs by referenceIan Jackson2022-01-192-12/+12
| | | | | | | | | | This may save quite a bit of copying. The callees don't need to copy the whole struct; they copy the bits they need.
| * connection preferences: Rename variable and docs to not say "flags"Ian Jackson2022-01-191-12/+12
| | | | | | | | These aren't flags. Eg, there's an isolation token in there.
| * isolation: Document orthogonality of isolated_client and isolation_groupIan Jackson2022-01-191-0/+11
| |
* | clippy: Rename a `decode_chanmsg` from `handle_`Ian Jackson2022-01-192-4/+4
| | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/249#note_2771025 It doens't really handle it.
* | handshake: Use read_exact, not read and checking lenIan Jackson2022-01-191-3/+7
|/ | | | | | | | | read_exact has a loop in it, which we need. This means we end up separating the two sites that generate the "not a relay" error, so we need to fish out the error construction. As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/249#note_2771023
* clippy: Rename a `from_foo` method that doesn't do conversionIan Jackson2022-01-193-5/+7
|
* Fix two bugs related to incomplete read/writeIan Jackson2022-01-191-3/+3
| | | | Discovered by clippy
* clippy: Suppress a warningIan Jackson2022-01-191-0/+3
|
* Merge branch 'bootstrap_reporting'Nick Mathewson2022-01-1911-54/+1208
|\
| * bootstrap reporting: Documentation fixups from review.Nick Mathewson2022-01-192-2/+14
| |