summaryrefslogtreecommitdiff
path: root/crates/tor-socksproto/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'socks_errorkinds' into 'main'Nick Mathewson2023-06-221-0/+8
|\ | | | | | | | | | | | | Generate correct-ish socks5 errors for onion service errors. Closes #736 See merge request tpo/core/arti!1279
| * socksproto: Add unspecified but documented socks5 extension codesNick Mathewson2023-06-221-0/+8
| |
* | lints: Run maint/add_warning to actually apply new lintsIan Jackson2023-06-211-0/+2
|/
* s/ProtocolFailed/ProtocolViolation/g where possibleNeel Chauhan2023-04-081-1/+1
|
* Change tor_bytes::Error::BadMessage to a Cow.Nick Mathewson2023-02-092-4/+6
| | | | | | | | | | Actually, to avoid making a breaking change, I'm deprecating BadMessage and creating a new InvalidMessage variant that takes a Cow. This way I don't need to track every crate that re-exposes tor_bytes::Error and call this a breaking change in those. Making this change will allow tor_bytes errors to be much more helpful.
* Allow clippy::unchecked_duration_subtraction in testsNick Mathewson2023-01-274-0/+4
| | | | | This panics on error, and we're fine with a panic on misbehavior in tests.
* Disable clippy::unlinlined-format-argsNick Mathewson2023-01-271-0/+1
| | | | | | | | This warning kind of snuck up on us! (See #748) For now, let's disable it. (I've cleaned it up in a couple of examples, since those are meant to be more idiomatic and user-facing.) Closes #748.
* Prop304: Add extended SOCKS result codes for onion servicesNeel Chauhan2023-01-181-0/+12
|
* test lint blocks: Add many many automaticallyIan Jackson2022-12-122-0/+16
| | | | | This is precisely the result of running the rune in maint/adhoc-add-lint-blocks.
* test lint blocks: Standardise one in tor-socksprotoIan Jackson2022-12-121-2/+2
| | | | | The previous syntax was recognised by the real script, but not by the ad-hoc script I'm about to use to add all the missing ones.
* Run add_warnings.Nick Mathewson2022-11-031-0/+1
|
* socksproto: Make a method conditional.Nick Mathewson2022-10-201-0/+1
|
* socksproto: impl Clone for Error.Nick Mathewson2022-10-201-1/+1
|
* cargo fmt to remove blank linesIan Jackson2022-10-121-1/+0
| | | | | | | Apparently cargo fmt doesn't like these, which my perl rune didn't delete. This commit is precisely the result of `cargo fmt`.
* Replace all README copies in src/lib.rs with includesIan Jackson2022-10-121-57/+1
| | | | | | | | The feature we want is `#[doc = include_str!("README.md")]`, which is stable since 1.54 and our MSRV is now 1.56. This commit is precisely the result of the following Perl rune: perl -i~ -0777 -pe 's{(^//!(?!.*\@\@).*\n)+}{#![doc = include_str!("../README.md")]\n}m' crates/*/src/lib.rs
* Allow "clippy::single_char_pattern" in tests.Ian Jackson2022-10-122-0/+2
| | | | | | | This lint exists for perf reasons, and this is rarely relevant in tests. Using double quoted str is generally cognitively less burdensome.
* Make some things precisely conditionalIan Jackson2022-10-111-1/+6
| | | | | | | I think this is quite an inconvenient way to be carrying on. Maybe we should disable all dead code warnings unless all features are also enabled, and just let the compiler get rid of unused stuff later.
* Move generate_* methods in socks client impl.Nick Mathewson2022-10-031-34/+38
|
* Require no NUL in socks hostname.Nick Mathewson2022-10-031-0/+6
|
* Tweak "handshake" docs.Nick Mathewson2022-10-032-4/+12
| | | | | Per a suggestion from Diziet, clarify that the socks handshake code only wants you to drain your buffers when it tells you to.
* Add a SocksReply type to capture address/port information.Nick Mathewson2022-10-034-24/+87
| | | | | I don't expect us to need this information much, but we may as well hang on to it.
* Make sure that socks4 auth doesn't have any 0 bytes.Nick Mathewson2022-10-031-16/+44
| | | | | Try to do it in constant time, to avoid even the smell of side-channel attacks.
* Tests for socks client handshake.Nick Mathewson2022-10-033-0/+279
| | | | | | These tests include a few reference cases, as well as a little framework to make sure that the client and the proxy implementation will handshake with one another successfully.
* Bug fix: report empty SOCKS4 auth as "no auth".Nick Mathewson2022-10-031-2/+6
| | | | | Previously we would report it as authenticating using the empty string.
* Fuzzer code for socks client implementation.Nick Mathewson2022-10-031-1/+50
|
* Implement client-side SOCKS handshakeNick Mathewson2022-09-286-7/+320
|
* Make "SocksRequest::new" public.Nick Mathewson2022-09-271-1/+17
| | | | Also, have it enforce more correctness properties.
* socksproto: Rename SocksHandshake to SocksProxyHandshake.Nick Mathewson2022-09-273-521/+540
| | | | | | | | Retain "SocksHandshake" as a deprecated synonym. Also, make an (on-by-default) feature for SocksProxyHandshake. (There is about to be a SocksClientHandshake as well.)
* enable doc_auto_cfg feature on every crate when documenting for docs.rstrinity-1686a2022-08-241-0/+1
|
* socksproto: Use fallible writers.Nick Mathewson2022-07-111-16/+19
| | | | Also, make private a function that had formerly been `pub`.
* Convert each write_onto_infallible implementation into write_onto.Nick Mathewson2022-07-111-2/+3
|
* Rename "write" methods on tor-bytes to "write_infallible".Nick Mathewson2022-07-111-7/+7
| | | | | | | | | | | | | | | This comprises four renames: ``` write_onto -> write_onto_infallible write_into -> write_into_infallible write -> write_infallible writer_and_consume -> write_and_consume_infallible. ``` The rest of this branch will be concerned with replacing these `_infallible` methods with ones that return a `Result`. This is part of #513.
* Run maint/add_warning crates/*/src/{lib,main}.rsIan Jackson2022-06-231-0/+3
| | | | Update all lint blocks
* tor-socksproto: Style and info fixes in errors.Nick Mathewson2022-06-223-9/+15
| | | | | (The use of Cow<> in the error message isn't strictly necessary here, but it's a pattern I want to encourage.)
* lints: Add let_unit_value allow to all cratesIan Jackson2022-05-311-0/+1
| | | | | From running add_warning, with manual picking of the right hunks/lines.
* lints: Add lint block delimiters to every crateIan Jackson2022-05-311-0/+2
| | | | | | This was the result of: maint/add_warning crates/*/src/{lib,main}.rs and then manually curating the results.
* Resolve the new `derive_partial_eq_without_eq` lint.Nick Mathewson2022-05-231-1/+1
| | | | It's a little overzealous sometimes, but it's mostly to the good.
* squash! Bump every crate's edition to 2021.Nick Mathewson2022-04-252-3/+0
| | | | | Remove all `use` statements for `TryFrom` and `TryInto`. These are now redundant in Rust 2021.
* socksproto: remove some unused accessors.Nick Mathewson2022-04-021-15/+0
|
* Disable clippy::clone_on_ref_ptrIan Jackson2022-02-241-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lint is IMO inherently ill-conceived. I have looked for the reasons why this might be thought to be a good idea and there were basically two (and they are sort of contradictory): I. "Calling ‘.clone()` on an Rc, Arc, or Weak can obscure the fact that only the pointer is being cloned, not the underlying data." This is the wording from https://rust-lang.github.io/rust-clippy/v0.0.212/#clone_on_ref_ptr It is a bit terse; we are left to infer why it is a bad idea to obscure this fact. It seems to me that if it is bad to obscure some fact, that must be because the fact is a hazard. But why would it be a hazard to not copy the underlying data ? In other languages, faliing to copy the underlying data is a serious correctness hazard. There is a whose class of bugs where things were not copied, and then mutated and/or reused in multiple places in ways that were not what the programmer intended. In my experience, this is a very common bug when writing Python and Javascript. I'm told it's common in golang too. But in Rust this bug is much much harder to write. The data inside an Arc is immutable. To have this bug you'd have use interior mutability - ie mess around with Mutex or RefCell. That provides a good barrier to these kind of accidents. II. "The reason for writing Rc::clone and Arc::clone [is] to make it clear that only the pointer is being cloned, as opposed to the underlying data. The former is always fast, while the latter can be very expensive depending on what is being cloned." This is the reasoning found here https://github.com/rust-lang/rust-clippy/issues/2048 This is saying that *not* using Arc::clone is hazardous. Specifically, that a deep clone is a performance hazard. But for this argument, the lint is precisely backwards. It's linting the "good" case and asking for it to be written in a more explicit way; while the supposedly bad case can be written conveniently. Also, many objects (in our codebase, and in all the libraries we use) that are Clone are in fact simply handles. They contain Arc(s) (or similar) and are cheap to clone. Indeed, that is the usual case. It does not make sense to distinguish in the syntax we use to clone such a handle, whether the handle is a transparent Arc, or an opaque struct containing one or more other handles. Forcing Arc::clone to be written as such makes for code churn when a type is changed from Arc<Something> to Something: Clone, or vice versa.
* tor-socksproto: Use bad_api_usage! rather than ad-hoc Invalid errorIan Jackson2022-02-152-8/+3
|
* Make Bug from InternalError, add bad_api_usage! and into_bad_api_usage!Ian Jackson2022-02-151-6/+6
| | | | Including supporting machinery, new kind field, etc.
* New name and semantics for BadAPIUsage (was BadArgument)Ian Jackson2022-02-151-1/+3
|
* Merge branch 'error-socksproto-autoconvert' into 'main'Nick Mathewson2022-02-142-14/+7
|\ | | | | | | | | Provide, and use From impl for InternalError See merge request tpo/core/arti!315
| * Run rustfmt.Nick Mathewson2022-02-141-12/+5
| |
| * Provide, and use From impl for InternalErrorIan Jackson2022-02-142-8/+8
| | | | | | | | | | | | | | | | Adding this autoconversion is quite safe since every error generation site is explicit and has its own context, and we don't really need to add more. This simplifies the code and will simplify future work.
* | Merge branch 'warn_not_deny' into 'main'eta2022-02-141-1/+1
|\ \ | | | | | | | | | | | | | | | | | | Change deny(clippy::all) to warn(clippy::all). Closes #338 See merge request tpo/core/arti!306
| * | Change deny(clippy::all) to warn(clippy::all).Nick Mathewson2022-02-141-1/+1
| |/ | | | | | | Closes #338.
* | Merge remote-tracking branch 'origin/mr/313'Nick Mathewson2022-02-141-2/+2
|\ \
| * | tor_socksproto::Error HasKind fix two delegationsIan Jackson2022-02-141-2/+2
| |/ | | | | | | | | | | | | | | | | | | We should not generally explicitly specify a kind for errors which contain a more detailed error which itself has a kind. Stating the kind literally is a latent bug, which becomes a real bug if the contained type's kind changes or starts to vary. (There may be exceptions to this principle but this isn't one of them.)
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-26 23:02:59 +0000